All of lore.kernel.org
 help / color / mirror / Atom feed
From: poma <pomidorabelisima@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/udl: Fix for the X server screen update v3
Date: Wed, 21 Sep 2016 06:47:35 +0200	[thread overview]
Message-ID: <f986aec5-e069-d355-79fc-cd6e050e0be2@gmail.com> (raw)
In-Reply-To: <CAKMK7uHExDBisQqceFS+XFtX9UG_jCOqACU2H2bN1-=ui4tc2g@mail.gmail.com>

Within X server, on top of DisplayLink GPU USB2.0 device,
screen content is not refreshed i.e. updated.

This fixes commit:

- e375882406d0cc24030746638592004755ed4ae0
  "drm/udl: Use drm_fb_helper deferred_io support"

Thanks Noralf and Daniel for the comments.

Tested-by: poma <poma@gmail.com>
---
 drivers/gpu/drm/udl/udl_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index d5df555..cc2daba 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -122,7 +122,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
 		return 0;
 	cmd = urb->transfer_buffer;
 
-	for (i = y; i < height ; i++) {
+	for (i = y; i < y + height ; i++) {
 		const int line_offset = fb->base.pitches[0] * i;
 		const int byte_offset = line_offset + (x * bpp);
 		const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp);
-- 
2.7.4


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-09-21  4:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 14:44 UDL: screen update breakage poma
2016-09-18 10:20 ` Noralf Trønnes
2016-09-18 13:48   ` [PATCH] drm/udl: Fix for the X server screen update poma
2016-09-18 17:42     ` Noralf Trønnes
2016-09-19  6:41       ` poma
2016-09-19 18:27         ` [PATCH] drm/udl: Fix for the X server screen update v2 poma
2016-09-19 21:12           ` Daniel Vetter
2016-09-21  4:47             ` poma [this message]
2016-09-21  7:34               ` [PATCH] drm/udl: Fix for the X server screen update v3 David Herrmann
2016-09-21 11:19                 ` poma
2016-09-21 11:33                   ` David Herrmann
2016-09-21 14:57                     ` poma
2016-09-21 18:51                       ` Jani Nikula
2016-09-21 11:35                   ` Jani Nikula
2016-09-22 12:23             ` [PATCH] drm/udl: Fix for the X server screen update v2 poma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f986aec5-e069-d355-79fc-cd6e050e0be2@gmail.com \
    --to=pomidorabelisima@gmail.com \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.