From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Date: Wed, 20 Dec 2023 09:00:48 +0000 Subject: [PATCH v4 11/11] KVM: selftests: Enable tunning of err_margin_us in arch timer test In-Reply-To: References: <0343a9e4bfa8011fbb6bca0286cee7eab1f17d5d.1702371136.git.haibo1.xu@intel.com> <8734vy832j.wl-maz@kernel.org> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2023-12-20 06:50, Haibo Xu wrote: > On Wed, Dec 20, 2023 at 2:22?AM Marc Zyngier wrote: >> >> On Tue, 12 Dec 2023 09:31:20 +0000, >> Haibo Xu wrote: >> > > @@ -216,6 +221,9 @@ static bool parse_args(int argc, char *argv[]) >> > case 'm': >> > test_args.migration_freq_ms = atoi_non_negative("Frequency", optarg); >> > break; >> > + case 'e': >> > + test_args.timer_err_margin_us = atoi_non_negative("Error Margin", optarg); >> > + break; >> >> So your error margin is always unsigned... >> > > The error margin was supposed to be a non-negative [0, INT_MAX]. > (May be need to define a Max for the input, instead of INT_MAX) > >> > case 'o': >> > test_args.counter_offset = strtol(optarg, NULL, 0); >> > test_args.reserved = 0; >> > diff --git a/tools/testing/selftests/kvm/include/timer_test.h b/tools/testing/selftests/kvm/include/timer_test.h >> > index 968257b893a7..b1d405e7157d 100644 >> > --- a/tools/testing/selftests/kvm/include/timer_test.h >> > +++ b/tools/testing/selftests/kvm/include/timer_test.h >> > @@ -22,6 +22,7 @@ struct test_args { >> > int nr_iter; >> > int timer_period_ms; >> > int migration_freq_ms; >> > + int timer_err_margin_us; >> >> ... except that you are storing it as a signed value. Some consistency >> wouldn't hurt, really, and would avoid issues when passing large >> values. >> > > Yes, it's more proper to use an unsigned int for the non-negative error > margin. > Storing as signed here is just to keep the type consistent with that > of timer_period_ms > since there will be '+' operation in other places. > > tools/testing/selftests/kvm/aarch64/arch_timer.c > /* Setup a timeout for the interrupt to arrive */ > udelay(msecs_to_usecs(test_args.timer_period_ms) + > test_args.timer_err_margin_us); But that's exactly why using a signed quantity is wrong. What does it mean to have a huge *negative* margin? I don't see how you can justify this. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E6DF1D6B1; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KF+fgMS9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D58C433C7; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703062851; bh=aP+or2O2Amx3o066NoYjmEoMeqgvW6u+ehSxtWedg58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KF+fgMS9J85VBtFxE6C+CCleuJv2Zec2Xe4q/rr8qCPuNT4X6BnizX1N/UkQkN0Uj nE3rnBnfP8GJp5JDIKnUtJT1EOslUeIc9Kz5N69A2/7m1+FIVrf69/71oD5mrDBFxI booZixCOostTgj5lokin2FLDaIOi2WdnoU8GbPtNSt+sF2yj7AclNl2tQftWrRBS7l JJyJBvH61E1GgPgIUr0Ld2sEUG0nbwpR+ldnI5O8jY1BRUmblOm5PXaKXgqHhgnQVW mA1nuVNA29MagVh7YGOQLOafINsTUpneKa1N6i2cXp2CD1Sm33c1/4UTrwQyw4bBKL qt8myFyRPxaTQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rFsRc-005chY-Hw; Wed, 20 Dec 2023 09:00:48 +0000 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 20 Dec 2023 09:00:48 +0000 From: Marc Zyngier To: Haibo Xu Cc: Haibo Xu , ajones@ventanamicro.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Shuah Khan , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Anup Patel , Atish Patra , Guo Ren , Mayuresh Chitale , Greentime Hu , wchen , Conor Dooley , Heiko Stuebner , Minda Chen , Samuel Holland , Jisheng Zhang , Sean Christopherson , Peter Xu , Like Xu , Vipin Sharma , Maciej Wieczor-Retman , Aaron Lewis , Thomas Huth , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v4 11/11] KVM: selftests: Enable tunning of err_margin_us in arch timer test In-Reply-To: References: <0343a9e4bfa8011fbb6bca0286cee7eab1f17d5d.1702371136.git.haibo1.xu@intel.com> <8734vy832j.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: xiaobo55x@gmail.com, haibo1.xu@intel.com, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, shuah@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, anup@brainfault.org, atishp@atishpatra.org, guoren@kernel.org, mchitale@ventanamicro.com, greentime.hu@sifive.com, waylingii@gmail.com, conor.dooley@microchip.com, heiko@sntech.de, minda.chen@starfivetech.com, samuel@sholland.org, jszhang@kernel.org, seanjc@google.com, peterx@redhat.com, likexu@tencent.com, vipinsh@google.com, maciej.wieczor-retman@intel.com, aaronlewis@google.com, thuth@redhat.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On 2023-12-20 06:50, Haibo Xu wrote: > On Wed, Dec 20, 2023 at 2:22 AM Marc Zyngier wrote: >> >> On Tue, 12 Dec 2023 09:31:20 +0000, >> Haibo Xu wrote: >> > > @@ -216,6 +221,9 @@ static bool parse_args(int argc, char *argv[]) >> > case 'm': >> > test_args.migration_freq_ms = atoi_non_negative("Frequency", optarg); >> > break; >> > + case 'e': >> > + test_args.timer_err_margin_us = atoi_non_negative("Error Margin", optarg); >> > + break; >> >> So your error margin is always unsigned... >> > > The error margin was supposed to be a non-negative [0, INT_MAX]. > (May be need to define a Max for the input, instead of INT_MAX) > >> > case 'o': >> > test_args.counter_offset = strtol(optarg, NULL, 0); >> > test_args.reserved = 0; >> > diff --git a/tools/testing/selftests/kvm/include/timer_test.h b/tools/testing/selftests/kvm/include/timer_test.h >> > index 968257b893a7..b1d405e7157d 100644 >> > --- a/tools/testing/selftests/kvm/include/timer_test.h >> > +++ b/tools/testing/selftests/kvm/include/timer_test.h >> > @@ -22,6 +22,7 @@ struct test_args { >> > int nr_iter; >> > int timer_period_ms; >> > int migration_freq_ms; >> > + int timer_err_margin_us; >> >> ... except that you are storing it as a signed value. Some consistency >> wouldn't hurt, really, and would avoid issues when passing large >> values. >> > > Yes, it's more proper to use an unsigned int for the non-negative error > margin. > Storing as signed here is just to keep the type consistent with that > of timer_period_ms > since there will be '+' operation in other places. > > tools/testing/selftests/kvm/aarch64/arch_timer.c > /* Setup a timeout for the interrupt to arrive */ > udelay(msecs_to_usecs(test_args.timer_period_ms) + > test_args.timer_err_margin_us); But that's exactly why using a signed quantity is wrong. What does it mean to have a huge *negative* margin? I don't see how you can justify this. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0395DC3DA6E for ; Wed, 20 Dec 2023 09:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=29FMKdj4Jtx5gkI6OVRg2gw4hiq5kxlnLorulEOWK3M=; b=LW0CmZ+we/fI7wvdsbd3x0tGRD m0AEl//SkgUVRq8C+8gWYA4GeB+f1f+WMsuBc+nHpX7Rp1DSRDtLGQ5xDn68nZur/N2emeKjBr4C/ UefkNVN1xraeD3BdVypxd2OpaZYMLDhjQJI5j0SG8a/nnuu/y3Jz8kV7KTPP9Op6ozLn9cGX8Ce5u N8u7nwYo6Be1BOWDClfcbOabYAnfSKwp13KZ5yoTGXTkp2eBtPOaW/zhdxaiJ0rbyXfhR5F4aAjP2 cP7Sr1iGbiwzs//LhRKDk3wA1rJT7qpoJtQOkb0lB6eyUrK6ps107JfQ8WE8233tJyJx0Wph0oC62 7oeQxj5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFsRl-00GfVY-00; Wed, 20 Dec 2023 09:00:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFsRg-00GfTL-2i; Wed, 20 Dec 2023 09:00:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDEA06155D; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D58C433C7; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703062851; bh=aP+or2O2Amx3o066NoYjmEoMeqgvW6u+ehSxtWedg58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KF+fgMS9J85VBtFxE6C+CCleuJv2Zec2Xe4q/rr8qCPuNT4X6BnizX1N/UkQkN0Uj nE3rnBnfP8GJp5JDIKnUtJT1EOslUeIc9Kz5N69A2/7m1+FIVrf69/71oD5mrDBFxI booZixCOostTgj5lokin2FLDaIOi2WdnoU8GbPtNSt+sF2yj7AclNl2tQftWrRBS7l JJyJBvH61E1GgPgIUr0Ld2sEUG0nbwpR+ldnI5O8jY1BRUmblOm5PXaKXgqHhgnQVW mA1nuVNA29MagVh7YGOQLOafINsTUpneKa1N6i2cXp2CD1Sm33c1/4UTrwQyw4bBKL qt8myFyRPxaTQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rFsRc-005chY-Hw; Wed, 20 Dec 2023 09:00:48 +0000 MIME-Version: 1.0 Date: Wed, 20 Dec 2023 09:00:48 +0000 From: Marc Zyngier To: Haibo Xu Cc: Haibo Xu , ajones@ventanamicro.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Shuah Khan , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Anup Patel , Atish Patra , Guo Ren , Mayuresh Chitale , Greentime Hu , wchen , Conor Dooley , Heiko Stuebner , Minda Chen , Samuel Holland , Jisheng Zhang , Sean Christopherson , Peter Xu , Like Xu , Vipin Sharma , Maciej Wieczor-Retman , Aaron Lewis , Thomas Huth , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v4 11/11] KVM: selftests: Enable tunning of err_margin_us in arch timer test In-Reply-To: References: <0343a9e4bfa8011fbb6bca0286cee7eab1f17d5d.1702371136.git.haibo1.xu@intel.com> <8734vy832j.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: xiaobo55x@gmail.com, haibo1.xu@intel.com, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, shuah@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, anup@brainfault.org, atishp@atishpatra.org, guoren@kernel.org, mchitale@ventanamicro.com, greentime.hu@sifive.com, waylingii@gmail.com, conor.dooley@microchip.com, heiko@sntech.de, minda.chen@starfivetech.com, samuel@sholland.org, jszhang@kernel.org, seanjc@google.com, peterx@redhat.com, likexu@tencent.com, vipinsh@google.com, maciej.wieczor-retman@intel.com, aaronlewis@google.com, thuth@redhat.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231220_010052_967294_89775545 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyMy0xMi0yMCAwNjo1MCwgSGFpYm8gWHUgd3JvdGU6Cj4gT24gV2VkLCBEZWMgMjAsIDIw MjMgYXQgMjoyMuKAr0FNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+PiAK Pj4gT24gVHVlLCAxMiBEZWMgMjAyMyAwOTozMToyMCArMDAwMCwKPj4gSGFpYm8gWHUgPGhhaWJv MS54dUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+ID4gQEAgLTIxNiw2ICsyMjEsOSBAQCBzdGF0aWMg Ym9vbCBwYXJzZV9hcmdzKGludCBhcmdjLCBjaGFyICphcmd2W10pCj4+ID4gICAgICAgICAgICAg ICBjYXNlICdtJzoKPj4gPiAgICAgICAgICAgICAgICAgICAgICAgdGVzdF9hcmdzLm1pZ3JhdGlv bl9mcmVxX21zID0gYXRvaV9ub25fbmVnYXRpdmUoIkZyZXF1ZW5jeSIsIG9wdGFyZyk7Cj4+ID4g ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiA+ICsgICAgICAgICAgICAgY2FzZSAnZSc6 Cj4+ID4gKyAgICAgICAgICAgICAgICAgICAgIHRlc3RfYXJncy50aW1lcl9lcnJfbWFyZ2luX3Vz ID0gYXRvaV9ub25fbmVnYXRpdmUoIkVycm9yIE1hcmdpbiIsIG9wdGFyZyk7Cj4+ID4gKyAgICAg ICAgICAgICAgICAgICAgIGJyZWFrOwo+PiAKPj4gU28geW91ciBlcnJvciBtYXJnaW4gaXMgYWx3 YXlzIHVuc2lnbmVkLi4uCj4+IAo+IAo+IFRoZSBlcnJvciBtYXJnaW4gd2FzIHN1cHBvc2VkIHRv IGJlIGEgbm9uLW5lZ2F0aXZlIFswLCBJTlRfTUFYXS4KPiAoTWF5IGJlIG5lZWQgdG8gZGVmaW5l IGEgTWF4IGZvciB0aGUgaW5wdXQsIGluc3RlYWQgb2YgSU5UX01BWCkKPiAKPj4gPiAgICAgICAg ICAgICAgIGNhc2UgJ28nOgo+PiA+ICAgICAgICAgICAgICAgICAgICAgICB0ZXN0X2FyZ3MuY291 bnRlcl9vZmZzZXQgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAwKTsKPj4gPiAgICAgICAgICAgICAg ICAgICAgICAgdGVzdF9hcmdzLnJlc2VydmVkID0gMDsKPj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMv dGVzdGluZy9zZWxmdGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oIGIvdG9vbHMvdGVzdGlu Zy9zZWxmdGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gaW5kZXggOTY4MjU3Yjg5 M2E3Li5iMWQ0MDVlNzE1N2QgMTAwNjQ0Cj4+ID4gLS0tIGEvdG9vbHMvdGVzdGluZy9zZWxmdGVz dHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gKysrIGIvdG9vbHMvdGVzdGluZy9zZWxm dGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gQEAgLTIyLDYgKzIyLDcgQEAgc3Ry dWN0IHRlc3RfYXJncyB7Cj4+ID4gICAgICAgaW50IG5yX2l0ZXI7Cj4+ID4gICAgICAgaW50IHRp bWVyX3BlcmlvZF9tczsKPj4gPiAgICAgICBpbnQgbWlncmF0aW9uX2ZyZXFfbXM7Cj4+ID4gKyAg ICAgaW50IHRpbWVyX2Vycl9tYXJnaW5fdXM7Cj4+IAo+PiAuLi4gZXhjZXB0IHRoYXQgeW91IGFy ZSBzdG9yaW5nIGl0IGFzIGEgc2lnbmVkIHZhbHVlLiBTb21lIGNvbnNpc3RlbmN5Cj4+IHdvdWxk bid0IGh1cnQsIHJlYWxseSwgYW5kIHdvdWxkIGF2b2lkIGlzc3VlcyB3aGVuIHBhc3NpbmcgbGFy Z2UKPj4gdmFsdWVzLgo+PiAKPiAKPiBZZXMsIGl0J3MgbW9yZSBwcm9wZXIgdG8gdXNlIGFuIHVu c2lnbmVkIGludCBmb3IgdGhlIG5vbi1uZWdhdGl2ZSBlcnJvciAKPiBtYXJnaW4uCj4gU3Rvcmlu ZyBhcyBzaWduZWQgaGVyZSBpcyBqdXN0IHRvIGtlZXAgdGhlIHR5cGUgY29uc2lzdGVudCB3aXRo IHRoYXQKPiBvZiB0aW1lcl9wZXJpb2RfbXMKPiBzaW5jZSB0aGVyZSB3aWxsIGJlICcrJyBvcGVy YXRpb24gaW4gb3RoZXIgcGxhY2VzLgo+IAo+ICAgICAgICAgdG9vbHMvdGVzdGluZy9zZWxmdGVz dHMva3ZtL2FhcmNoNjQvYXJjaF90aW1lci5jCj4gICAgICAgICAvKiBTZXR1cCBhIHRpbWVvdXQg Zm9yIHRoZSBpbnRlcnJ1cHQgdG8gYXJyaXZlICovCj4gICAgICAgICAgdWRlbGF5KG1zZWNzX3Rv X3VzZWNzKHRlc3RfYXJncy50aW1lcl9wZXJpb2RfbXMpICsKPiAgICAgICAgICAgICAgdGVzdF9h cmdzLnRpbWVyX2Vycl9tYXJnaW5fdXMpOwoKQnV0IHRoYXQncyBleGFjdGx5IHdoeSB1c2luZyBh IHNpZ25lZCBxdWFudGl0eSBpcyB3cm9uZy4KV2hhdCBkb2VzIGl0IG1lYW4gdG8gaGF2ZSBhIGh1 Z2UgKm5lZ2F0aXZlKiBtYXJnaW4/CgpJIGRvbid0IHNlZSBob3cgeW91IGNhbiBqdXN0aWZ5IHRo aXMuCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVu bnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24ACDC46CD3 for ; Wed, 20 Dec 2023 09:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=09dCgU1y32a0m4VHz1FweJasX00yFcZNZj47RsGDT2g=; b=WzNLOhW45lPalvtstxc5miSJUk UcEKdN5z9vEhq37hfvcWA//OwQ3cKqKiUdIsYfym0f7TaZJysempeESQVc8KtY4UTo6evnOaKkfMw yoUzcAx7fxjobloXSpuKrzgz7vrngTk/eohc2BHfrjlgNLYx60dpn2W6s8dH6+yRl0gxYUYbh6IcG T2s3MlyX+jcVtjK45aaejcnH5R8xm+oBUsIhK0gPI1gH5MAoDfpQ2z16gxmZ/zDbDmTzOT7J4l6xE ib/tAYai7zFiLtQ9xwC42sNcIqKnET65zMWssDOgZ7Dsi8n2quncIRE1phTkZyk4Tzasaw1MATJOr LB0JrvJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFsRk-00GfV4-1M; Wed, 20 Dec 2023 09:00:56 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFsRg-00GfTL-2i; Wed, 20 Dec 2023 09:00:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EDEA06155D; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D58C433C7; Wed, 20 Dec 2023 09:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703062851; bh=aP+or2O2Amx3o066NoYjmEoMeqgvW6u+ehSxtWedg58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KF+fgMS9J85VBtFxE6C+CCleuJv2Zec2Xe4q/rr8qCPuNT4X6BnizX1N/UkQkN0Uj nE3rnBnfP8GJp5JDIKnUtJT1EOslUeIc9Kz5N69A2/7m1+FIVrf69/71oD5mrDBFxI booZixCOostTgj5lokin2FLDaIOi2WdnoU8GbPtNSt+sF2yj7AclNl2tQftWrRBS7l JJyJBvH61E1GgPgIUr0Ld2sEUG0nbwpR+ldnI5O8jY1BRUmblOm5PXaKXgqHhgnQVW mA1nuVNA29MagVh7YGOQLOafINsTUpneKa1N6i2cXp2CD1Sm33c1/4UTrwQyw4bBKL qt8myFyRPxaTQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rFsRc-005chY-Hw; Wed, 20 Dec 2023 09:00:48 +0000 MIME-Version: 1.0 Date: Wed, 20 Dec 2023 09:00:48 +0000 From: Marc Zyngier To: Haibo Xu Cc: Haibo Xu , ajones@ventanamicro.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Shuah Khan , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Anup Patel , Atish Patra , Guo Ren , Mayuresh Chitale , Greentime Hu , wchen , Conor Dooley , Heiko Stuebner , Minda Chen , Samuel Holland , Jisheng Zhang , Sean Christopherson , Peter Xu , Like Xu , Vipin Sharma , Maciej Wieczor-Retman , Aaron Lewis , Thomas Huth , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v4 11/11] KVM: selftests: Enable tunning of err_margin_us in arch timer test In-Reply-To: References: <0343a9e4bfa8011fbb6bca0286cee7eab1f17d5d.1702371136.git.haibo1.xu@intel.com> <8734vy832j.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: xiaobo55x@gmail.com, haibo1.xu@intel.com, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, pbonzini@redhat.com, shuah@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, anup@brainfault.org, atishp@atishpatra.org, guoren@kernel.org, mchitale@ventanamicro.com, greentime.hu@sifive.com, waylingii@gmail.com, conor.dooley@microchip.com, heiko@sntech.de, minda.chen@starfivetech.com, samuel@sholland.org, jszhang@kernel.org, seanjc@google.com, peterx@redhat.com, likexu@tencent.com, vipinsh@google.com, maciej.wieczor-retman@intel.com, aaronlewis@google.com, thuth@redhat.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231220_010052_967294_89775545 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0xMi0yMCAwNjo1MCwgSGFpYm8gWHUgd3JvdGU6Cj4gT24gV2VkLCBEZWMgMjAsIDIw MjMgYXQgMjoyMuKAr0FNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+PiAK Pj4gT24gVHVlLCAxMiBEZWMgMjAyMyAwOTozMToyMCArMDAwMCwKPj4gSGFpYm8gWHUgPGhhaWJv MS54dUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+ID4gQEAgLTIxNiw2ICsyMjEsOSBAQCBzdGF0aWMg Ym9vbCBwYXJzZV9hcmdzKGludCBhcmdjLCBjaGFyICphcmd2W10pCj4+ID4gICAgICAgICAgICAg ICBjYXNlICdtJzoKPj4gPiAgICAgICAgICAgICAgICAgICAgICAgdGVzdF9hcmdzLm1pZ3JhdGlv bl9mcmVxX21zID0gYXRvaV9ub25fbmVnYXRpdmUoIkZyZXF1ZW5jeSIsIG9wdGFyZyk7Cj4+ID4g ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiA+ICsgICAgICAgICAgICAgY2FzZSAnZSc6 Cj4+ID4gKyAgICAgICAgICAgICAgICAgICAgIHRlc3RfYXJncy50aW1lcl9lcnJfbWFyZ2luX3Vz ID0gYXRvaV9ub25fbmVnYXRpdmUoIkVycm9yIE1hcmdpbiIsIG9wdGFyZyk7Cj4+ID4gKyAgICAg ICAgICAgICAgICAgICAgIGJyZWFrOwo+PiAKPj4gU28geW91ciBlcnJvciBtYXJnaW4gaXMgYWx3 YXlzIHVuc2lnbmVkLi4uCj4+IAo+IAo+IFRoZSBlcnJvciBtYXJnaW4gd2FzIHN1cHBvc2VkIHRv IGJlIGEgbm9uLW5lZ2F0aXZlIFswLCBJTlRfTUFYXS4KPiAoTWF5IGJlIG5lZWQgdG8gZGVmaW5l IGEgTWF4IGZvciB0aGUgaW5wdXQsIGluc3RlYWQgb2YgSU5UX01BWCkKPiAKPj4gPiAgICAgICAg ICAgICAgIGNhc2UgJ28nOgo+PiA+ICAgICAgICAgICAgICAgICAgICAgICB0ZXN0X2FyZ3MuY291 bnRlcl9vZmZzZXQgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAwKTsKPj4gPiAgICAgICAgICAgICAg ICAgICAgICAgdGVzdF9hcmdzLnJlc2VydmVkID0gMDsKPj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMv dGVzdGluZy9zZWxmdGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oIGIvdG9vbHMvdGVzdGlu Zy9zZWxmdGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gaW5kZXggOTY4MjU3Yjg5 M2E3Li5iMWQ0MDVlNzE1N2QgMTAwNjQ0Cj4+ID4gLS0tIGEvdG9vbHMvdGVzdGluZy9zZWxmdGVz dHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gKysrIGIvdG9vbHMvdGVzdGluZy9zZWxm dGVzdHMva3ZtL2luY2x1ZGUvdGltZXJfdGVzdC5oCj4+ID4gQEAgLTIyLDYgKzIyLDcgQEAgc3Ry dWN0IHRlc3RfYXJncyB7Cj4+ID4gICAgICAgaW50IG5yX2l0ZXI7Cj4+ID4gICAgICAgaW50IHRp bWVyX3BlcmlvZF9tczsKPj4gPiAgICAgICBpbnQgbWlncmF0aW9uX2ZyZXFfbXM7Cj4+ID4gKyAg ICAgaW50IHRpbWVyX2Vycl9tYXJnaW5fdXM7Cj4+IAo+PiAuLi4gZXhjZXB0IHRoYXQgeW91IGFy ZSBzdG9yaW5nIGl0IGFzIGEgc2lnbmVkIHZhbHVlLiBTb21lIGNvbnNpc3RlbmN5Cj4+IHdvdWxk bid0IGh1cnQsIHJlYWxseSwgYW5kIHdvdWxkIGF2b2lkIGlzc3VlcyB3aGVuIHBhc3NpbmcgbGFy Z2UKPj4gdmFsdWVzLgo+PiAKPiAKPiBZZXMsIGl0J3MgbW9yZSBwcm9wZXIgdG8gdXNlIGFuIHVu c2lnbmVkIGludCBmb3IgdGhlIG5vbi1uZWdhdGl2ZSBlcnJvciAKPiBtYXJnaW4uCj4gU3Rvcmlu ZyBhcyBzaWduZWQgaGVyZSBpcyBqdXN0IHRvIGtlZXAgdGhlIHR5cGUgY29uc2lzdGVudCB3aXRo IHRoYXQKPiBvZiB0aW1lcl9wZXJpb2RfbXMKPiBzaW5jZSB0aGVyZSB3aWxsIGJlICcrJyBvcGVy YXRpb24gaW4gb3RoZXIgcGxhY2VzLgo+IAo+ICAgICAgICAgdG9vbHMvdGVzdGluZy9zZWxmdGVz dHMva3ZtL2FhcmNoNjQvYXJjaF90aW1lci5jCj4gICAgICAgICAvKiBTZXR1cCBhIHRpbWVvdXQg Zm9yIHRoZSBpbnRlcnJ1cHQgdG8gYXJyaXZlICovCj4gICAgICAgICAgdWRlbGF5KG1zZWNzX3Rv X3VzZWNzKHRlc3RfYXJncy50aW1lcl9wZXJpb2RfbXMpICsKPiAgICAgICAgICAgICAgdGVzdF9h cmdzLnRpbWVyX2Vycl9tYXJnaW5fdXMpOwoKQnV0IHRoYXQncyBleGFjdGx5IHdoeSB1c2luZyBh IHNpZ25lZCBxdWFudGl0eSBpcyB3cm9uZy4KV2hhdCBkb2VzIGl0IG1lYW4gdG8gaGF2ZSBhIGh1 Z2UgKm5lZ2F0aXZlKiBtYXJnaW4/CgpJIGRvbid0IHNlZSBob3cgeW91IGNhbiBqdXN0aWZ5IHRo aXMuCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVu bnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK