From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] build/x86: suppress GNU ld 2.39 warning about RWX load segments
Date: Thu, 11 Aug 2022 15:14:30 +0000 [thread overview]
Message-ID: <f99169ee-e6b0-5c67-bf5e-e61e7cc31113@citrix.com> (raw)
In-Reply-To: <98c7b73e-0ef2-05ff-e150-cfc2f5506bd2@suse.com>
On 11/08/2022 13:12, Jan Beulich wrote:
> Commit 68f5aac012b9 ("build: suppress future GNU ld warning about RWX
> load segments") didn't quite cover all the cases: Apparently I missed
> ones in the building of 32-bit helper objects because of only looking at
> incremental builds (where those wouldn't normally be re-built). Clone
> the workaround there to the specific Makefile in question.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> Because of the use of LDFLAGS_DIRECT (coming directly from the Config.mk
> helpers in config/) having a central place to set this once isn't very
> easy: An option might be to introduce XEN_LDFLAGS_DIRECT and export that
> from where the other XEN_*FLAGS are also exported. The way it's done
> here is the less intrusive variant, though.
I think this is good enough for now. This makefile is full of magic anyway.
prev parent reply other threads:[~2022-08-11 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 12:12 [PATCH] build/x86: suppress GNU ld 2.39 warning about RWX load segments Jan Beulich
2022-08-11 15:14 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99169ee-e6b0-5c67-bf5e-e61e7cc31113@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.