From: "Christian König" <christian.koenig@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, Nirmoy Das <nirmoy.das@amd.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] drm/amdgpu: Remove unused variable
Date: Wed, 13 Jan 2021 15:13:39 +0100 [thread overview]
Message-ID: <f9a0e8f1-fd08-6730-2159-4c11dc89e4e3@amd.com> (raw)
In-Reply-To: <CADnq5_OmyiR8HaYDw4S9wH_JjFc_zzkaV33tqEOegNVRgZfU5w@mail.gmail.com>
Am 12.01.21 um 22:38 schrieb Alex Deucher:
> On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das <nirmoy.das@amd.com> wrote:
>> Remove unused space_needed variable.
>>
>> Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Have you already pushed this to drm-misc-next or should I take care of this?
Christian.
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 348ac678a230..5888367b1000 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
>> */
>> int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
>> {
>> - u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>> int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
>> struct pci_bus *root;
>> struct resource *res;
>> --
>> 2.29.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7CChristian.Koenig%40amd.com%7C55c33bd6f6874a973bff08d8b742783e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637460843402778720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=yizQB3RyltggTngn047YcPSDW3rFOTHffuVtDY3k3mI%3D&reserved=0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-13 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:46 [PATCH 1/1] drm/amdgpu: Remove unused variable Nirmoy Das
2021-01-12 21:38 ` Alex Deucher
2021-01-13 14:13 ` Christian König [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 13:03 [PATCH 1/1] drm/amdgpu: remove " Nirmoy Das
2020-05-26 13:21 ` Wang, Kevin(Yang)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a0e8f1-fd08-6730-2159-4c11dc89e4e3@amd.com \
--to=christian.koenig@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.