All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Charles Gorand" <charles.gorand@effinnov.com>,
	"Clément Perrochaud" <clement.perrochaud@nxp.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read()
Date: Sun, 26 Jun 2022 21:56:48 +0200	[thread overview]
Message-ID: <f9aa0597b22e2282abe7925135eebc4e@walle.cc> (raw)
In-Reply-To: <3c28bc43-4994-8e12-25f4-32b723e6e7ac@linaro.org>

Am 2022-06-26 21:51, schrieb Krzysztof Kozlowski:
> On 26/06/2022 21:42, Michael Walle wrote:
>> There are packets which doesn't have a payload. In that case, the 
>> second
>> i2c_master_read() will have a zero length. But because the NFC
>> controller doesn't have any data left, it will NACK the I2C read and
>> -ENXIO will be returned. In case there is no payload, just skip the
>> second i2c master read.
>> 
>> Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI 
>> driver")
>> Signed-off-by: Michael Walle <michael@walle.cc>
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks, I'll reorder the patches in the next version otherwise
there will likely be a conflict. That should work with any patch
tools (i.e. b4), shouldn't it?

-michael

  reply	other threads:[~2022-06-26 19:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 19:42 [PATCH 1/2] NFC: nxp-nci: check return code of i2c_master_recv() Michael Walle
2022-06-26 19:42 ` [PATCH 2/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read() Michael Walle
2022-06-26 19:51   ` Krzysztof Kozlowski
2022-06-26 19:56     ` Michael Walle [this message]
2022-06-26 20:02       ` Krzysztof Kozlowski
2022-06-28  5:03   ` Jakub Kicinski
2022-06-28  6:42     ` Michael Walle
2022-06-26 19:49 ` [PATCH 1/2] NFC: nxp-nci: check return code of i2c_master_recv() Krzysztof Kozlowski
2022-06-26 19:55   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9aa0597b22e2282abe7925135eebc4e@walle.cc \
    --to=michael@walle.cc \
    --cc=charles.gorand@effinnov.com \
    --cc=clement.perrochaud@nxp.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.