Re: [Buildroot] [PATCH 13/13] package/audit: bump version to 4.0.2

From: Julien Olivain <ju.o@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Adam Duskett <adam.duskett@amarulasolutions.com>,
	buildroot@buildroot.org,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Antoine Tenart <atenart@kernel.org>,
	Marek Belisko <marek.belisko@open-nandra.com>,
	"Fiona Klute (WIWA)" <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 13/13] package/audit: bump version to 4.0.2
Date: Sun, 27 Oct 2024 11:06:46 +0100	[thread overview]
Message-ID: <f9d70f87165b70be92829d43e9addca2@free.fr> (raw)
In-Reply-To: <20241026181808.4cae0be9@windsurf>

Hi Thomas, Adam, all,

On 26/10/2024 18:18, Thomas Petazzoni wrote:
> Hello Adam,
> 
> Cc Julien for runtime test, Cc Fiona for init script.
> 
> On Mon, 16 Sep 2024 17:12:06 +0200
> Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> 

[...]

>> Tested with qemu_x86_64_defconfig and running checking if audit is 
>> running
>> properly.
> 
> Would be nice to have an audit test case in support/testing :-)

Thanks for suggesting a new runtime test! I added this one on
my list.

While I quickly tried to draft something, I've hit the following
issue. Compiling with a (aarch64) Bootlin external toolchain, the
build failed with:

     libaudit.c: In function 'audit_rule_fieldpair_data':
     libaudit.c:1911:22: error: 'AUDIT_SADDR_FAM' undeclared (first use 
in this function); did you mean 'AUDIT_ADD_RULE'?
      1911 |                 case AUDIT_SADDR_FAM:
           |                      ^~~~~~~~~~~~~~~
           |                      AUDIT_ADD_RULE

This build failure is not happening with audit v3.1.2.

This is because the toolchain I used included Kernel headers 4.20.
This AUDIT_SADDR_FAM support was added in Kernel v5.3. See [1].

Also, audit v4.0 removed some definitions in [2]. This commit
claim to raise the Kernel header requirement to 5.0. Unless I missed
something, it seems there is a small discrepancy here (v5.0 ~ v5.3).
There is possibly a bug in the audit code (which should have kept
this definition). The audit code indeed claim kernel >= 5.0, see [3].

Anyways, whatever the exact kernel version is needed, I believe audit
needs a new "depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_x".

Adam, could you have a look at this?

Best regards,

Julien.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=bf361231c295d92a28ca283ea713f56e93e55796
[2] 
https://github.com/linux-audit/audit-userspace/commit/7e417fd78ae89eef8c512d4f1ded29d58b36f11b
[3] 
https://github.com/linux-audit/audit-userspace/blob/v4.0.2/README.md#build-time-dependencies-for-tar-file
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot