From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 199C1C64EC7 for ; Tue, 28 Feb 2023 13:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MeDeM3FySbb42N+1gkiiKUIlZEj4YBNvdcWWVaDcUKM=; b=nWwxnMoJHs4o0P JHVKRbTAPOEGw6wGQnd86+/NqoZE7aDnyT0mzqjPWoAPbcCFcHisvyn/HWasxJu5CokyY5eqYi1N9 unHdyZW3e2nJdchJcZ+nQ0WooYpZk5C0TgOON7p/4exNojMvdXtN/R7YLKo4sHtjTsfbP/27yc71+ 08NXb2Nlu1zTafNuaN1O/EOIfRCj+3bccnugFbntu85ocyd8yRs62L/s48mwG538fKsu/AfLM512Z COd+fljLB7G6lKD5Dr3NZlD+2nH8he/C9Z8m2bQOcztza4E6LMGkk57+guFcxH5+pdW3B38n/+XQV cliQyrz3a1I43iqmct6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWzqp-00DH9X-8R; Tue, 28 Feb 2023 13:17:03 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWzqk-00DH7o-Qq for linux-riscv@lists.infradead.org; Tue, 28 Feb 2023 13:17:01 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 5975424E287; Tue, 28 Feb 2023 21:16:23 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Feb 2023 21:16:23 +0800 Received: from [192.168.125.128] (113.72.145.171) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Feb 2023 21:16:21 +0800 Message-ID: Date: Tue, 28 Feb 2023 21:16:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver Content-Language: en-US To: Conor Dooley , Krzysztof Kozlowski , Emil Renner Berthing CC: , , , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Rob Herring , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , , "Conor Dooley" References: <20230220081926.267695-1-xingyu.wu@starfivetech.com> <20230220081926.267695-3-xingyu.wu@starfivetech.com> <0ffb02d2-0bbd-fd0d-b0f6-cb5605570050@starfivetech.com> <545c23f3-1d68-2bff-89d9-584e3ca31044@linaro.org> From: Xingyu Wu In-Reply-To: X-Originating-IP: [113.72.145.171] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230228_051659_535467_14922FD8 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/2/28 19:11, Conor Dooley wrote: > On Tue, Feb 28, 2023 at 11:57:58AM +0100, Krzysztof Kozlowski wrote: >> On 28/02/2023 11:51, Conor Dooley wrote: >> > On Tue, Feb 28, 2023 at 11:36:49AM +0100, Emil Renner Berthing wrote: >> >> On Tue, 28 Feb 2023 at 10:44, Xingyu Wu wrote: >> >>> On 2023/2/26 22:14, Emil Renner Berthing wrote: >> >>>> On Mon, 20 Feb 2023 at 09:21, Xingyu Wu wrote: >> > >> >>> So the dt-bingdings need to rename, and which one could be better, >> >>> 'starfive,jh71x0-wdt.yaml' or 'starfive,jh-wdt.yaml'? >> >> >> >> Sure, starfive,jh71x0-wdt.yaml sounds good to me. >> > >> > I feel like a common comment I see from the dt folks is to not put >> > wildcards in filenames & just pick the first compatible. >> > I could very well be wrong on that front though... >> >> First compatible is a bit better, unless you are sure this will cover >> all such compatibles now and in the future. For many bindings the >> family/wildcards were fine in filename. > > Ahh cool, good to know what the specific policy is - thanks! If this watchdog driver is improved to also support JH7100 in next patch, it seems more reasonable to rename the dt-bingdings to 'starfive,jh71x0-wdt.yaml'. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAA2C64ED6 for ; Tue, 28 Feb 2023 13:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjB1NQn (ORCPT ); Tue, 28 Feb 2023 08:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbjB1NQm (ORCPT ); Tue, 28 Feb 2023 08:16:42 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D522D17B; Tue, 28 Feb 2023 05:16:40 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 5975424E287; Tue, 28 Feb 2023 21:16:23 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Feb 2023 21:16:23 +0800 Received: from [192.168.125.128] (113.72.145.171) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Feb 2023 21:16:21 +0800 Message-ID: Date: Tue, 28 Feb 2023 21:16:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver Content-Language: en-US To: Conor Dooley , Krzysztof Kozlowski , Emil Renner Berthing CC: , , , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Rob Herring , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Philipp Zabel , Samin Guo , , "Conor Dooley" References: <20230220081926.267695-1-xingyu.wu@starfivetech.com> <20230220081926.267695-3-xingyu.wu@starfivetech.com> <0ffb02d2-0bbd-fd0d-b0f6-cb5605570050@starfivetech.com> <545c23f3-1d68-2bff-89d9-584e3ca31044@linaro.org> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.171] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 2023/2/28 19:11, Conor Dooley wrote: > On Tue, Feb 28, 2023 at 11:57:58AM +0100, Krzysztof Kozlowski wrote: >> On 28/02/2023 11:51, Conor Dooley wrote: >> > On Tue, Feb 28, 2023 at 11:36:49AM +0100, Emil Renner Berthing wrote: >> >> On Tue, 28 Feb 2023 at 10:44, Xingyu Wu wrote: >> >>> On 2023/2/26 22:14, Emil Renner Berthing wrote: >> >>>> On Mon, 20 Feb 2023 at 09:21, Xingyu Wu wrote: >> > >> >>> So the dt-bingdings need to rename, and which one could be better, >> >>> 'starfive,jh71x0-wdt.yaml' or 'starfive,jh-wdt.yaml'? >> >> >> >> Sure, starfive,jh71x0-wdt.yaml sounds good to me. >> > >> > I feel like a common comment I see from the dt folks is to not put >> > wildcards in filenames & just pick the first compatible. >> > I could very well be wrong on that front though... >> >> First compatible is a bit better, unless you are sure this will cover >> all such compatibles now and in the future. For many bindings the >> family/wildcards were fine in filename. > > Ahh cool, good to know what the specific policy is - thanks! If this watchdog driver is improved to also support JH7100 in next patch, it seems more reasonable to rename the dt-bingdings to 'starfive,jh71x0-wdt.yaml'.