Re: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec device

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/05/2025 07:08, Nas Chung wrote:
> Hi, Krzysztof.
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Friday, May 16, 2025 9:56 PM
>> To: Nas Chung <nas.chung@chipsnmedia.com>
>> Cc: mchehab@kernel.org; hverkuil@xs4all.nl; sebastian.fricke@collabora.com;
>> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; linux-
>> media@vger.kernel.org; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-imx@nxp.com; marex@denx.de; jackson.lee
>> <jackson.lee@chipsnmedia.com>; lafley.kim <lafley.kim@chipsnmedia.com>
>> Subject: Re: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec
>> device
>>
>> On 13/05/2025 09:39, Nas Chung wrote:
>>>>
>>>> All of above are wrong for the SoC...
>>>>
>>>>>
>>>>>         #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>>>         #include <dt-bindings/clock/nxp,imx95-clock.h>
>>>>>
>>>>>         soc {
>>>>>           #address-cells = <2>;
>>>>>           #size-cells = <2>;
>>>>>
>>>>>           vpu: video-codec {
>>>>>             compatible = "nxp,imx95-vpu", "cnm,wave633c";
>>>>
>>>> What does this device represent? It is not "ctrl", because you made ctrl
>>>> separate device node. Your binding description suggests that is the VPU
>>>> control region.
>>>
>>> My intention was to represent the MMIO VPU device, which includes
>>> both the core and control nodes.
>>
>> Then what is the VPU device if not CTRL? What is the CTRL device?
> 
> The VPU device represents the entire VPU hardware block,
> which includes 1 CTRL component(node) and 4 CORE components(nodes).

What is entire VPU hardware block?

> 
> The CTRL device represents the VCPU, a 32-bit processor embedded within the
> VPU hardware block. This VCPU is responsible for executing the VPU firmware.
> The CTRL device is in charge of tasks such as firmware booting, power management
> (sleep and wakeup command), and managing memory regions that are exclusively
> accessed by the firmware.

This sounds like CTRL is responsible for entire VPU block. What are the
tasks of VPU block then? What are its registers? What is that device
exactly doing?

You keep repeating the same, so my initial idea - CTRL is not a separate
block - still stands. Can you have more CTRL blocks than one?

Best regards,
Krzysztof