From: Jens Axboe <axboe@kernel.dk>
To: Qian Cai <cai@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths
Date: Fri, 30 Oct 2020 10:49:34 -0600 [thread overview]
Message-ID: <fa085de9-766c-156a-e6ef-bd834b0cc626@kernel.dk> (raw)
In-Reply-To: <09fa614adb555358d39ab606a8c6a2d89ba4a11d.camel@redhat.com>
On 10/30/20 9:52 AM, Qian Cai wrote:
> On Fri, 2020-10-30 at 09:27 -0600, Jens Axboe wrote:
>> On 10/30/20 9:24 AM, Qian Cai wrote:
>>> We will need to call putname() before do_renameat2() returning -EINVAL
>>> to avoid memory leaks.
>>
>> Thanks, should mention that this isn't final by any stretch (which is
>> why it hasn't been posted yet), just pushed out for some exposure.
>
> I don't know what other people think about this, but I do find a bit
> discouraging in testing those half-baked patches in linux-next where it does not
> even ready to post for a review.
I don't disagree with that and this doesn't normally happen. I don't
want to get into the reasonings, but things had to be shuffled which is
why they ended up in -next before being posted this week. They will go
out shortly.
--
Jens Axboe
next prev parent reply other threads:[~2020-10-30 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 15:24 [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Qian Cai
2020-10-30 15:27 ` Jens Axboe
2020-10-30 15:52 ` Qian Cai
2020-10-30 16:49 ` Jens Axboe [this message]
2020-10-30 18:42 ` Al Viro
2020-10-30 18:46 ` Jens Axboe
2020-10-30 18:49 ` Al Viro
2020-10-30 20:33 ` Jens Axboe
2020-10-30 22:22 ` Al Viro
2020-10-30 23:21 ` Jens Axboe
2020-11-02 18:43 ` Eric W. Biederman
2020-11-02 19:27 ` Eric W. Biederman
2020-11-02 19:54 ` Jens Axboe
2020-11-02 20:12 ` Eric W. Biederman
2020-11-02 20:31 ` Jens Axboe
2020-11-02 21:39 ` Jens Axboe
2020-11-03 14:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa085de9-766c-156a-e6ef-bd834b0cc626@kernel.dk \
--to=axboe@kernel.dk \
--cc=cai@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.