From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/3] nvme: fcloop: make fcloop_class constant
Date: Wed, 6 Mar 2024 05:24:16 +0000 [thread overview]
Message-ID: <fa1cc224-d2f5-4eec-9473-e673e8cc5b9d@nvidia.com> (raw)
In-Reply-To: <20240305-class_cleanup-nvme-v1-3-c707fc997774@marliere.net>
On 3/5/24 05:15, Ricardo B. Marliere wrote:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the fcloop_class structure to be declared at build time
> placing it into read-only memory, instead of having to be dynamically
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-03-06 6:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 13:15 [PATCH 0/3] nvme: constify struct class usage Ricardo B. Marliere
2024-03-05 13:15 ` [PATCH 1/3] nvme: core: " Ricardo B. Marliere
2024-03-06 5:23 ` Chaitanya Kulkarni
2024-03-05 13:15 ` [PATCH 2/3] nvme: fabrics: make nvmf_class constant Ricardo B. Marliere
2024-03-06 5:23 ` Chaitanya Kulkarni
2024-03-05 13:15 ` [PATCH 3/3] nvme: fcloop: make fcloop_class constant Ricardo B. Marliere
2024-03-06 5:24 ` Chaitanya Kulkarni [this message]
2024-03-05 13:51 ` [PATCH 0/3] nvme: constify struct class usage Christoph Hellwig
2024-03-05 16:02 ` Keith Busch
2024-03-05 16:25 ` Ricardo B. Marliere
2024-03-07 8:01 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1cc224-d2f5-4eec-9473-e673e8cc5b9d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ricardo@marliere.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.