All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mateusz Majewski <m.majewski2@samsung.com>,
	Thomas Turner <tturner@lineageos.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] thermal: samsung: acpm-tmu: Add Exynos850 support
Date: Thu, 19 Nov 2026 13:41:04 +0200	[thread overview]
Message-ID: <fa1f0750-ac4e-4bf9-b549-2bb9a17cbb0a@linaro.org> (raw)
In-Reply-To: <20261118-acpm-tmu-e850-support-v2-0-19848c0d97e5@linaro.org>

Hi, Alexey!

Thanks for the series!

On 11/18/26 3:51 PM, Alexey Klimov wrote:
> This series adds support for the Thermal Management Unit found on
> the Samsung Exynos850 SoC to the existing acpm-tmu driver.

Exynos850 almost doubles acpm-tmu.c, and most of the new code is
register-level handling that has nothing in common with GS101.
I'd like to split the driver now, while we add the second SoC,
rather than later. The layout could be:

  drivers/thermal/samsung/
    acpm-tmu.h            internal header: acpm_tmu_priv, acpm_tmu_sensor,
                          SoC driver data / callbacks
    acpm-tmu.c            probe, PM, thermal zone ops, threaded IRQ, OF match
                          table, locking and sensor disable/enable around
                          threshold updates
    acpm-tmu-gs101.c      ACPM IPC callbacks, sensor groups, regmap config
    acpm-tmu-exynos850.c  MMIO init and trimming, threshold and interrupt
                          registers

  obj-$(CONFIG_EXYNOS_ACPM_THERMAL)  += exynos-acpm-tmu.o
  exynos-acpm-tmu-y                  += acpm-tmu.o acpm-tmu-gs101.o \
                                        acpm-tmu-exynos850.o

See drivers/thermal/qcom/tsens* for a similar layout.

Also, please note Christian's fix for GS101 threshold 7 [1], you'll likely
need to rebase your set on his v2 as it's a fix and shall come first.

[1] https://lore.kernel.org/all/20261117083442.830549-1-christian.loehle@arm.com/

Cheers,
ta

      parent reply	other threads:[~2026-11-19 11:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:51 [PATCH v2 0/3] thermal: samsung: acpm-tmu: Add Exynos850 support Alexey Klimov
2026-11-18 13:51 ` [PATCH v2 1/3] dt-bindings: thermal: gs101-tmu: add Exynos850 compatible Alexey Klimov
2026-11-18 14:45   ` Tudor Ambarus
2026-11-18 13:51 ` [PATCH v2 2/3] thermal: samsung: acpm-tmu: refactor SoC-specific operations into driver data Alexey Klimov
2026-11-19 12:17   ` Tudor Ambarus
2026-11-18 13:51 ` [PATCH v2 3/3] thermal: samsung: acpm-tmu: add Exynos850 support Alexey Klimov
2026-11-18 14:16   ` sashiko-bot
2026-11-19 12:21   ` Tudor Ambarus
2026-11-19 11:41 ` Tudor Ambarus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa1f0750-ac4e-4bf9-b549-2bb9a17cbb0a@linaro.org \
    --to=tudor.ambarus@linaro.org \
    --cc=alexey.klimov@linaro.org \
    --cc=bzolnier@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=m.majewski2@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=tturner@lineageos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.