All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: add note about make system deprecation
Date: Thu, 9 Apr 2020 12:09:57 +0100	[thread overview]
Message-ID: <fa31c8a8-2aaa-b098-38bf-467dc24f8a0a@intel.com> (raw)
In-Reply-To: <20200409105746.26955-1-bruce.richardson@intel.com>

On 4/9/2020 11:57 AM, Bruce Richardson wrote:
> When anyone uses the make build system, they are to be informed
> about upcoming plans to deprecate and subsequently remove that
> system and to use meson and ninja instead.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  mk/rte.sdkbuild.mk  | 4 ++++
>  mk/rte.sdkconfig.mk | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> index b512de1ec..67d07a7ed 100644
> --- a/mk/rte.sdkbuild.mk
> +++ b/mk/rte.sdkbuild.mk
> @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
>  .PHONY: build
>  build: $(ROOTDIRS-y)
>  	@echo "Build complete [$(RTE_TARGET)]"
> +	@echo "==== NOTE ===="
> +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> +	@echo "=============="
>  
>  .PHONY: clean
>  clean: $(CLEANDIRS)
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index f538649f2..9a7ffbe9a 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -62,6 +62,10 @@ else
>  config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
>  	@echo "Configuration done using" \
>  		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
> +	@echo "==== NOTE ===="
> +	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> +	@echo "Building DPDK with 'make' will be deprecated in a future release"
> +	@echo "=============="

What do you think providing a link to meson documentation too?

>  endif
>  
>  $(RTE_OUTPUT):
> 


  reply	other threads:[~2020-04-09 11:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 10:57 [dpdk-dev] [PATCH] build: add note about make system deprecation Bruce Richardson
2020-04-09 11:09 ` Ferruh Yigit [this message]
2020-04-09 11:16   ` Bruce Richardson
2020-04-27 14:25 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-04-27 15:04   ` Ferruh Yigit
2020-05-19 16:05     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa31c8a8-2aaa-b098-38bf-467dc24f8a0a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.