From: Stefan Agner <stefan@agner.ch>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, benjamin.lindqvist@endian.se,
pgaikwad@nvidia.com, dev@lynxeye.de, mirza.krak@gmail.com,
richard@nod.at, pdeschrijver@nvidia.com,
linux-kernel@vger.kernel.org, krzk@kernel.org,
jonathanh@nvidia.com, devicetree@vger.kernel.org,
linux-mtd@lists.infradead.org, marcel@ziswiler.com,
miquel.raynal@bootlin.com, linux-tegra@vger.kernel.org,
digetx@gmail.com, gaireg@gaireg.de
Subject: Re: [PATCH v7 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver
Date: Sun, 24 Jun 2018 23:16:30 +0200 [thread overview]
Message-ID: <fa42ef544b3ad7f5be4ebdd115d99a59@agner.ch> (raw)
In-Reply-To: <20180624215014.3249b382@bbrezillon>
On 24.06.2018 21:50, Boris Brezillon wrote:
> On Sun, 24 Jun 2018 21:22:28 +0200
> Stefan Agner <stefan@agner.ch> wrote:
>
>> +
>> +static int tegra_nand_remove(struct platform_device *pdev)
>> +{
>> + struct tegra_nand_controller *ctrl = platform_get_drvdata(pdev);
>> +
>> + nand_release(nand_to_mtd(ctrl->chip));
>
> I still see nand_release() being used here. As I said in my review of
> v6, it's not safe. Please use mtd_device_unregister() + nand_cleanup()
> instead, and check the return code of mtd_device_unregister().
Whoops missed that one. Will send v8.
--
Stefan
>
> With this addressed
>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
>> +
>> + clk_disable_unprepare(ctrl->clk);
>> +
>> + return 0;
>> +}
>> +
next prev parent reply other threads:[~2018-06-24 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 19:22 [PATCH v7 0/6] mtd: rawnand: add NVIDIA Tegra NAND flash support Stefan Agner
2018-06-24 19:22 ` [PATCH v7 1/6] mtd: rawnand: add Reed-Solomon error correction algorithm Stefan Agner
2018-06-24 19:22 ` Stefan Agner
2018-06-24 19:22 ` [PATCH v7 2/6] mtd: rawnand: add an option to specify NAND chip as a boot device Stefan Agner
2018-06-24 19:22 ` [PATCH v7 3/6] mtd: rawnand: tegra: add devicetree binding Stefan Agner
2018-06-24 19:22 ` [PATCH v7 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver Stefan Agner
2018-06-24 19:50 ` Boris Brezillon
2018-06-24 21:16 ` Stefan Agner [this message]
2018-06-24 19:22 ` [PATCH v7 5/6] ARM: dts: tegra: add Tegra20 NAND flash controller node Stefan Agner
2018-06-24 19:22 ` [PATCH v7 6/6] ARM: dts: tegra: enable NAND flash on Colibri T20 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa42ef544b3ad7f5be4ebdd115d99a59@agner.ch \
--to=stefan@agner.ch \
--cc=benjamin.lindqvist@endian.se \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gaireg@gaireg.de \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=mirza.krak@gmail.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.