From: Derrick Stolee <derrickstolee@github.com>
To: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Cc: peff@peff.net, vdye@github.com, gitster@pobox.com
Subject: Re: [PATCH 0/4] midx: trace2 regions and grab-bag patches
Date: Thu, 13 Oct 2022 09:10:16 -0400 [thread overview]
Message-ID: <fa47a48b-6da7-a456-05d6-cd5c17b159c3@github.com> (raw)
In-Reply-To: <cover.1665612094.git.me@ttaylorr.com>
On 10/12/2022 6:01 PM, Taylor Blau wrote:
> Here is a small handful of MIDX and MIDX bitmap-related patches that
> I've been carrying in GitHub's fork for a while now and forgot to send
> upstream.
>
> The first is a small typofix, and the second is a legitimate bug fix
> which allows us to consider annotated tags as bitmap candidates during
> commit selection. The final two are trace2 regions and instrumentation
> that I've found helpful when rolling out MIDX bitmaps in a production
> setting.
>
> Sorry that these are so disjointed in nature ;-). I figured that it was
> better to send a grab-bag series like this than to hold onto these
> patches forever!
As advertised, this set of patches are all nice and small. I've found
the additional tracing useful during performance investigations and
unobtrusive otherwise.
Though they looked familiar, I gave them a careful read and have no
comments. LGTM.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-10-13 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 22:01 [PATCH 0/4] midx: trace2 regions and grab-bag patches Taylor Blau
2022-10-12 22:01 ` [PATCH 1/4] midx.c: fix whitespace typo Taylor Blau
2022-10-12 22:01 ` [PATCH 2/4] midx.c: consider annotated tags during bitmap selection Taylor Blau
2022-10-12 22:01 ` [PATCH 3/4] midx.c: instrument MIDX and bitmap generation with trace2 regions Taylor Blau
2022-10-12 22:01 ` [PATCH 4/4] pack-bitmap-write.c: instrument number of reused bitmaps Taylor Blau
2022-10-13 13:10 ` Derrick Stolee [this message]
2022-10-13 20:35 ` [PATCH 0/4] midx: trace2 regions and grab-bag patches Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa47a48b-6da7-a456-05d6-cd5c17b159c3@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.