From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3557410EB3A for ; Mon, 28 Mar 2022 05:52:00 +0000 (UTC) From: "Gupta, Anshuman" To: "Tauro, Riana" , "igt-dev@lists.freedesktop.org" Date: Mon, 28 Mar 2022 05:51:55 +0000 Message-ID: References: <20220328051727.119142-1-riana.tauro@intel.com> <20220328051727.119142-3-riana.tauro@intel.com> In-Reply-To: <20220328051727.119142-3-riana.tauro@intel.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/3] tests/i915/i915_suspend: Add system-suspend-without-i915 subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: > -----Original Message----- > From: Tauro, Riana > Sent: Monday, March 28, 2022 10:47 AM > To: igt-dev@lists.freedesktop.org > Cc: Tauro, Riana ; Gupta, Anshuman > ; Ewins, Jon ; Dixit, > Ashutosh > Subject: [PATCH i-g-t 2/3] tests/i915/i915_suspend: Add system-suspend- > without-i915 subtest >=20 > From: "Tauro, Riana" >=20 > Add a new test system-suspend-without-i915 to exercise suspend/resume cyc= le > without i915 module to know the system wide health of suspend/resume > feature. > This test will be part of CI fast-feedback test list. >=20 > Signed-off-by: Tauro, Riana > --- > tests/i915/i915_suspend.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c index > da27ce09..4660d7a7 100644 > --- a/tests/i915/i915_suspend.c > +++ b/tests/i915/i915_suspend.c > @@ -41,6 +41,7 @@ > #include "i915/gem.h" > #include "i915/gem_create.h" > #include "igt.h" > +#include "igt_kmod.h" > #include "igt_device.h" >=20 > #define OBJECT_SIZE (16*1024*1024) > @@ -202,6 +203,22 @@ test_forcewake(int fd, bool hibernate) > close (fw_fd); > } >=20 > +static int > +test_suspend_without_i915(int fd) > +{ > + close(fd); > + fd =3D -1; > + drm_cancel_work_at_exit(); > + igt_i915_driver_unload(); > + > + igt_system_suspend_autoresume(SUSPEND_STATE_MEM, > SUSPEND_TEST_NONE); > + > + igt_kmsg(KMSG_INFO "Re-loading i915 \n"); > + igt_assert_eq(igt_i915_driver_load(NULL), 0); > + fd =3D drm_open_driver(DRIVER_INTEL); > + return fd; > +} > + > int fd; >=20 > igt_main > @@ -209,6 +226,9 @@ igt_main > igt_fixture > fd =3D drm_open_driver(DRIVER_INTEL); >=20 > + igt_subtest("system-suspend-without-i915") > + fd =3D test_suspend_without_i915(fd); > + Move above code block to above of igt_fixture(), this subtest doesn't need = igt_fixture. With that we don't need to close the fd and reopen it back and forth ? This will avoid to call drm_cancel_work_at_exit() ? > igt_subtest("fence-restore-tiled2untiled") { > gem_require_mappable_ggtt(fd); > test_fence_restore(fd, true, false); > -- > 2.25.1