From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 688BEC3DA6E for ; Wed, 10 Jan 2024 09:03:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 992DF878B2; Wed, 10 Jan 2024 10:03:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="S7JCGTti"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2D511878B2; Wed, 10 Jan 2024 10:03:04 +0100 (CET) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48699878C8 for ; Wed, 10 Jan 2024 10:03:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=danishanwar@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40A92qax069264; Wed, 10 Jan 2024 03:02:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704877372; bh=NHujuPJDyYo/elwWuCpCpAFE24LxNpkEwWLR1SYXDag=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=S7JCGTti30WheBFI+lP6c8kOZsABVqgAEHR3H21GB1wnFBbJbDTIjGNY2jQiwL5zF yfVztcvl+aDp5BXUPJoj7WHLfh/5kLN1XweqC84cK3+Rm70VsI5b0bAx46HxFToahC CK7a5vCAaGM+9CLW/vOEzNvw/9p0i3NmIgQghaXI= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40A92p8R034913 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Jan 2024 03:02:52 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 10 Jan 2024 03:02:51 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 10 Jan 2024 03:02:51 -0600 Received: from [10.24.69.25] (danish-tpc.dhcp.ti.com [10.24.69.25]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40A92k1l050732; Wed, 10 Jan 2024 03:02:47 -0600 Message-ID: Date: Wed, 10 Jan 2024 14:32:46 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 12/16] arm: dts: k3-am65x-binman: Add ICSSG2 overlay and configuration Content-Language: en-US To: Roger Quadros , Maxime Ripard , Siddharth Vadapalli , Nishanth Menon , Vignesh Raghavendra , Matthias Schiffer , Kamlesh Gurudasani , Manorit Chawdhry , Neha Malcom Francis , Andrew Davis , Ramon Fried , Joe Hershberger , Simon Glass , Tom Rini CC: , , References: <20231219103418.3445886-1-danishanwar@ti.com> <20231219103418.3445886-13-danishanwar@ti.com> <1745ec33-7446-41fc-886a-704eb6e53c7e@kernel.org> <427c0741-5daf-4370-9cf6-5c70d8d6f673@ti.com> From: MD Danish Anwar In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/01/24 2:24 pm, Roger Quadros wrote: > On 10/01/2024 08:50, MD Danish Anwar wrote: >> Hi Roger, >> >> On 27/12/23 3:49 pm, MD Danish Anwar wrote: >>> On 20/12/23 4:10 pm, Roger Quadros wrote: >>>> >>>> >>>> On 19/12/2023 12:34, MD Danish Anwar wrote: >>>>> Add ICSSG2 overlay and configuration to tispl and u-boot images. >>>>> >>>>> Signed-off-by: MD Danish Anwar >>>>> --- >>>>> arch/arm/dts/k3-am65x-binman.dtsi | 85 +++++++++++++++++++++++++++++++ >>>>> 1 file changed, 85 insertions(+) >>>>> >>>>> diff --git a/arch/arm/dts/k3-am65x-binman.dtsi b/arch/arm/dts/k3-am65x-binman.dtsi >>>>> index 8cc24da1f3..9a0c0fca47 100644 >>>>> --- a/arch/arm/dts/k3-am65x-binman.dtsi >>>>> +++ b/arch/arm/dts/k3-am65x-binman.dtsi >>>>> @@ -98,6 +98,8 @@ >>>>> #define SPL_AM654_EVM_DTB "spl/dts/k3-am654-base-board.dtb" >>>>> #define AM654_EVM_DTB "u-boot.dtb" >>>>> >>>>> +#define AM654_EVM_ICSSG2_DTBO "arch/arm/dts/k3-am654-icssg2.dtbo" >>>>> + >>>>> &binman { >>>>> ti-spl { >>>>> insert-template = <&ti_spl_template>; >>>>> @@ -124,6 +126,20 @@ >>>>> filename = SPL_AM654_EVM_DTB; >>>>> }; >>>>> }; >>>>> + >>>>> + fdt-1 { >>>>> + description = "k3-am654-icssg2 overlay"; >>>>> + type = "flat_dt"; >>>>> + arch = "arm"; >>>>> + compression = "none"; >>>>> + ti-secure { >>>>> + content = <&spl_am65x_evm_icssg2_dtb>; >>>>> + keyfile = "custMpk.pem"; >>>>> + }; >>>>> + spl_am65x_evm_icssg2_dtb: blob-ext { >>>>> + filename = AM654_EVM_ICSSG2_DTBO; >>>>> + }; >>>> >>>> This is wrong. >>>> >>>> ICSSG2 Ethernet should be part of the fdt-0 configuration as the 2 Ethernet ports >>>> on the board are hardwired to ICSSG2. Not having them working by default >>>> is an invalid configuration. >>>> >>> >>> ICSSG2 ethernet ports should be enabled by default. But the ICSSG2 nodes >>> is added in the overlay file (k3-am654-icssg2.dtso) in kernel so they >>> are added in same overlay file in u-boot as well. >>> >>> I am keeping, >>> fdt-0 as k3-am654-base-board dtb, >>> fdt-1 as k3-am654-icssg2 dtbo, >>> conf-0 as k3-am654-base-board and >>> conf-1 as k3-am654-icssg2. >>> >>> Do you want me to keep k3-am654-icssg2 dtbo as fdt-0 and >>> k3-am654-base-board as fdt-1? I tried doing this but this results into >>> u-boot getting stuck. The tispl and u-boot images are not able to load >>> if I swap fdt-0 and fdt-1 , and conf-0 and conf-1. >>> >>> If the current combination doesn't look OK, please let me know what >>> should be the correct combinations for fdt-0, fdt-1, conf-0 and conf-1. >>> >> >> Can you please comment on this. I'll send v2 with all the suggested >> changes once you confirm the correct fdt and configurations. >> > Sorry, I missed this. > > fdt-0 = k3-am654-base-board dtb > fdt-1 = k3-am654-icssg2 dtbo > > conf-0 = fdt-0 and ftd-1 > What about conf-1? Should I leave it as it is(currently conf-1 is fdt-0 and fdt-1)? > as icssg2 ethernet is present on the base board, and should be part of the base board configuration. > -- Thanks and Regards, Danish