From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BCFC04AB1 for ; Fri, 10 May 2019 02:37:18 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F9B9217F4 for ; Fri, 10 May 2019 02:37:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F9B9217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 2AC99CBC; Fri, 10 May 2019 02:37:18 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8732CB9E for ; Fri, 10 May 2019 02:37:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id EAECA709 for ; Fri, 10 May 2019 02:37:16 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 19:37:15 -0700 X-ExtLoop1: 1 Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga008.fm.intel.com with ESMTP; 09 May 2019 19:37:14 -0700 Subject: Re: [PATCH 0/3] Add debugfs support to show scalable mode DMAR table To: Sai Praneeth Prakhya , iommu@lists.linux-foundation.org References: From: Lu Baolu Message-ID: Date: Fri, 10 May 2019 10:30:45 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: Ashok Raj , Andy Shevchenko , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Hi Sai, On 5/10/19 2:41 AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Presently, "/sys/kernel/debug/iommu/intel/dmar_translation_struct" file dumps > only legacy DMAR table which consists of root table and context table. Scalable > mode DMAR table adds PASID directory and PASID table. Hence, add support to dump > these tables as well. > > Directly extending the present dumping format for PASID tables will make the > output look clumsy. Hence, the first patch modifies the present format to a > tabular format. The second patch introduces macros that are used during PASID > table walk and the third patch actually adds support to dump scalable mode DMAR > table. > > Sai Praneeth (3): > iommu/vt-d: Modify the format of intel DMAR tables dump > iommu/vt-d: Introduce macros useful for dumping DMAR table > iommu/vt-d: Add debugfs support to show scalable mode DMAR table > internals This patch set looks good to me in general. One minor suggestion is that the author name and signed-of-by name should be consistent for all patches. Best regards, Lu Baolu > > drivers/iommu/intel-iommu-debugfs.c | 132 +++++++++++++++++++++++++++++------- > drivers/iommu/intel-pasid.c | 17 ----- > drivers/iommu/intel-pasid.h | 26 +++++++ > 3 files changed, 134 insertions(+), 41 deletions(-) > > Cc: Joerg Roedel > Cc: Ashok Raj > Cc: Lu Baolu > Cc: Sohil Mehta > Cc: David Woodhouse > Cc: Jacob Pan > Cc: Andy Shevchenko > Signed-off-by: Sai Praneeth Prakhya > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu