From: Grant Likely <grant.likely@secretlab.ca>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: microblaze-uclinux@itee.uq.edu.au,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/4 v2] Merge OF dynamic patches
Date: Fri, 20 Nov 2009 14:40:22 -0700 [thread overview]
Message-ID: <fa686aa40911201340i77bc4098ud866d103acaefd30@mail.gmail.com> (raw)
In-Reply-To: <4B06AF33.1000400@austin.ibm.com>
On Fri, Nov 20, 2009 at 8:01 AM, Nathan Fontenot <nfont@austin.ibm.com> wro=
te:
> This set of patches merges the common dynamic device tree
> updating routines of_attach_node() and of_detach_node() to
> drivers/of/of_dynamic.c.
>
> Built and tested on powerpc, I have no access to build/test
> this on microblaze.
Heh. Actually, I've got a patch in my tree that does the same thing
(except to a different location). I could pick up your version and
drop mine, but you need to rework it to be bi-sectable. As the series
exists right now, the build will fail if only part of the series is
applied. This change is simple enough that you can do the whole thing
in a single patch. Or, fix the Kconfig and include stuff in the first
patch with the merge of of_attach_node, and then move of_detach_node
in the second.
But I'm really close to posting my 3rd series, so it may be better to
wait until that is published and build a patch on top of that to move
them into of_dynamic.c
Cheers,
g.
> ---
>
> 1/4 - Merge of_attach_node
> 2/4 - Merge of_detach_node
> 3/4 - Makefile/Kconfig updates
> 4/4 - Update powerpc/pseries to include of_dynamic.h
>
> arch/microblaze/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01
> arch/microblaze/include/asm/prom.h =A0 =A0 =A0 =A0| =A0 =A04 -
> arch/microblaze/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 59 ----------=
-------------
> arch/powerpc/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A0=
1
> arch/powerpc/include/asm/prom.h =A0 =A0 =A0 =A0 =A0 | =A0 =A04 -
> arch/powerpc/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 59 ------=
-----------------
> arch/powerpc/platforms/pseries/reconfig.c | =A0 =A01 drivers/of/Kconfig
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 +
> drivers/of/Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A0=
1 drivers/of/of_dynamic.c
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 75 ++++++++++++++++++++++++++++++
> include/linux/of_dynamic.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 27 ++++++=
++++
> 11 files changed, 110 insertions(+), 126 deletions(-)
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Nathan Fontenot <nfont-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
Cc: microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 0/4 v2] Merge OF dynamic patches
Date: Fri, 20 Nov 2009 14:40:22 -0700 [thread overview]
Message-ID: <fa686aa40911201340i77bc4098ud866d103acaefd30@mail.gmail.com> (raw)
In-Reply-To: <4B06AF33.1000400-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
On Fri, Nov 20, 2009 at 8:01 AM, Nathan Fontenot <nfont-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org> wrote:
> This set of patches merges the common dynamic device tree
> updating routines of_attach_node() and of_detach_node() to
> drivers/of/of_dynamic.c.
>
> Built and tested on powerpc, I have no access to build/test
> this on microblaze.
Heh. Actually, I've got a patch in my tree that does the same thing
(except to a different location). I could pick up your version and
drop mine, but you need to rework it to be bi-sectable. As the series
exists right now, the build will fail if only part of the series is
applied. This change is simple enough that you can do the whole thing
in a single patch. Or, fix the Kconfig and include stuff in the first
patch with the merge of of_attach_node, and then move of_detach_node
in the second.
But I'm really close to posting my 3rd series, so it may be better to
wait until that is published and build a patch on top of that to move
them into of_dynamic.c
Cheers,
g.
> ---
>
> 1/4 - Merge of_attach_node
> 2/4 - Merge of_detach_node
> 3/4 - Makefile/Kconfig updates
> 4/4 - Update powerpc/pseries to include of_dynamic.h
>
> arch/microblaze/Kconfig | 1
> arch/microblaze/include/asm/prom.h | 4 -
> arch/microblaze/kernel/prom.c | 59 -----------------------
> arch/powerpc/Kconfig | 1
> arch/powerpc/include/asm/prom.h | 4 -
> arch/powerpc/kernel/prom.c | 59 -----------------------
> arch/powerpc/platforms/pseries/reconfig.c | 1 drivers/of/Kconfig
> | 4 +
> drivers/of/Makefile | 1 drivers/of/of_dynamic.c
> | 75 ++++++++++++++++++++++++++++++
> include/linux/of_dynamic.h | 27 ++++++++++
> 11 files changed, 110 insertions(+), 126 deletions(-)
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-11-20 21:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 15:01 [PATCH 0/4 v2] Merge OF dynamic patches Nathan Fontenot
2009-11-20 15:01 ` Nathan Fontenot
2009-11-20 15:05 ` [PATCH 1/4 v2] Merge of_attach_node Nathan Fontenot
2009-11-20 15:05 ` Nathan Fontenot
2009-11-20 15:06 ` [PATCH 2/4 v2] Merge of_detach_node Nathan Fontenot
2009-11-20 15:06 ` Nathan Fontenot
2009-11-20 15:08 ` [PATCH 3/4 v2] Makefile and Kconfig updates Nathan Fontenot
2009-11-20 15:08 ` Nathan Fontenot
2009-11-20 15:09 ` [PATCH 4/4 v2] Include of_dynamic.h in pseries/reconfig.c Nathan Fontenot
2009-11-20 15:09 ` Nathan Fontenot
2009-11-20 21:40 ` Grant Likely [this message]
2009-11-20 21:40 ` [PATCH 0/4 v2] Merge OF dynamic patches Grant Likely
[not found] ` <fa686aa40911201340i77bc4098ud866d103acaefd30-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-20 22:17 ` Andres Salomon
2009-11-23 13:27 ` [microblaze-uclinux] " Michal Simek
2009-11-23 13:27 ` Michal Simek
2009-11-23 15:38 ` Nathan Fontenot
2009-11-23 15:38 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40911201340i77bc4098ud866d103acaefd30@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=nfont@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.