From: Grant Likely <grant.likely@secretlab.ca>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jeremy Kerr <jeremy.kerr@canonical.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h
Date: Mon, 11 Jan 2010 15:58:47 -0700 [thread overview]
Message-ID: <fa686aa41001111458g5975e055ga4c7cd830fff1906@mail.gmail.com> (raw)
In-Reply-To: <20100109110104.GA20100@x200>
On Sat, Jan 9, 2010 at 4:01 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Thu, Jan 07, 2010 at 01:19:13PM +1100, Jeremy Kerr wrote:
>> Commit e22f628395432b967f2f505858c64450f7835365 introduced a build
>> breakage for ARM devtree work: the THIS_MODULE macro was added, but we
>> don't have module.h
>>
>> This change adds the necessary #include to get THIS_MODULE defined.
>> While we could just replace it with NULL (PROC_FS is a bool, not a
>> tristate), using THIS_MODULE will prevent unexpected breakage if we
>> ever do compile this as a module.
>
> I'd say, remove .owner line.
> It definitely not needed in non-modular code.
No. Jeremy's fix is the better one. Having the .owner line doesn't
cost anything and it is better to have it populated; even if only as
an example.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-01-11 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 2:19 [PATCH] proc_devtree: fix THIS_MODULE without module.h Jeremy Kerr
2010-01-09 11:01 ` Alexey Dobriyan
2010-01-11 22:58 ` Grant Likely [this message]
2010-01-12 17:41 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41001111458g5975e055ga4c7cd830fff1906@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=adobriyan@gmail.com \
--cc=jeremy.kerr@canonical.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.