Re: [PATCH 7/7] ASoC: dt-bindings: ES8389: Add members about HPF and clock

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/06/2026 11:58, Zhang Yi wrote:
>> Please organize the patch documenting the ABI (DT bindings)
>> before the patch using that ABI.
>> See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
> 
> Thanks for the reminder
> 
>>> +  everest,mclk-from-sclk:
>>> +    $ref: /schemas/types.yaml#/definitions/flag
>>> +    description:
>>> +      Indicates that SCLK is used as the internal clock.
>>
>> And what happens with mclk in such case? Is it still wired?
> 
> Yes, setting mclk-from-sclk does not affect the MCLK connection.

I am asking about wiring of the device. If MCLK is used from SCLK, but
SCLK is used as the internal clock, then how can you still have MCLK
connected?

> 
>>> +
>>> +  everest,hpfl:
>>> +    $ref: /schemas/types.yaml#/definitions/uint8
>>> +    description:
>>> +      the HPF value of ADCL.
>>
>> Is HPF value in dB? If so, use proper unit suffix and proper units.
> 
> No, the values here correspond to the values in the registers.
> The value is not in dB

What are the meanings of the register values?

> 
>>>          vddd-supply = <&vdd3v3>;
>>>          vdda-supply = <&vdd3v3>;
>>> +        everest,hpfl = [0a];
>>
>> <0xa>? What did you want to say here?
> 
> I just wanted to give an example to show how to set the values of everest,hpfl to 0x0a.

So use syntax I asked.

Best regards,
Krzysztof