From: Nicolai Buchwitz <nb@tipi-net.de>
To: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] selftests: drv-net: Check the features set by set_ethtool_feat()
Date: Fri, 18 Sep 2026 13:51:22 +0200 [thread overview]
Message-ID: <fa78063df06ec598208eff3d9708c38d@tipi-net.de> (raw)
In-Reply-To: <20260918112529.96039-3-ovidiu.panait.rb@renesas.com>
Hi Ovidiu
On 18.9.2026 13:25, Ovidiu Panait wrote:
> Read back the features after running ethtool -K to check if they were
> actually applied. The drivers might refuse to set a feature silently
> and
> the test could run with a different configuration than the requested
> one.
>
> Add a 'check' parameter to skip this, as the GRO "hw" mode handles the
> case where HW GRO is cleared by the driver.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
> ---
> [...]
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
Thanks,
Nicolai
next prev parent reply other threads:[~2026-09-18 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 11:25 [PATCH net-next v2 0/3] selftests: drv-net: Add VLAN test Ovidiu Panait
2026-09-18 11:25 ` [PATCH net-next v2 1/3] selftests: drv-net: Move _set_ethtool_feat() into lib Ovidiu Panait
2026-09-18 11:25 ` [PATCH net-next v2 2/3] selftests: drv-net: Check the features set by set_ethtool_feat() Ovidiu Panait
2026-09-18 11:51 ` Nicolai Buchwitz [this message]
2026-09-22 12:01 ` netdev-bot+sashiko
2026-09-18 11:25 ` [PATCH net-next v2 3/3] selftests: drv-net: Add VLAN test Ovidiu Panait
2026-09-18 12:04 ` Nicolai Buchwitz
2026-09-18 22:12 ` Jakub Kicinski
2026-09-19 21:43 ` Nicolai Buchwitz
2026-09-22 12:01 ` netdev-bot+sashiko
2026-09-24 15:30 ` [PATCH net-next v2 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa78063df06ec598208eff3d9708c38d@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.