From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>, Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring Mailing List <io-uring@vger.kernel.org>
Subject: Re: [PATCH for-next 3/3] test range file alloc
Date: Thu, 30 Jun 2022 20:32:01 +0700 [thread overview]
Message-ID: <fa7ef9b7-1643-e7db-53fb-90bec6df14f1@gnuweeb.org> (raw)
In-Reply-To: <30f95627-eb6c-c743-8fb2-11b0b874e00b@kernel.dk>
On 6/30/22 8:09 PM, Jens Axboe wrote:
> On 6/30/22 3:13 AM, Pavel Begunkov wrote:
>> @@ -949,5 +1114,11 @@ int main(int argc, char *argv[])
>> return ret;
>> }
>>
>> + ret = test_file_alloc_ranges();
>> + if (ret) {
>> + printf("test_partial_register_fail failed\n");
>> + return ret;
>> + }
>
> If you're returning this directly, test_file_alloc_ranges() should use
> the proper T_EXIT_foo return codes.
Also use `fprintf(stderr, ...)` instead of `printf(...)` for that one.
--
Ammar Faizi
next prev parent reply other threads:[~2022-06-30 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 9:13 [PATCH for-next 0/3] ranged file slot alloc Pavel Begunkov
2022-06-30 9:13 ` [PATCH for-next 1/3] update io_uring.h with file slot alloc ranges Pavel Begunkov
2022-06-30 9:13 ` [PATCH for-next 2/3] alloc range helpers Pavel Begunkov
2022-06-30 13:08 ` Jens Axboe
2022-06-30 9:13 ` [PATCH for-next 3/3] test range file alloc Pavel Begunkov
2022-06-30 13:09 ` Jens Axboe
2022-06-30 13:32 ` Ammar Faizi [this message]
2022-06-30 14:19 ` Pavel Begunkov
2022-06-30 14:31 ` Ammar Faizi
2022-06-30 15:18 ` Pavel Begunkov
2022-06-30 19:26 ` Eli Schwartz
2022-06-30 20:03 ` Jens Axboe
2022-06-30 14:57 ` Jens Axboe
2022-06-30 9:18 ` [PATCH for-next 0/3] ranged file slot alloc Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa7ef9b7-1643-e7db-53fb-90bec6df14f1@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.