From: Vincent Mailhol <mailhol@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Biju Das <biju.das.jz@bp.renesas.com>
Cc: linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/6] can: rcar_canfd: Invert global vs. channel teardown
Date: Tue, 9 Sep 2025 15:38:32 +0900 [thread overview]
Message-ID: <fa9a5a87-d91c-4d24-af76-432c0db59df8@kernel.org> (raw)
In-Reply-To: <00ff7a4ad18bb26a74c77134182b4efd380ecc84.1755855779.git.geert+renesas@glider.be>
On 22/08/2025 at 18:50, Geert Uytterhoeven wrote:
> Global state is initialized and torn down before per-channel state.
> Invert the order to restore symmetry.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Same comment as before. I assume this is only cosmetic, if not, Fixes: tag please!
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2025-09-09 6:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 9:50 [PATCH 0/6] can: rcar_canfd: Add suspend/resume support Geert Uytterhoeven
2025-08-22 9:50 ` [PATCH 1/6] can: rcar_canfd: Invert reset assert order Geert Uytterhoeven
2025-08-22 14:24 ` Biju Das
2025-09-09 6:36 ` Vincent Mailhol
2025-09-09 6:57 ` Geert Uytterhoeven
2025-08-22 9:50 ` [PATCH 2/6] can: rcar_canfd: Invert global vs. channel teardown Geert Uytterhoeven
2025-08-22 14:21 ` Biju Das
2025-09-09 6:38 ` Vincent Mailhol [this message]
2025-09-09 6:58 ` Geert Uytterhoeven
2025-08-22 9:50 ` [PATCH 3/6] can: rcar_canfd: Extract rcar_canfd_global_{,de}init() Geert Uytterhoeven
2025-08-22 9:50 ` [PATCH 4/6] can: rcar_canfd: Invert CAN clock and close_candev() order Geert Uytterhoeven
2025-08-22 14:26 ` Biju Das
2025-08-22 9:50 ` [PATCH 5/6] can: rcar_canfd: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Geert Uytterhoeven
2025-08-22 14:27 ` Biju Das
2025-08-22 9:50 ` [PATCH/RFC 6/6] can: rcar_canfd: Add suspend/resume support Geert Uytterhoeven
2025-08-22 13:39 ` Biju Das
2025-08-22 16:19 ` Biju Das
2025-09-08 13:50 ` Geert Uytterhoeven
2025-09-08 13:56 ` Biju Das
2025-09-08 14:06 ` Geert Uytterhoeven
2025-09-12 7:54 ` Biju Das
2025-09-12 8:27 ` Geert Uytterhoeven
2025-09-12 8:56 ` Biju Das
2025-09-12 8:43 ` Geert Uytterhoeven
2025-09-12 8:49 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9a5a87-d91c-4d24-af76-432c0db59df8@kernel.org \
--to=mailhol@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.