From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "D. Starke" <daniel.starke@siemens.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] tty: n_gsm: introduce macro for minimal unit size
Date: Tue, 25 Oct 2022 13:17:29 +0300 (EEST) [thread overview]
Message-ID: <fa9b8796-b0cd-d6e4-12d3-e0acd570d633@linux.intel.com> (raw)
In-Reply-To: <20221024130114.2070-1-daniel.starke@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
On Mon, 24 Oct 2022, D. Starke wrote:
> From: Daniel Starke <daniel.starke@siemens.com>
>
> n_gsm has a minimal protocol overhead of 7 bytes. The current code already
> checks whether the configured MRU/MTU size is at least one byte more than
> this.
>
> Introduce the macro MIN_MTU to make this value more obvious.
>
> Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2022-10-25 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 13:01 [PATCH v2 1/3] tty: n_gsm: introduce macro for minimal unit size D. Starke
2022-10-24 13:01 ` [PATCH v2 2/3] tty: n_gsm: add parameters used with parameter negotiation D. Starke
2022-10-25 10:24 ` Ilpo Järvinen
2022-10-24 13:01 ` [PATCH v2 3/3] tty: n_gsm: add parameter negotiation support D. Starke
2022-10-25 11:09 ` Ilpo Järvinen
2022-10-25 11:16 ` Starke, Daniel
2022-10-25 11:50 ` Ilpo Järvinen
2022-10-25 12:25 ` Starke, Daniel
2022-10-25 12:04 ` Greg KH
2022-10-31 13:26 ` Starke, Daniel
2022-11-01 6:16 ` Greg KH
2022-10-25 10:17 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9b8796-b0cd-d6e4-12d3-e0acd570d633@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.