Re: [PATCH v2 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance

[Dragos Tatulea <dtatulea@nvidia.com>]

On 04.09.24 05:38, Jason Wang wrote:
> On Wed, Sep 4, 2024 at 1:15 AM Carlos Bilbao
> <carlos.bilbao.osdev@gmail.com> wrote:
>>
>> From: Carlos Bilbao <cbilbao@digitalocean.com>
>>
>> Remove invalid ioctl VHOST_VDPA_SET_CONFIG and all its implementations
>> with vdpa_config_ops->set_config(). This is needed per virtio spec
>> requirements; virtio-spec v3.1 Sec 5.1.4 states that "All of the device
>> configuration fields are read-only for the driver."
>>
>> Signed-off-by: Carlos Bilbao <cbilbao@digitalocean.com>
> 
> Note that only the config space of the modern device is read only. So
> it should be fine to remove vp_vdpa which only works for modern
> devices.
Just out of curiosity: how will this work for devices that are not
v1.3 compliant but are v1.2 compliant? Or is this true of all devices
except eni?

Thanks,
Dragos
> 
> And for eni, it is a legacy only device, so we should not move the
> set_config there.
> 
> For the rest, we need the acks for those maintainers.
> 
> Thanks
>