From: Matthieu Baerts <matttbe@kernel.org>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: do not detect PPPoX loopback
Date: Mon, 15 Jun 2026 11:15:40 +0200 [thread overview]
Message-ID: <fac2b43c-4121-41b3-a7fe-d52ddb63f413@kernel.org> (raw)
In-Reply-To: <20260603061746.23452-1-qingfang.deng@linux.dev>
Hi Qingfang,
On 03/06/2026 08:17, Qingfang Deng wrote:
> By default, pppd attempts to detect loopbacks on the underlying
> interface using a pseudo-randomly generated magic number and checks if
> the same value is received. The seed for the PRNG is a hash of hostname
> XOR current time XOR pid, which is likely to collide on NIPA, causing
> false positives. Disable magic number generation.
Thank you for the fix!
It looks like the test is no longer flaky [1], so I just unignored it on
NIPA.
[1] https://netdev.bots.linux.dev/contest.html?skip=0&test=pppol2tp-sh
Cheers,
Matt
prev parent reply other threads:[~2026-06-15 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 6:17 [PATCH net-next] selftests: net: do not detect PPPoX loopback Qingfang Deng
2026-06-06 0:40 ` patchwork-bot+netdevbpf
2026-06-15 9:15 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac2b43c-4121-41b3-a7fe-d52ddb63f413@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.