From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBAF8C25B10 for ; Mon, 13 May 2024 06:43:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D65F10E226; Mon, 13 May 2024 06:43:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="B+7jWjRB"; dkim-atps=neutral Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7811A10E226 for ; Mon, 13 May 2024 06:43:17 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715582592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9wX8NMO96pXgObmwZJgkX492lcaLyuWMCeWzF3eqfpI=; b=B+7jWjRB1V3KA/PHj0c1iZZGcssVmdjbTmTzUuAyDwRW4hCQxRQTAxyy1sEKKQypjg4iL0 ear4ggZR7foRmFNSok6/FxvgKKgkGnrYMNSo6h3jBzymrExxEVt7qbiBqvofMqnZ7Dltok nqvqIOT+HkAEOGtGOgv1dVdShOy4Bbg= Date: Mon, 13 May 2024 14:43:01 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] drm/bridge: imx: Remove redundant checks on existence of bridge->encoder To: Liu Ying , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , Maxime Ripard , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240511150816.326846-1-sui.jingfeng@linux.dev> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 5/13/24 13:56, Liu Ying wrote: > On 5/11/24 23:08, Sui Jingfeng wrote: >> The check on the existence of bridge->encoder on the implementation layer >> of drm bridge driver is not necessary, as it has already been done in the >> drm_bridge_attach() function. It is guaranteed that the .encoder member >> of the drm_bridge instance is not NULL when various imx_xxx_bridge_attach() >> function gets called. > > Nit: > ldb_bridge_attach_helper() doesn't follow the fashion of > imx_xxx_bridge_attach(), not even the other bridge attach > functions touched by this patch do. Right, my bad. But personally, I think rename it as ldb_bridge_attach() should enough to express the meaning. :-) Maybe, reword as > "when various i.MX specific bridge attach functions are > called." > OK, fine. I will correct the commit message at the next version, so happy being reviewed. Thanks. > Regards, > Liu Ying >