From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH libdrm 4/7] tests/amdgpu: fix bad sign comparisons Date: Fri, 26 Jan 2018 12:38:35 +0100 Message-ID: References: <20180126113244.26946-1-eric.engestrom@imgtec.com> <20180126113244.26946-4-eric.engestrom@imgtec.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FF786E596 for ; Fri, 26 Jan 2018 11:38:37 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id t16so240744wrc.10 for ; Fri, 26 Jan 2018 03:38:37 -0800 (PST) In-Reply-To: <20180126113244.26946-4-eric.engestrom@imgtec.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Engestrom , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMjYuMDEuMjAxOCB1bSAxMjozMiBzY2hyaWViIEVyaWMgRW5nZXN0cm9tOgo+IFNpZ25lZC1v ZmYtYnk6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMuY29tPgo+IC0tLQo+ ICAgdGVzdHMvYW1kZ3B1L2NzX3Rlc3RzLmMgICAgICB8ICAyICstCj4gICB0ZXN0cy9hbWRncHUv dXZkX2VuY190ZXN0cy5jIHwgMTAgKysrKystLS0tLQo+ICAgdGVzdHMvYW1kZ3B1L3ZjZV90ZXN0 cy5jICAgICB8IDEwICsrKysrLS0tLS0KPiAgIHRlc3RzL2FtZGdwdS92Y25fdGVzdHMuYyAgICAg fCAgNCArKy0tCj4gICA0IGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2FtZGdwdS9jc190ZXN0cy5jIGIvdGVzdHMv YW1kZ3B1L2NzX3Rlc3RzLmMKPiBpbmRleCBhNTM2MWNkNTk0NTdkMDM5ZGVhOS4uNDA3MDBmNTNk MzVmMzM0MGI4OTUgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvYW1kZ3B1L2NzX3Rlc3RzLmMKPiArKysg Yi90ZXN0cy9hbWRncHUvY3NfdGVzdHMuYwo+IEBAIC0zOTYsNyArMzk2LDcgQEAgc3RhdGljIHZv aWQgYW1kZ3B1X2NzX3V2ZF9kZWNvZGUodm9pZCkKPiAgIAlDVV9BU1NFUlRfRVFVQUwociwgMCk7 Cj4gICAKPiAgIAkvKiBUT0RPOiB1c2UgYSByZWFsIENSQzMyICovCj4gLQlmb3IgKGkgPSAwLCBz dW0gPSAwOyBpIDwgZHRfc2l6ZTsgKytpKQo+ICsJZm9yICh1aW50NjRfdCBpID0gMCwgc3VtID0g MDsgaSA8IGR0X3NpemU7ICsraSkKClBsZWFzZSBrZWVwIHRoZSBkZWZpbmUgbG9jYWwgdG8gdGhl IGZ1bmN0aW9uLCBldmVuIHdvcnNlIHRoaXMgc2VlbXMgdG8gCnNoYWRvdyBhIGxvY2FsIGRlZmlu ZWQgaS4KCkNocmlzdGlhbi4KCj4gICAJCXN1bSArPSBwdHJbaV07Cj4gICAJQ1VfQVNTRVJUX0VR VUFMKHN1bSwgU1VNX0RFQ09ERSk7Cj4gICAKPiBkaWZmIC0tZ2l0IGEvdGVzdHMvYW1kZ3B1L3V2 ZF9lbmNfdGVzdHMuYyBiL3Rlc3RzL2FtZGdwdS91dmRfZW5jX3Rlc3RzLmMKPiBpbmRleCAwMzc3 YzFhNWQ3ZTFiNzg5ZDc4Mi4uYzFiODQwZTNlNTZkODNkMGEzYWYgMTAwNjQ0Cj4gLS0tIGEvdGVz dHMvYW1kZ3B1L3V2ZF9lbmNfdGVzdHMuYwo+ICsrKyBiL3Rlc3RzL2FtZGdwdS91dmRfZW5jX3Rl c3RzLmMKPiBAQCAtMjYxLDcgKzI2MSw3IEBAIHN0YXRpYyB2b2lkIGNoZWNrX3Jlc3VsdChzdHJ1 Y3QgYW1kZ3B1X3V2ZF9lbmMgKmVuYykKPiAgIAl1aW50NjRfdCBzdW07Cj4gICAJdWludDMyX3Qg cyA9IDE3NTYwMjsKPiAgIAl1aW50MzJfdCAqcHRyLCBzaXplOwo+IC0JaW50IGosIHI7Cj4gKwlp bnQgcjsKPiAgIAo+ICAgCXIgPSBhbWRncHVfYm9fY3B1X21hcChlbmMtPmZiLmhhbmRsZSwgKHZv aWQgKiopJmVuYy0+ZmIucHRyKTsKPiAgIAlDVV9BU1NFUlRfRVFVQUwociwgMCk7Cj4gQEAgLTI3 MSw3ICsyNzEsNyBAQCBzdGF0aWMgdm9pZCBjaGVja19yZXN1bHQoc3RydWN0IGFtZGdwdV91dmRf ZW5jICplbmMpCj4gICAJQ1VfQVNTRVJUX0VRVUFMKHIsIDApOwo+ICAgCXIgPSBhbWRncHVfYm9f Y3B1X21hcChlbmMtPmJzLmhhbmRsZSwgKHZvaWQgKiopJmVuYy0+YnMucHRyKTsKPiAgIAlDVV9B U1NFUlRfRVFVQUwociwgMCk7Cj4gLQlmb3IgKGogPSAwLCBzdW0gPSAwOyBqIDwgc2l6ZTsgKytq KQo+ICsJZm9yICh1aW50MzJfdCBqID0gMCwgc3VtID0gMDsgaiA8IHNpemU7ICsraikKPiAgIAkJ c3VtICs9IGVuYy0+YnMucHRyW2pdOwo+ICAgCUNVX0FTU0VSVF9FUVVBTChzdW0sIHMpOwo+ICAg CXIgPSBhbWRncHVfYm9fY3B1X3VubWFwKGVuYy0+YnMuaGFuZGxlKTsKPiBAQCAtMzMxLDcgKzMz MSw3IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9jc191dmRfZW5jX3Nlc3Npb25faW5pdCh2b2lkKQo+ ICAgCj4gICBzdGF0aWMgdm9pZCBhbWRncHVfY3NfdXZkX2VuY19lbmNvZGUodm9pZCkKPiAgIHsK PiAtCWludCBsZW4sIHIsIGk7Cj4gKwlpbnQgbGVuLCByOwo+ICAgCXVpbnQ2NF90IGx1bWFfb2Zm c2V0LCBjaHJvbWFfb2Zmc2V0Owo+ICAgCXVpbnQzMl90IHZidWZfc2l6ZSwgYnNfc2l6ZSA9IDB4 MDAzZjQ4MDAsIGNwYl9zaXplOwo+ICAgCXVuc2lnbmVkIGFsaWduID0gKGZhbWlseV9pZCA+PSBB TURHUFVfRkFNSUxZX0FJKSA/IDI1NiA6IDE2Owo+IEBAIC0zNTQsMTEgKzM1NCwxMSBAQCBzdGF0 aWMgdm9pZCBhbWRncHVfY3NfdXZkX2VuY19lbmNvZGUodm9pZCkKPiAgIAlDVV9BU1NFUlRfRVFV QUwociwgMCk7Cj4gICAKPiAgIAltZW1zZXQoZW5jLnZidWYucHRyLCAwLCB2YnVmX3NpemUpOwo+ IC0JZm9yIChpID0gMDsgaSA8IGVuYy5oZWlnaHQ7ICsraSkgewo+ICsJZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IGVuYy5oZWlnaHQ7ICsraSkgewo+ICAgCQltZW1jcHkoZW5jLnZidWYucHRyLCAo ZnJhbWUgKyBpICogZW5jLndpZHRoKSwgZW5jLndpZHRoKTsKPiAgIAkJZW5jLnZidWYucHRyICs9 IEFMSUdOKGVuYy53aWR0aCwgYWxpZ24pOwo+ICAgCX0KPiAtCWZvciAoaSA9IDA7IGkgPCBlbmMu aGVpZ2h0IC8gMjsgKytpKSB7Cj4gKwlmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZW5jLmhlaWdo dCAvIDI7ICsraSkgewo+ICAgCQltZW1jcHkoZW5jLnZidWYucHRyLCAoKGZyYW1lICsgZW5jLmhl aWdodCAqIGVuYy53aWR0aCkgKyBpICogZW5jLndpZHRoKSwgZW5jLndpZHRoKTsKPiAgIAkJZW5j LnZidWYucHRyICs9IEFMSUdOKGVuYy53aWR0aCwgYWxpZ24pOwo+ICAgCX0KPiBkaWZmIC0tZ2l0 IGEvdGVzdHMvYW1kZ3B1L3ZjZV90ZXN0cy5jIGIvdGVzdHMvYW1kZ3B1L3ZjZV90ZXN0cy5jCj4g aW5kZXggNzU4MjFiYmIxZTZjOTJlOTFmZTcuLjZkYTY1MTE3OTNhMWNmMGFiNDg4IDEwMDY0NAo+ IC0tLSBhL3Rlc3RzL2FtZGdwdS92Y2VfdGVzdHMuYwo+ICsrKyBiL3Rlc3RzL2FtZGdwdS92Y2Vf dGVzdHMuYwo+IEBAIC00MjUsOCArNDI1LDggQEAgc3RhdGljIHZvaWQgY2hlY2tfcmVzdWx0KHN0 cnVjdCBhbWRncHVfdmNlX2VuY29kZSAqZW5jKQo+ICAgewo+ICAgCXVpbnQ2NF90IHN1bTsKPiAg IAl1aW50MzJfdCBzWzJdID0gezE4MDMyNSwgMTU5NDZ9Owo+IC0JdWludDMyX3QgKnB0ciwgc2l6 ZTsKPiAtCWludCBpLCBqLCByOwo+ICsJdWludDMyX3QgKnB0ciwgaSwgaiwgc2l6ZTsKPiArCWlu dCByOwo+ICAgCj4gICAJZm9yIChpID0gMDsgaSA8IDI7ICsraSkgewo+ICAgCQlyID0gYW1kZ3B1 X2JvX2NwdV9tYXAoZW5jLT5mYltpXS5oYW5kbGUsICh2b2lkICoqKSZlbmMtPmZiW2ldLnB0cik7 Cj4gQEAgLTQ0OSw3ICs0NDksNyBAQCBzdGF0aWMgdm9pZCBhbWRncHVfY3NfdmNlX2VuY29kZSh2 b2lkKQo+ICAgewo+ICAgCXVpbnQzMl90IHZidWZfc2l6ZSwgYnNfc2l6ZSA9IDB4MTU0MDAwLCBj cGJfc2l6ZTsKPiAgIAl1bnNpZ25lZCBhbGlnbiA9IChmYW1pbHlfaWQgPj0gQU1ER1BVX0ZBTUlM WV9BSSkgPyAyNTYgOiAxNjsKPiAtCWludCBpLCByOwo+ICsJaW50IHI7Cj4gICAKPiAgIAl2YnVm X3NpemUgPSBBTElHTihlbmMud2lkdGgsIGFsaWduKSAqIEFMSUdOKGVuYy5oZWlnaHQsIDE2KSAq IDEuNTsKPiAgIAljcGJfc2l6ZSA9IHZidWZfc2l6ZSAqIDEwOwo+IEBAIC00NzIsMTEgKzQ3Miwx MSBAQCBzdGF0aWMgdm9pZCBhbWRncHVfY3NfdmNlX2VuY29kZSh2b2lkKQo+ICAgCUNVX0FTU0VS VF9FUVVBTChyLCAwKTsKPiAgIAo+ICAgCW1lbXNldChlbmMudmJ1Zi5wdHIsIDAsIHZidWZfc2l6 ZSk7Cj4gLQlmb3IgKGkgPSAwOyBpIDwgZW5jLmhlaWdodDsgKytpKSB7Cj4gKwlmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgZW5jLmhlaWdodDsgKytpKSB7Cj4gICAJCW1lbWNweShlbmMudmJ1Zi5w dHIsIChmcmFtZSArIGkgKiBlbmMud2lkdGgpLCBlbmMud2lkdGgpOwo+ICAgCQllbmMudmJ1Zi5w dHIgKz0gQUxJR04oZW5jLndpZHRoLCBhbGlnbik7Cj4gICAJfQo+IC0JZm9yIChpID0gMDsgaSA8 IGVuYy5oZWlnaHQgLyAyOyArK2kpIHsKPiArCWZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBlbmMu aGVpZ2h0IC8gMjsgKytpKSB7Cj4gICAJCW1lbWNweShlbmMudmJ1Zi5wdHIsICgoZnJhbWUgKyBl bmMuaGVpZ2h0ICogZW5jLndpZHRoKSArIGkgKiBlbmMud2lkdGgpLCBlbmMud2lkdGgpOwo+ICAg CQllbmMudmJ1Zi5wdHIgKz0gQUxJR04oZW5jLndpZHRoLCBhbGlnbik7Cj4gICAJfQo+IGRpZmYg LS1naXQgYS90ZXN0cy9hbWRncHUvdmNuX3Rlc3RzLmMgYi90ZXN0cy9hbWRncHUvdmNuX3Rlc3Rz LmMKPiBpbmRleCAyZWI4YzQzNDdiZTA5NGE3MDk1OC4uYjIyOGRiNjA5ZjBlMGMwZmVmZGQgMTAw NjQ0Cj4gLS0tIGEvdGVzdHMvYW1kZ3B1L3Zjbl90ZXN0cy5jCj4gKysrIGIvdGVzdHMvYW1kZ3B1 L3Zjbl90ZXN0cy5jCj4gQEAgLTIzOSw3ICsyMzksNyBAQCBzdGF0aWMgdm9pZCBmcmVlX3Jlc291 cmNlKHN0cnVjdCBhbWRncHVfdmNuX2JvICp2Y25fYm8pCj4gICAJbWVtc2V0KHZjbl9ibywgMCwg c2l6ZW9mKCp2Y25fYm8pKTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCB2Y25fZGVjX2NtZCh1 aW50NjRfdCBhZGRyLCB1bnNpZ25lZCBjbWQsIGludCAqaWR4KQo+ICtzdGF0aWMgdm9pZCB2Y25f ZGVjX2NtZCh1aW50NjRfdCBhZGRyLCB1bnNpZ25lZCBjbWQsIHVuc2lnbmVkICppZHgpCj4gICB7 Cj4gICAJaWJfY3B1WygqaWR4KSsrXSA9IDB4ODFDNDsKPiAgIAlpYl9jcHVbKCppZHgpKytdID0g YWRkcjsKPiBAQCAtMjg2LDcgKzI4Niw3IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9jc192Y25fZGVj X2RlY29kZSh2b2lkKQo+ICAgCWNvbnN0IHVuc2lnbmVkIGRwYl9zaXplID0gMTU5MjM1ODQsIGR0 X3NpemUgPSA3MzcyODA7Cj4gICAJdWludDY0X3QgbXNnX2FkZHIsIGZiX2FkZHIsIGJzX2FkZHIs IGRwYl9hZGRyLCBjdHhfYWRkciwgZHRfYWRkciwgaXRfYWRkciwgc3VtOwo+ICAgCXN0cnVjdCBh bWRncHVfdmNuX2JvIGRlY19idWY7Cj4gLQlpbnQgc2l6ZSwgbGVuLCBpLCByOwo+ICsJdW5zaWdu ZWQgc2l6ZSwgbGVuLCBpLCByOwo+ICAgCXVpbnQ4X3QgKmRlYzsKPiAgIAo+ICAgCXNpemUgPSA0 KjEwMjQ7IC8qIG1zZyAqLwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==