From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andreas Christoforou <andreaschristofo@gmail.com>, keescook@chromium.org
Cc: kernel-hardening@lists.openwall.com,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage
Date: Fri, 9 Mar 2018 05:34:36 -0800 [thread overview]
Message-ID: <fb0bb0e5-e037-e006-ca11-45eb8a8aa1b7@gmail.com> (raw)
In-Reply-To: <1520601833-4952-1-git-send-email-andreaschristofo@gmail.com>
On 03/09/2018 05:23 AM, Andreas Christoforou wrote:
> The kernel would like to have all stack VLA usage removed.
>
> This is the correct patch.
>
> Signed-off-by: Andreas Christoforou <andreaschristofo@gmail.com>
This is a lazy changelog really.
'This is the correct patch' has no technical value.
What is VLA ? Sure, _now_ its pretty clear since we have floods of
these patches, but...
In one or two years, people reading it will not understand the logic of
this patch.
I had to look at the source to understand what was going on, and that is
not a good sign for a trivial patch like that.
next prev parent reply other threads:[~2018-03-09 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 13:23 [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage Andreas Christoforou
2018-03-09 13:29 ` Joe Perches
2018-03-09 15:42 ` Rosen Penev
2018-03-09 13:34 ` Eric Dumazet [this message]
2018-03-09 14:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0bb0e5-e037-e006-ca11-45eb8a8aa1b7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=andreaschristofo@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.