diff for duplicates of <fb10d0ee60740869487349b87e9d7e23@mail.gmail.com> diff --git a/a/1.txt b/N1/1.txt index 2a6dd09..a562142 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ > -----Original Message----- -> From: Santosh Shilimkar [mailto:santosh.shilimkar@ti.com] +> From: Santosh Shilimkar [mailto:santosh.shilimkar at ti.com] > Sent: Monday, February 21, 2011 3:57 PM > To: Jean Pihet -> Cc: linux-omap@vger.kernel.org; Kevin Hilman; linux-arm- -> kernel@lists.infradead.org; Rajendra Nayak +> Cc: linux-omap at vger.kernel.org; Kevin Hilman; linux-arm- +> kernel at lists.infradead.org; Rajendra Nayak > Subject: RE: [PATCH 14/17] omap4: cpuidle: Add MPUSS RET OFF states > @@ -24,10 +24,10 @@ > > through hotplug infrastructure. " > > The test below does not seem to match this comment. > > -> > > + /* -> > > + * Special hardware/software considerations: -> > > + * 1. Do only WFI for secondary CPU(non-boot - CPU1). -> > > + * Secondary cores are taken down only via hotplug +> > > + ? ? ? /* +> > > + ? ? ? ?* Special hardware/software considerations: +> > > + ? ? ? ?* 1. Do only WFI for secondary CPU(non-boot - CPU1). +> > > + ? ? ? ?* ? ?Secondary cores are taken down only via hotplug > > path. > > The comment looks contradictory. Which one is taken OFF using this > > code, which one from hotplug? @@ -36,32 +36,32 @@ > > Yes. > > -> > > + * 2. Do only a WFI as long as in SMP mode. +> > > + ? ? ? ?* 2. Do only a WFI as long as in SMP mode. > > Does this correspond to the condition '(num_online_cpus() > 1)' in > > the > > test below? If so it this one triggering the low power mode for > > cpu0? > yes > > -> > > + * 3. Continue to do only WFI till CPU1 hits OFF state. -> > > + * This is necessary to honour hardware +> > > + ? ? ? ?* 3. Continue to do only WFI till CPU1 hits OFF state. +> > > + ? ? ? ?* ? ?This is necessary to honour hardware > recommondation -> > > + * of triggeing all the possible low power modes once +> > > + ? ? ? ?* ? ?of triggeing all the possible low power modes once > > CPU1 is -> > > + * out of coherency and in OFF mode. +> > > + ? ? ? ?* ? ?out of coherency and in OFF mode. > > Does this correspond to the condition '(cpu1_state != > > PWRDM_POWER_OFF)' in the test below? > > > Yes > -> > > + * Update dev->last_state so that governor stats +> > > + ? ? ? ?* Update dev->last_state so that governor stats > reflects > > right -> > > + * data. -> > > + */ -> > > + cpu1_state = pwrdm_read_pwrst(cpu1_pd); -> > > + if ((dev->cpu) || (num_online_cpus() > 1) || -> > > + (cpu1_state != PWRDM_POWER_OFF)) { +> > > + ? ? ? ?* data. +> > > + ? ? ? ?*/ +> > > + ? ? ? cpu1_state = pwrdm_read_pwrst(cpu1_pd); +> > > + ? ? ? if ((dev->cpu) || (num_online_cpus() > 1) || +> > > + ? ? ? ? ? ? ? ? ? ? ? (cpu1_state != PWRDM_POWER_OFF)) { > > Are '||' correct here? > Yes. > @@ -75,7 +75,3 @@ > Will add the code conditions in comments as well so that it becomes mere readable. --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index d53014b..58bcd48 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,23 +2,18 @@ "ref\01298112158-28469-15-git-send-email-santosh.shilimkar@ti.com\0" "ref\0AANLkTik-hj+-ZPnfVKLCH0h-QeyziH4H-j6EE+_QHHCU@mail.gmail.com\0" "ref\06176616fe77333f80f0cfaae4fc8aff3@mail.gmail.com\0" - "From\0Santosh Shilimkar <santosh.shilimkar@ti.com>\0" - "Subject\0RE: [PATCH 14/17] omap4: cpuidle: Add MPUSS RET OFF states\0" + "From\0santosh.shilimkar@ti.com (Santosh Shilimkar)\0" + "Subject\0[PATCH 14/17] omap4: cpuidle: Add MPUSS RET OFF states\0" "Date\0Mon, 21 Feb 2011 19:31:50 +0530\0" - "To\0Santosh Shilimkar <santosh.shilimkar@ti.com>" - " Jean Pihet <jean.pihet@newoldbits.com>\0" - "Cc\0linux-omap@vger.kernel.org" - Kevin Hilman <khilman@ti.com> - linux-arm-kernel@lists.infradead.org - " Rajendra Nayak <rnayak@ti.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "> -----Original Message-----\n" - "> From: Santosh Shilimkar [mailto:santosh.shilimkar@ti.com]\n" + "> From: Santosh Shilimkar [mailto:santosh.shilimkar at ti.com]\n" "> Sent: Monday, February 21, 2011 3:57 PM\n" "> To: Jean Pihet\n" - "> Cc: linux-omap@vger.kernel.org; Kevin Hilman; linux-arm-\n" - "> kernel@lists.infradead.org; Rajendra Nayak\n" + "> Cc: linux-omap at vger.kernel.org; Kevin Hilman; linux-arm-\n" + "> kernel at lists.infradead.org; Rajendra Nayak\n" "> Subject: RE: [PATCH 14/17] omap4: cpuidle: Add MPUSS RET OFF states\n" ">\n" "\n" @@ -39,10 +34,10 @@ "> > through hotplug infrastructure. \"\n" "> > The test below does not seem to match this comment.\n" "> >\n" - "> > > + \302\240 \302\240 \302\240 /*\n" - "> > > + \302\240 \302\240 \302\240 \302\240* Special hardware/software considerations:\n" - "> > > + \302\240 \302\240 \302\240 \302\240* 1. Do only WFI for secondary CPU(non-boot - CPU1).\n" - "> > > + \302\240 \302\240 \302\240 \302\240* \302\240 \302\240Secondary cores are taken down only via hotplug\n" + "> > > + ? ? ? /*\n" + "> > > + ? ? ? ?* Special hardware/software considerations:\n" + "> > > + ? ? ? ?* 1. Do only WFI for secondary CPU(non-boot - CPU1).\n" + "> > > + ? ? ? ?* ? ?Secondary cores are taken down only via hotplug\n" "> > path.\n" "> > The comment looks contradictory. Which one is taken OFF using this\n" "> > code, which one from hotplug?\n" @@ -51,32 +46,32 @@ ">\n" "> Yes.\n" "> >\n" - "> > > + \302\240 \302\240 \302\240 \302\240* 2. Do only a WFI as long as in SMP mode.\n" + "> > > + ? ? ? ?* 2. Do only a WFI as long as in SMP mode.\n" "> > Does this correspond to the condition '(num_online_cpus() > 1)' in\n" "> > the\n" "> > test below? If so it this one triggering the low power mode for\n" "> > cpu0?\n" "> yes\n" "> >\n" - "> > > + \302\240 \302\240 \302\240 \302\240* 3. Continue to do only WFI till CPU1 hits OFF state.\n" - "> > > + \302\240 \302\240 \302\240 \302\240* \302\240 \302\240This is necessary to honour hardware\n" + "> > > + ? ? ? ?* 3. Continue to do only WFI till CPU1 hits OFF state.\n" + "> > > + ? ? ? ?* ? ?This is necessary to honour hardware\n" "> recommondation\n" - "> > > + \302\240 \302\240 \302\240 \302\240* \302\240 \302\240of triggeing all the possible low power modes once\n" + "> > > + ? ? ? ?* ? ?of triggeing all the possible low power modes once\n" "> > CPU1 is\n" - "> > > + \302\240 \302\240 \302\240 \302\240* \302\240 \302\240out of coherency and in OFF mode.\n" + "> > > + ? ? ? ?* ? ?out of coherency and in OFF mode.\n" "> > Does this correspond to the condition '(cpu1_state !=\n" "> > PWRDM_POWER_OFF)' in the test below?\n" "> >\n" "> Yes\n" ">\n" - "> > > + \302\240 \302\240 \302\240 \302\240* Update dev->last_state so that governor stats\n" + "> > > + ? ? ? ?* Update dev->last_state so that governor stats\n" "> reflects\n" "> > right\n" - "> > > + \302\240 \302\240 \302\240 \302\240* data.\n" - "> > > + \302\240 \302\240 \302\240 \302\240*/\n" - "> > > + \302\240 \302\240 \302\240 cpu1_state = pwrdm_read_pwrst(cpu1_pd);\n" - "> > > + \302\240 \302\240 \302\240 if ((dev->cpu) || (num_online_cpus() > 1) ||\n" - "> > > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 (cpu1_state != PWRDM_POWER_OFF)) {\n" + "> > > + ? ? ? ?* data.\n" + "> > > + ? ? ? ?*/\n" + "> > > + ? ? ? cpu1_state = pwrdm_read_pwrst(cpu1_pd);\n" + "> > > + ? ? ? if ((dev->cpu) || (num_online_cpus() > 1) ||\n" + "> > > + ? ? ? ? ? ? ? ? ? ? ? (cpu1_state != PWRDM_POWER_OFF)) {\n" "> > Are '||' correct here?\n" "> Yes.\n" ">\n" @@ -89,10 +84,6 @@ "> And you got all of them correctly.\n" ">\n" "Will add the code conditions in comments as well so that\n" - "it becomes mere readable.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + it becomes mere readable. -d79d2a13312e18b7abbe7ced5b56a25216dabb4def6fffca066e76b1e94adec2 +cfb0946873c4802703847777cf2c3d2caa101ed03c95c23aa4a78e90a3043058
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.