From: <Ajay.Kathat@microchip.com>
To: <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>, <johannes@sipsolutions.net>,
<gregkh@linuxfoundation.org>, <Adham.Abozaeid@microchip.com>,
<Venkateswara.Kaja@microchip.com>, <Nicolas.Ferre@microchip.com>,
<Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH 00/16] wilc1000: move out of staging
Date: Thu, 23 May 2019 16:45:04 +0000 [thread overview]
Message-ID: <fb17fb6b-08d2-6871-d214-2fbcc1da73fb@microchip.com> (raw)
In-Reply-To: <87sgt5cl8q.fsf@kamboji.qca.qualcomm.com>
Hi Kalle,
On 5/23/2019 7:43 PM, Kalle Valo wrote:
> <Ajay.Kathat@microchip.com> writes:
>
>> Hi Kalle,
>>
>> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>>>
>>> <Ajay.Kathat@microchip.com> writes:
>>>
>>>> Hi Kalle/Johannes,
>>>>
>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>>
>>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>>> Implemented the initial received review comments[1] and submitting the
>>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>>
>>>>> Below are the major items fixed in recent cleanup:
>>>>> - remove use of shadow buffer to keep scan result.
>>>>> - remove internal messaging flow to handle cfg80211_ops.
>>>>> - make use of cfg80211 provided API.
>>>>> - use structure for packing firmware commands.
>>>>> - make use of kernel provided API and macros.
>>>>> - remove unnecessary logs messages.
>>>>>
>>>>> Pending action item:
>>>>> - dynamically add/remove p2p interface.
>>>>>
>>>>> This item will take some time, we are planning to take it up after
>>>>> mainline.
>>>>>
>>>>> We hope it can be move out staging in v5.1.
>>>>> Please review and confirm if it is good to move out.
>>>>
>>>> Do you have any update for this series. Please provide your inputs for
>>>> next step.
>>>
>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>>> take a look at this in the next few weeks.
>>>
>>
>> Is there any update for wilc1000 driver review. Please let me know your
>> inputs.
>
> So is the driver in good shape now? I really do not want to use a lot of
> time reviewing it just to find out that there's a lot of work to do. For
> example, has someone else reviewed it?
>
The first series for complete driver review was submitted earlier [1].
It was reviewed by Johannes and he looked into driver integration with
the cfg80211 stack part. We worked on the review comments and submitted
the changes to staging.
We need further review to identify if there is any blocker to move to
mainline.
[1]. https://www.spinics.net/lists/linux-wireless/msg177878.html
Regards,
Ajay
next prev parent reply other threads:[~2019-05-23 16:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 7:12 [PATCH 00/16] wilc1000: move out of staging Ajay.Kathat
2019-02-09 7:12 ` [PATCH 01/16] wilc1000: add host_interface.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 02/16] wilc1000: add host_interface.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 03/16] wilc1000: add wilc_wlan_if.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 04/16] wilc1000: add wilc_wlan_cfg.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 05/16] wilc1000: add wilc_wlan_cfg.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 06/16] wilc1000: add wilc_wfi_netdevice.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 07/16] wilc1000: add wilc_wfi_cfgoperations.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 08/16] wilc1000: add wilc_wfi_cfgoperations.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 09/16] wilc1000: add wilc_netdev.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 10/16] wilc1000: add wilc_mon.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 11/16] wilc1000: add wilc_spi.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 12/16] wilc1000: add wilc_wlan.c Ajay.Kathat
2019-02-09 7:12 ` [PATCH 13/16] wilc1000: add wilc_wlan.h Ajay.Kathat
2019-02-09 7:12 ` [PATCH 14/16] wilc1000: add wilc_sdio.c Ajay.Kathat
2019-02-09 7:13 ` [PATCH 15/16] wilc1000: updated DT device binding for wilc1000 device Ajay.Kathat
2019-02-09 7:13 ` [PATCH 16/16] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat
2019-03-21 12:49 ` [PATCH 00/16] wilc1000: move out of staging Ajay.Kathat
2019-03-21 12:54 ` Kalle Valo
2019-03-21 14:06 ` Ajay.Kathat
2019-05-23 13:32 ` Ajay.Kathat
2019-05-23 14:13 ` Kalle Valo
2019-05-23 16:45 ` Ajay.Kathat [this message]
2019-05-31 4:53 ` Ajay.Kathat
2019-05-31 6:23 ` Kalle Valo
2019-05-31 7:11 ` Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb17fb6b-08d2-6871-d214-2fbcc1da73fb@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Venkateswara.Kaja@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.