From: Jesse Brandeburg <jesse.brandeburg@linux.dev>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
eric.dumazet@gmail.com
Subject: Re: [PATCH v3 net-next 3/5] net: no longer hold RTNL while calling flush_all_backlogs()
Date: Tue, 14 Jan 2025 15:04:19 -0800 [thread overview]
Message-ID: <fb1b4bc3-b6be-42d6-b664-015c0261dec0@linux.dev> (raw)
In-Reply-To: <20250114205531.967841-4-edumazet@google.com>
On 1/14/25 12:55 PM, Eric Dumazet wrote:
> flush_all_backlogs() is called from unregister_netdevice_many_notify()
> as part of netdevice dismantles.
>
> This is currently called under RTNL, and can last up to 50 ms
> on busy hosts.
>
> There is no reason to hold RTNL at this stage, if our caller
> is cleanup_net() : netns are no more visible, devices
> are in NETREG_UNREGISTERING state and no other thread
> could mess our state while RTNL is temporarily released.
>
> In order to provide isolation, this patch provides a separate
> 'net_todo_list' for cleanup_net().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jesse Brandeburg <jbrandeburg@cloudflare.com>
next prev parent reply other threads:[~2025-01-14 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 20:55 [PATCH v3 net-next 0/5] net: reduce RTNL pressure in unregister_netdevice() Eric Dumazet
2025-01-14 20:55 ` [PATCH v3 net-next 1/5] net: expedite synchronize_net() for cleanup_net() Eric Dumazet
2025-01-14 22:57 ` Jesse Brandeburg
2025-01-14 20:55 ` [PATCH v3 net-next 2/5] net: no longer assume RTNL is held in flush_all_backlogs() Eric Dumazet
2025-01-14 23:01 ` Jesse Brandeburg
2025-01-14 20:55 ` [PATCH v3 net-next 3/5] net: no longer hold RTNL while calling flush_all_backlogs() Eric Dumazet
2025-01-14 23:04 ` Jesse Brandeburg [this message]
2025-02-10 4:13 ` Kuniyuki Iwashima
2025-01-14 20:55 ` [PATCH v3 net-next 4/5] net: reduce RTNL hold duration in unregister_netdevice_many_notify() (part 1) Eric Dumazet
2025-01-14 23:05 ` Jesse Brandeburg
2025-01-14 20:55 ` [PATCH v3 net-next 5/5] net: reduce RTNL hold duration in unregister_netdevice_many_notify() (part 2) Eric Dumazet
2025-01-14 23:09 ` Jesse Brandeburg
2025-01-16 3:30 ` [PATCH v3 net-next 0/5] net: reduce RTNL pressure in unregister_netdevice() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1b4bc3-b6be-42d6-b664-015c0261dec0@linux.dev \
--to=jesse.brandeburg@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.