From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98CC3C0219D for ; Thu, 13 Feb 2025 14:28:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.887689.1297148 (Exim 4.92) (envelope-from ) id 1tiaCm-0007aA-Hq; Thu, 13 Feb 2025 14:28:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 887689.1297148; Thu, 13 Feb 2025 14:28:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tiaCm-0007a3-Ez; Thu, 13 Feb 2025 14:28:40 +0000 Received: by outflank-mailman (input) for mailman id 887689; Thu, 13 Feb 2025 14:28:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tiaCl-0007Zm-01 for xen-devel@lists.xenproject.org; Thu, 13 Feb 2025 14:28:39 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfe46891-ea16-11ef-abfc-e33de0ed8607; Thu, 13 Feb 2025 15:28:37 +0100 (CET) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-308dc0878dfso10048281fa.3 for ; Thu, 13 Feb 2025 06:28:37 -0800 (PST) Received: from [192.168.209.66] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-309102bbec2sm2138781fa.111.2025.02.13.06.28.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 06:28:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfe46891-ea16-11ef-abfc-e33de0ed8607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739456916; x=1740061716; darn=lists.xenproject.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=FDjS6HuoRVV6uFzyfUIfm+sxEvKhNCZJykI8AYh0vOA=; b=ZfBF5/Eu1tOX2/dSyyWD+fQabvxCPssI2shjDTu4Xjf8uYn7ETPLxiuDM4NG1FYink 8lm1M36eA2pIEJthPaOMeN4wadWMKUbQZztp37TrjILzxkJTy9gI4B8WC/Fa6oPrbds6 A5KOyuDXF493EicjkSknMBO34QejHx04Kx3zMVLM/R+RJgesOHcAE6Tg0p8LogcVUJSv bO3uH/lVsFV+NsZ8gninuMhpRDo2OHkrCQzw6/nK/MaqiWB1Tj76hKybNxxpUFKTZ/z4 0dG9sN5N/Pvo4iq2SqEeE+48y81QxPGsh50BVFdyA3Zp4sEo9Uc3xFkqp/JzedizuN+g toOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739456916; x=1740061716; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FDjS6HuoRVV6uFzyfUIfm+sxEvKhNCZJykI8AYh0vOA=; b=qWfIKrF/BdOTaLCb+BYe6RW4pQS1wxtoFjA8D9G7OnY+c48Rr5FAmhrqYsQilWNmxT YmzMvOTyn9rauW5UR0wSVdpaFItokYF0up8JFp6HxOzFNXcGhN8I6kPZajo4rvtu523p mHUBBuhPIOHCSBrW/DU1CiW1f6ZfyAFUqaAkMWsMBbtHhqq9NRBhYhFMjVJKl4F8U0HG 4FpXkF5V8uZIVUFTKAqAX8ZiaBgCdJ3IYmRZs5JdJ37bEtlkr1jP5g9su8L09w/NK1BV pyV3G3q18FB5waH4ggfBMUIKyYmHvOzbtnaLZ55SbUGl/v0l7Zdmq25+wJD4mtBl47OM lHxA== X-Gm-Message-State: AOJu0Yxdh0xINzFQWNrxkg66tvl6CYu097I6L6ggniKRBBAJPv36xOcW l7T4xx3vnQlU0Ac8mFcOHo+g4MZhNMbCUQDsd2jts+RS9l1jQJdN X-Gm-Gg: ASbGncsbsbSq49cJ5m7Bmt1RaIqd5BF+0i6cxYrp9sU4CwA1l4VVdTYIESB2dsxxN/D ZRoG+Ewgyo5bmWntg4Ij8kOpjX4jm0atvliQF4IursVR/5dynI2KQHkboYzRM3ZPjmOtAvJnPHz eYZh29/UPLXLmvY/4STMx0NccG87P3VKUHNzYrm5WCGeYNfnrTkZM7+yJ8SO9XS519Du13PmP7G 7pNsq7lw+lIFqxjitThdMkoljGlTzcRDO6RGvX1sV9SQ6NAIByqd/sNuRGoX2dNM/NQoGpVWnXy fiTaqJCmbBWG2xijUgHdx0qN0dQ= X-Google-Smtp-Source: AGHT+IHuyNDcHKYD8sUNO1XZ7icuygXjzgxAl3fMWBEkzJRGk9Ty/HC7pond5RNk27+5ERbCi4iipw== X-Received: by 2002:a2e:a99e:0:b0:308:ee65:7f4e with SMTP id 38308e7fff4ca-30903554dc6mr25300211fa.0.1739456916273; Thu, 13 Feb 2025 06:28:36 -0800 (PST) Content-Type: multipart/alternative; boundary="------------Gs9jnFChaULQ3HxzdTSNFY8s" Message-ID: Date: Thu, 13 Feb 2025 15:28:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 for-4.20(?) 0/4] Add/enable stack protector To: Julien Grall , Andrew Cooper , Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Anthony PERARD , Michal Orzel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Samuel Thibault , Bertrand Marquis , Community Manager References: <20250114042553.1624831-1-volodymyr_babchuk@epam.com> <5b6b1ad2-c0cd-454c-aa7c-b6de37ab39df@citrix.com> <87pljmymos.fsf@epam.com> <402c93ec-9cb0-41e0-b1c8-eca321140ad6@gmail.com> <2dbe84e9-485b-47e1-8ceb-94ed9b6b13bc@xen.org> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <2dbe84e9-485b-47e1-8ceb-94ed9b6b13bc@xen.org> This is a multi-part message in MIME format. --------------Gs9jnFChaULQ3HxzdTSNFY8s Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/13/25 3:24 PM, Julien Grall wrote: > Hi, > > On 13/02/2025 14:21, Oleksii Kurochko wrote: >> >> On 2/13/25 3:07 PM, Andrew Cooper wrote: >>> On 13/02/2025 1:54 pm, Volodymyr Babchuk wrote: >>>> Hi Andrew, >>>> >>>> Andrew Cooper writes: >>>> >>>>> On 14/01/2025 4:25 am, Volodymyr Babchuk wrote: >>>>>> Volodymyr Babchuk (4): >>>>>>    common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS >>>>>>    xen: common: add ability to enable stack protector >>>>>>    xen: arm: enable stack protector feature >>>>>>    CHANGELOG.md: Mention stack-protector feature >>>>> Reviewed-by: Andrew Cooper >>>>> >>>>> There's one minor formatting error which can be fixed on commit. >>>>> >>>>> ~Andrew >>>> Thanks for the review. I noticed that this series is not committed. Is >>>> there anything else required from my side? >>>> >>> You need an ARM Ack on patch 3.  [EDIT], no you don't, my R-by is good >>> enough. > > I beg to differ. For low level code, you really ought to have Arm > folks to confirm this is correct. In fact, I don't think patch #3 it > is. So ... > >>> >>> And at this point at rc4, you'll need to persuade Oleksii to take it >>> for >>> 4.20. >>> >>> Personally I think it's low risk and worthwhile to take for 4.20, >>> and it >>> was technically completed in time - it just fell between the cracks. >> >> I think the same it's low risk patch series, so we can take it for 4.20: >>   Release-Acked-by: Oleksii Kurochko > > ... I should not go to 4.20 as-is. > > And before someone ask why it wasn't answered early. I can't comment > for the other Arm maintainers, but I have been away for the past two > months. So still catching up on my emails. Agree, I wrote that in follow-up reply to my initial reply. So if the proper Ack will be received I still think we can consider to have it in 4.20. ~ Oleksii > --------------Gs9jnFChaULQ3HxzdTSNFY8s Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2/13/25 3:24 PM, Julien Grall wrote:
Hi,

On 13/02/2025 14:21, Oleksii Kurochko wrote:

On 2/13/25 3:07 PM, Andrew Cooper wrote:
On 13/02/2025 1:54 pm, Volodymyr Babchuk wrote:
Hi Andrew,

Andrew Cooper<andrew.cooper3@citrix.com> writes:

On 14/01/2025 4:25 am, Volodymyr Babchuk wrote:
Volodymyr Babchuk (4):
   common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS
   xen: common: add ability to enable stack protector
   xen: arm: enable stack protector feature
   CHANGELOG.md: Mention stack-protector feature
Reviewed-by: Andrew Cooper<andrew.cooper3@citrix.com>

There's one minor formatting error which can be fixed on commit.

~Andrew
Thanks for the review. I noticed that this series is not committed. Is
there anything else required from my side?

You need an ARM Ack on patch 3.  [EDIT], no you don't, my R-by is good
enough.

I beg to differ. For low level code, you really ought to have Arm folks to confirm this is correct. In fact, I don't think patch #3 it is. So ...


And at this point at rc4, you'll need to persuade Oleksii to take it for
4.20.

Personally I think it's low risk and worthwhile to take for 4.20, and it
was technically completed in time - it just fell between the cracks.

I think the same it's low risk patch series, so we can take it for 4.20:
  Release-Acked-by: Oleksii Kurochko<olekskii.kurochko@gmail.com>

... I should not go to 4.20 as-is.

And before someone ask why it wasn't answered early. I can't comment for the other Arm maintainers, but I have been away for the past two months. So still catching up on my emails. 
Agree, I wrote that in follow-up reply to my initial reply.

So if the proper Ack will be received I still think we can consider to have it in 4.20.

~ Oleksii

--------------Gs9jnFChaULQ3HxzdTSNFY8s--