From: Zhu Lingshan <lingshan.zhu@linux.intel.com>
To: Jason Wang <jasowang@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: lulu@redhat.com
Subject: Re: [PATCH V2 1/2] vdpa: Support config interrupt in vhost_vdpa
Date: Sun, 26 Apr 2020 15:24:49 +0800 [thread overview]
Message-ID: <fb51aa36-9a58-fd50-a4fa-4cc887357367@linux.intel.com> (raw)
In-Reply-To: <e345cc85-aa9d-1173-8308-f0a301fca2b2@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 849 bytes --]
On 4/26/2020 3:03 PM, Jason Wang wrote:
>
> On 2020/4/26 下午2:58, Jason Wang wrote:
>>>
>>> diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
>>> index 1813821..8663139 100644
>>> --- a/drivers/vhost/vhost.h
>>> +++ b/drivers/vhost/vhost.h
>>> @@ -18,6 +18,8 @@
>>> typedef void (*vhost_work_fn_t)(struct vhost_work *work);
>>> #define VHOST_WORK_QUEUED 1
>>> +#define VHOST_FILE_UNBIND -1
>>
>>
>> I think it's better to document this in uapi.
>
>
> I meant e.g in vhost_vring_file, we had a comment of unbinding:
>
> struct vhost_vring_file {
> unsigned int index;
> int fd; /* Pass -1 to unbind from file. */
>
> };
I think it is better to use an int fd than vhost_vring_file, to avoid the confusions,
so if we add#define VHOST_FILE_UNBIND -1 in the uapi header, can it document itself?
Thanks
>
> Thanks
>
[-- Attachment #1.2: Type: text/html, Size: 2257 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-04-26 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 6:09 [PATCH V2 0/2] Config interrupt support in VDPA and IFCVF Zhu Lingshan
2020-04-26 6:09 ` [PATCH V2 1/2] vdpa: Support config interrupt in vhost_vdpa Zhu Lingshan
2020-04-26 6:58 ` Jason Wang
2020-04-26 6:58 ` Jason Wang
2020-04-26 7:03 ` Zhu Lingshan
2020-04-26 7:03 ` Jason Wang
2020-04-26 7:24 ` Zhu Lingshan [this message]
2020-04-26 7:38 ` Jason Wang
2020-04-26 6:09 ` [PATCH V2 2/2] vdpa: implement config interrupt in IFCVF Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb51aa36-9a58-fd50-a4fa-4cc887357367@linux.intel.com \
--to=lingshan.zhu@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.