Re: [PATCH 2/3] thunderbolt: Reset the host interface before reusing a DMA HopID

[Mario Limonciello <mario.limonciello@amd.com>]

On 10/5/26 09:35, Mika Westerberg wrote:
> Hi,
> 
> On Mon, Oct 05, 2026 at 07:13:40PM +0530, Basavaraj Natikar wrote:
>> +++ b/drivers/thunderbolt/nhi.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/iommu.h>
>>   #include <linux/lockdep.h>
>>   #include <linux/module.h>
>> +#include <linux/pci.h>
> 
> I haven't looked at the code at all yet but this one is no-go. We are
> trying to make the NHI code generic that can work with any interconnect,
> like the controllers on ARM based SoCs (aka platform bus) and that's why we
> have pci.c for the PCIe based NHIs.

To add to that - what tree did you base on?  I tried on thunderbolt/next 
(a93a8e3200002f0c345fec4c340390e9a60aabc7) and it doesn't apply.

╰─❯ b4 shazam 
https://lore.kernel.org/linux-usb/cover.1790854235.git.Basavaraj.Natikar@amd.com/T/#m2e70efa2f627df231d9f975424096587b819a354
Looking up 
https://lore.kernel.org/all/cover.1790854235.git.Basavaraj.Natikar@amd.com/
Grabbing thread from 
lore.kernel.org/all/cover.1790854235.git.Basavaraj.Natikar@amd.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 5 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
   ✓ [PATCH 1/3] thunderbolt: Allow tb_ring_start() to fail
   ✓ [PATCH 2/3] thunderbolt: Reset the host interface before reusing a 
DMA HopID
   ✓ [PATCH 3/3] thunderbolt: Add quirk to reset host interface for AMD 
USB4 routers
   ---
   ✓ Signed: DKIM/amd.com
---
Total patches: 3
---
Applying: thunderbolt: Allow tb_ring_start() to fail
Applying: thunderbolt: Reset the host interface before reusing a DMA HopID
Patch failed at 0002 thunderbolt: Reset the host interface before 
reusing a DMA HopID
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: drivers/thunderbolt/nhi.c:17
error: drivers/thunderbolt/nhi.c: patch does not apply
error: patch failed: drivers/thunderbolt/nhi.h:123
error: drivers/thunderbolt/nhi.h: patch does not apply
error: patch failed: drivers/thunderbolt/nhi_regs.h:115
error: drivers/thunderbolt/nhi_regs.h: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch