From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
u.kleine-koenig@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com,
hugo@hugovil.com, LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Lukas Wunner <lukas@wunner.de>,
p.rosenberger@kunbus.com, stable@vger.kernel.org
Subject: Re: [PATCH v5 5/7] serial: core, imx: do not set RS485 enabled if it is not supported
Date: Thu, 14 Dec 2023 11:27:03 +0200 (EET) [thread overview]
Message-ID: <fb579fd-a5ae-2838-d1b-eefc16ad015@linux.intel.com> (raw)
In-Reply-To: <9271d88a-52bf-4f3a-9861-fdc5120cfc31@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Wed, 13 Dec 2023, Lino Sanfilippo wrote:
> On 11.12.23 12:00, Ilpo Järvinen wrote:
> > On Sat, 9 Dec 2023, Lino Sanfilippo wrote:
>
> > Looking into the code, that setting of rs485_supported from imx_no_rs485
> > is actually superfluous as it should be already cleared to zeros on alloc.
> >
>
> Yes. BTW: Another "no_rs485" configuration setting can be found in the ar933x driver.
> If we do not want to keep those assignments I can remove the one for the imx
> driver with the next version of this patch...
I think they can just be dropped as it's normal in Linux code to assume
that things are zeroed by default. Those "no"-variants originate from the
time when supported_rs485 was not yet embedded but just a pointer to a
const struct and I didn't realize I could have removed them when I ended
up embedding the struct so it can be altered per port.
--
i.
next prev parent reply other threads:[~2023-12-14 9:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 12:58 [PATCH v5 0/7] Fixes and improvements for RS485 Lino Sanfilippo
2023-12-09 12:58 ` [PATCH v5 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2023-12-11 10:35 ` Ilpo Järvinen
2023-12-13 22:14 ` Lino Sanfilippo
2023-12-11 14:49 ` Hugo Villeneuve
2023-12-09 12:58 ` [PATCH v5 2/7] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2023-12-11 10:36 ` Ilpo Järvinen
2023-12-09 12:58 ` [PATCH v5 3/7] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2023-12-11 10:40 ` Ilpo Järvinen
2023-12-09 12:58 ` [PATCH v5 4/7] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2023-12-11 10:53 ` Ilpo Järvinen
2023-12-13 22:23 ` Lino Sanfilippo
2023-12-09 12:58 ` [PATCH v5 5/7] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2023-12-11 11:00 ` Ilpo Järvinen
2023-12-13 22:31 ` Lino Sanfilippo
2023-12-14 9:27 ` Ilpo Järvinen [this message]
2023-12-09 12:58 ` [PATCH v5 6/7] serial: omap: do not override settings for RS485 support Lino Sanfilippo
2023-12-13 10:26 ` Ilpo Järvinen
2023-12-13 22:55 ` Lino Sanfilippo
2023-12-09 12:58 ` [PATCH v5 7/7] serial: 8250_exar: Set missing rs485_supported flag Lino Sanfilippo
2023-12-13 10:18 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb579fd-a5ae-2838-d1b-eefc16ad015@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=cniedermaier@dh-electronics.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.rosenberger@kunbus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.