From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CF97D609A7 for ; Wed, 27 Nov 2024 08:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; b=zFAsWxVyreSDB79niR8bsmT3xz 0ag6+etSudnGB2/Wqa4oGMyLD1Zkw7yOPn/pBP/hmls2DFqnB4oVX0LK/CfV9g3soscBS9GW4LZzE h1DXXkRYDNdd9IxjTojid8JYJZ2AjNoAuPi3en+B8Ib3Bl1xdBFvLd0sHynnm/dZDARdKWoWDhXIg C2bG382Qx52odcadiRcgCpFoVSxyeqTYRDfQEFx48OwG9lNSqw+8M15Ogq0LJgRp0M69METe1xa8t FY/9srAh8g2hw0rtLZjEpzr7c8mpkL+OaDEG+k9w2IaGnFk5FNjqHCHkz4WVm7cdmJqtFnBMyDLbJ UC+Ruc+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGD6F-0000000CXSn-0wg6; Wed, 27 Nov 2024 08:08:39 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGD1S-0000000CWUQ-2j6x for linux-arm-kernel@lists.infradead.org; Wed, 27 Nov 2024 08:03:43 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-7ae3d7222d4so5296425a12.3 for ; Wed, 27 Nov 2024 00:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732694621; x=1733299421; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; b=MTOFhguC2GAg/LACMfYZhoWQvUJMFjU45ryRMU4NaY3Z4F/dAhp/y3NNJExqVbV+SE mgoQ2WzXyt4vs0Ntq6AzqYnwGJhjEzB+/gjE+BrRTw5JYM+JgCit3vptZ0zrghHJkw1f pbW5ABJS3yk3MFP6VRjkmHAD+U+Om0JR+0j7r1kZ9YKG2DPElT/D9rEnfGSlhdWWv+4e 4uBnAYX5BHx6xVnl6WnPQFA9QPeUED+W34LTaIPcF9tM/p2aj57UGm52UAqLLkNNoHgi lOgqfgZFGxTrhm4gYORfzjCPyQJCIInQXz+sKO+1ftVk6StKKLMH3J5LzayUui63ilqq vJAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732694621; x=1733299421; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; b=rNV+0qPnFXtRMNyb1okGoulG6xtMOynHTrbvDI/MSY/qUsuuZGmc0EsPHwFXBFo7j0 e1ii+sVJmWv3HYtv0GjWjOG9e2yj7mHPSNWBULkGoBUUdrJa0DiVPj4ng+Bxzf24UMeG rJx5nvufeffRBBHk3v+MARD5gvytnXXabRPrYgvzs/z7mw07SB/Tavqeubxgsy4QLgaM mildfqlIlYJw5DL6djs1aRRV3bx7clplF3mDSQqZFD7gZghFA1Q5BepJjzjy4hhTnQ8q bKTAb/a7PvySKAqqFloHkeVhE1y3raeTW+XwntlL6JuOM9x9XR+weV7BEHp6bGPeoZ9p S2gw== X-Forwarded-Encrypted: i=1; AJvYcCUoSDzDjpSOho7iMynp3/2PMA3q0jothVsRCtLikR6enyChm9NJ6IGh8bJpL18+Onmg5bjfMm55J4/IklIdB/Ax@lists.infradead.org X-Gm-Message-State: AOJu0YzxLnGoiIYg7sxy2YpfuXAkxVzhSCJV7icW6dO5ZU5qIXGZXepC sawcTdnOJzV25ctZ68Mqa0d/CAamgSl+foBV47eeGxb+q272sh2G X-Gm-Gg: ASbGncsDLr57u98AlNpb0B+4c65HZXt9go3kBEurAxSjoxmKAzDpphE8Z+WdQZojIrZ It7zd6JzX1pZsUCzy7VuGYt3fOAmu54s8x8u3/72xCxOrrO+WTOR4005W0rnqIOsrC6XLoFTdf7 oTPPJkEBDG4BoZBZlo54reuITgsdvymjho5pvAQhKy/LzVmXN3t620jzG0qDrzdWVkpmVO0/G3l oqa1a1ts7YfElogZa+yuzlZkfUKKGzxuFkTR6k4LQcnTBIY2itmwT7XFE/pBJf7Q6BYty8kA5IF vFJPt6YUIIJUjncOSwoYX3m7IdSL X-Google-Smtp-Source: AGHT+IHRo3XtMbkGU/iUkrZZ9kDEO66Pm5yljji2WIQGTrvtOISCN9QXMkeyFyIaUUK12nAZ7FFb4Q== X-Received: by 2002:a05:6a21:3288:b0:1e0:d380:fe61 with SMTP id adf61e73a8af0-1e0e0b9dbf6mr3148053637.45.1732694621422; Wed, 27 Nov 2024 00:03:41 -0800 (PST) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de531308sm9618017b3a.110.2024.11.27.00.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 00:03:40 -0800 (PST) Message-ID: Date: Wed, 27 Nov 2024 16:03:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family To: Krzysztof Kozlowski , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mcoquelin.stm32@gmail.com, richardcochran@gmail.com Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com References: <20241118082707.8504-1-a0987203069@gmail.com> <20241118082707.8504-4-a0987203069@gmail.com> <7c132784-87db-44f9-8be4-a0805e438735@kernel.org> Content-Language: en-US From: Joey Lu In-Reply-To: <7c132784-87db-44f9-8be4-a0805e438735@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241127_000342_687319_CD4BC3F2 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Krzysztof Kozlowski 於 11/26/2024 6:10 PM 寫道: > On 18/11/2024 09:27, Joey Lu wrote: >> + >> +static struct nvt_priv_data * >> +nuvoton_gmac_setup(struct platform_device *pdev, struct plat_stmmacenet_data *plat) >> +{ >> + struct device *dev = &pdev->dev; >> + struct nvt_priv_data *bsp_priv; >> + phy_interface_t phy_mode; >> + u32 tx_delay, rx_delay; >> + u32 macid, arg, reg; >> + >> + bsp_priv = devm_kzalloc(dev, sizeof(*bsp_priv), GFP_KERNEL); >> + if (!bsp_priv) >> + return ERR_PTR(-ENOMEM); >> + >> + bsp_priv->regmap = >> + syscon_regmap_lookup_by_phandle_args(dev->of_node, "nuvoton,sys", 1, &macid); >> + if (IS_ERR(bsp_priv->regmap)) { >> + dev_err(dev, "Failed to get sys register\n"); > Syntax is: return dev_err_probe I will use dev_err_probe instead. > >> + return ERR_PTR(-ENODEV); >> + } >> + if (macid > 1) { >> + dev_err(dev, "Invalid sys arguments\n"); >> + return ERR_PTR(-EINVAL); >> + } >> + > > > ... > I will use dev_err_probe instead. >> + >> + ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); >> + if (ret) >> + return ret; >> + >> + /* We support WoL by magic packet, override pmt to make it work! */ >> + plat_dat->pmt = 1; >> + dev_info(&pdev->dev, "Wake-Up On Lan supported\n"); > > Drop, driver should be silent on success. Got it. > >> + device_set_wakeup_capable(&pdev->dev, 1); >> + >> + return 0; >> +} > > > Best regards, > Krzysztof Thanks! BR, Joey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90097D6D247 for ; Wed, 27 Nov 2024 22:53:10 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XzF8J1cJyz3dLN for ; Thu, 28 Nov 2024 09:52:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::530" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1732694626; cv=none; b=DUqc4z/2wIWVz87cDjrXusXrEdzauJYYgmLC+vIj0zYeN4h3ksaVyN3HgZ1UHDnxwex3zYoCiJHOIigu+OtDNQu+sSrQP+itbYQ7yvzssio4bkIGUeggOo8HRMdRXDOdAsZZW1pKceA4QTmdWHec54H83oSmCdj4hv5/3cu2pWcQf3v0QG8sUR+HGowelG08RkBHQO9uYNgTF9OE08+aX7NIe5ggQ6xHVIqVxnF1Mv54Vek1e56CKvAp80cnkmq4RTrCwI/pciavGmNTNUwOkN5DVlJpFdPtJvjn5J7hjF7Gss7LoXs3sObksxlvqfxMhVDhAGhTPHv/FTff0AVH7w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1732694626; c=relaxed/relaxed; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UaTUIceaZpGrjP9/dFvwU7DZb/T6/Qtzx8hemXdXIboEz4VcyWFqEzzfI3sWORpflxKKHkgGqL/CBxmmu41YW7ohRdtzPFyP2RpLr3+lpfXGoyGsi0gCkJdMfS5pYAV+fr3LNK6DKnO1H87HYiWAdNe2Zd/J8NnGM16YMpLXRLTwOmOqL2sY2m1DwgpB6gfJByBDAOX7gwq6Z+vbKMKAkw9IgyFHbMjVdfIpTK8K3JWx6p9mERgMDFrDrSjXdknlpCcoHcRDVGMLZDORXSB07s+OtRse7DQ9DdKFDHhdoqUBLhumSVoJG9I0TaRS/VmrEaVyw/paIjUKipyi4k2Fxg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=UGNGTPvG; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::530; helo=mail-pg1-x530.google.com; envelope-from=a0987203069@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=UGNGTPvG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::530; helo=mail-pg1-x530.google.com; envelope-from=a0987203069@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XysQS4ZqMz2xGw for ; Wed, 27 Nov 2024 19:03:44 +1100 (AEDT) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-7fbd70f79f2so4426838a12.2 for ; Wed, 27 Nov 2024 00:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732694621; x=1733299421; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; b=UGNGTPvGAzjpcvNVq+eryS+KyrhwVTDhYcMUCIhWCsH6Der76gL1xTphiDk8ugBn1z XhYxa4hS4TpUtKPmOlzoRovUu/yhNfoB+ZbkdwnfaCXSRfIHI9dHqHSm/l9OZcxkm6ft OLcMeRjkytpE65oSPVAm8S7c/s7U/JCFdqD1jTouC1OONHbZrQopsqGTWD0kHmx1nM7c 3dXmpd1Jj6IDRAKCVWxpTfAq5ozRfBn7h9JQYaK2Uhs09kudBPSp5vZNALssJIIxsfdm eTt9CpAliUkhGN3gU/MU7R9bPTF994cA9kHSDRyU8Ld4UdnWjAtjzeXOVFjDDZqgMMPt M54g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732694621; x=1733299421; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HvstvQGGZWpwukBxOMgySPouyXZH3tEoacDeqR0VV4A=; b=poSXMc5NyY0darIyjpMLMMyUHvnh/JGetgqiULwNgM+3zqy/00UGPSHOqc9WYBoxyx gaIKL3MqRrdYW0Hm/Evrl0KrFbOr+EpjQCoVbWfoZRHtl6EcmBVbU/rMe4FKMqNyp7XM M/4eozOkIsWHkio7ZEbYIzum09xClETzIG8br9SqQAYtUoxZ88wKwjgTqwNpYj+14enk LbNB48oKv0ZafTcODW8RroXWYr4jTwprYNS/9WF62V6HBrYbxQOjKGB5ZROwypUiqJiV QOoyxBrU5wgBCDsWhhy5KEghnWeJTy/dd7luOYT+8oKmLkNCRXHW5nBBNip5Fw2ArhDS ee/g== X-Forwarded-Encrypted: i=1; AJvYcCW3M26M4svcl+AwCz/uSi6lLkeTIzeA2PShXBTE1D2qIZn9vi99/l8Tr6R0EwuKfTYgsBRfe8Hl@lists.ozlabs.org X-Gm-Message-State: AOJu0YzwHbS+LBfK86iQHv9nBcyjk2mdvS2UIgwHWznAu8+zf7KO7Ple wW0R6XPcWKwVVOgKlx9Mv7uRBcoXJhsKVqqp+o25lnGUqx+CMkIO X-Gm-Gg: ASbGncv+u+YQEw12T6htSWed41zRioF47FmQGc9EFc7miGkBpTYH0BnRuCjCH60lVq7 WXqbJ9/8+HEh/vTXWAPQvvovlmKTsvCshNWmc2R6c45AqEcw1W/77AXvzYPzR8BjE2+kTrt4of8 TcEAFMWDaUkEHn/k4/2jtiFc8anFmU5U7PBVvmOfwCUijDVipuI2Jl80wip77Kq4GnflInhfaTY YMEr8iaMjoDJONFa0im2cDRidn2YwnlHHSRPoz30gi4rjpT4EblOJTBvMUetbQOqkO7FDDtaLMU VXOUG3n07C6ED8y3w3k1gBBh50AF X-Google-Smtp-Source: AGHT+IHRo3XtMbkGU/iUkrZZ9kDEO66Pm5yljji2WIQGTrvtOISCN9QXMkeyFyIaUUK12nAZ7FFb4Q== X-Received: by 2002:a05:6a21:3288:b0:1e0:d380:fe61 with SMTP id adf61e73a8af0-1e0e0b9dbf6mr3148053637.45.1732694621422; Wed, 27 Nov 2024 00:03:41 -0800 (PST) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de531308sm9618017b3a.110.2024.11.27.00.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 00:03:40 -0800 (PST) Message-ID: Date: Wed, 27 Nov 2024 16:03:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family To: Krzysztof Kozlowski , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mcoquelin.stm32@gmail.com, richardcochran@gmail.com References: <20241118082707.8504-1-a0987203069@gmail.com> <20241118082707.8504-4-a0987203069@gmail.com> <7c132784-87db-44f9-8be4-a0805e438735@kernel.org> Content-Language: en-US From: Joey Lu In-Reply-To: <7c132784-87db-44f9-8be4-a0805e438735@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 28 Nov 2024 09:52:40 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ychuang3@nuvoton.com, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org, joabreu@synopsys.com, schung@nuvoton.com, peppe.cavallaro@st.com, yclu4@nuvoton.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Krzysztof Kozlowski 於 11/26/2024 6:10 PM 寫道: > On 18/11/2024 09:27, Joey Lu wrote: >> + >> +static struct nvt_priv_data * >> +nuvoton_gmac_setup(struct platform_device *pdev, struct plat_stmmacenet_data *plat) >> +{ >> + struct device *dev = &pdev->dev; >> + struct nvt_priv_data *bsp_priv; >> + phy_interface_t phy_mode; >> + u32 tx_delay, rx_delay; >> + u32 macid, arg, reg; >> + >> + bsp_priv = devm_kzalloc(dev, sizeof(*bsp_priv), GFP_KERNEL); >> + if (!bsp_priv) >> + return ERR_PTR(-ENOMEM); >> + >> + bsp_priv->regmap = >> + syscon_regmap_lookup_by_phandle_args(dev->of_node, "nuvoton,sys", 1, &macid); >> + if (IS_ERR(bsp_priv->regmap)) { >> + dev_err(dev, "Failed to get sys register\n"); > Syntax is: return dev_err_probe I will use dev_err_probe instead. > >> + return ERR_PTR(-ENODEV); >> + } >> + if (macid > 1) { >> + dev_err(dev, "Invalid sys arguments\n"); >> + return ERR_PTR(-EINVAL); >> + } >> + > > > ... > I will use dev_err_probe instead. >> + >> + ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); >> + if (ret) >> + return ret; >> + >> + /* We support WoL by magic packet, override pmt to make it work! */ >> + plat_dat->pmt = 1; >> + dev_info(&pdev->dev, "Wake-Up On Lan supported\n"); > > Drop, driver should be silent on success. Got it. > >> + device_set_wakeup_capable(&pdev->dev, 1); >> + >> + return 0; >> +} > > > Best regards, > Krzysztof Thanks! BR, Joey