From: Pavel Begunkov <asml.silence@gmail.com>
To: David Wei <dw@davidwei.uk>,
io-uring@vger.kernel.org, netdev@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v1 7/7] io_uring/zcrx: reverse ifq refcount
Date: Thu, 6 Nov 2025 11:20:59 +0000 [thread overview]
Message-ID: <fb68c19d-d3dd-45c4-a460-589fd246db5f@gmail.com> (raw)
In-Reply-To: <20251104224458.1683606-8-dw@davidwei.uk>
On 11/4/25 22:44, David Wei wrote:
> Add a refcount to struct io_zcrx_ifq to reverse the refcounting
> relationship i.e. rings now reference ifqs instead. As a result of this,
> remove ctx->refs that an ifq holds on a ring via the page pool memory
> provider.
>
> This ref ifq->refs is held by internal users of an ifq, namely rings and
> the page pool memory provider associated with an ifq. This is needed to
> keep the ifq around until the page pool is destroyed.
>
> Since ifqs now no longer hold refs to ring ctx, there isn't a need to
> split the cleanup of ifqs into two: io_shutdown_zcrx_ifqs() in
> io_ring_exit_work() while waiting for ctx->refs to drop to 0, and
> io_unregister_zcrx_ifqs() after. Remove io_shutdown_zcrx_ifqs().
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
--
Pavel Begunkov
next prev parent reply other threads:[~2025-11-06 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 22:44 [PATCH v1 0/7] reverse ifq refcount David Wei
2025-11-04 22:44 ` [PATCH v1 1/7] io_uring/memmap: remove unneeded io_ring_ctx arg David Wei
2025-11-06 11:15 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 2/7] io_uring/memmap: refactor io_free_region() to take user_struct param David Wei
2025-11-06 11:16 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 3/7] io_uring/rsrc: refactor io_{un}account_mem() to take {user,mm}_struct param David Wei
2025-11-06 11:17 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 4/7] io_uring/zcrx: add io_zcrx_ifq arg to io_zcrx_free_area() David Wei
2025-11-06 11:18 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 5/7] io_uring/zcrx: add user_struct and mm_struct to io_zcrx_ifq David Wei
2025-11-06 11:19 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 6/7] io_uring/zcrx: move io_unregister_zcrx_ifqs() down David Wei
2025-11-06 11:20 ` Pavel Begunkov
2025-11-04 22:44 ` [PATCH v1 7/7] io_uring/zcrx: reverse ifq refcount David Wei
2025-11-06 11:20 ` Pavel Begunkov [this message]
2025-11-06 16:10 ` [PATCH v1 0/7] " Pavel Begunkov
2025-11-06 23:21 ` Jens Axboe
2025-11-06 23:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb68c19d-d3dd-45c4-a460-589fd246db5f@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.