All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Ishani Chugh <chugh.ishani@research.iiit.ac.in>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README
Date: Fri, 21 Jul 2017 07:16:34 -0500	[thread overview]
Message-ID: <fb720b66-8b5f-bd84-2cb6-aa7d7d14b2db@redhat.com> (raw)
In-Reply-To: <20170721093416.17816-1-stefanha@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote:
> There is not much getting started documentation for qemu-iotests.  This
> patch explains how to create a new test and covers the overall testing
> approach.
> 
> Cc: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---

> +3. Assign groups to the test
> +
> +Add your test to the ./group file.  This file is the index of tests and assigns
> +them to functional groups like "rw" for read-write tests.  Most tests belong to
> +the "rw" and "auto" groups.  "auto" means the test runs when ./check is invoked
> +without a -g argument.
> +
> +Consider adding your test to the "quick" group if it executes quickly (<1s).

We have several tests going up to 5s (and I have a patch pending to
remove two tests that took longer) - I think 1s is a bit on the short
end for still classifying a test as quick.

> +This group is run by "make check-block" and is often included as part of build
> +tests in continuous integration systems.

It would still be nice to have 'make check' run 'make check-block'...
but that's independent of this patch.

> +Once you are happy with the test output it can be used as the golden master
> +with "mv <test-number>.out.bad <test-number>.out".  Rerun the test to verify
> +that it passes.
> +
> +Congratulations, you've created a new test!

Maybe a reminder to 'git add' the new files, then submit the patch?

Better than what we have, so whether or not you make further tweaks
according to my suggestions,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

  reply	other threads:[~2017-07-21 12:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  9:34 [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README Stefan Hajnoczi
2017-07-21 12:16 ` Eric Blake [this message]
2017-07-21 15:51   ` Stefan Hajnoczi
2017-07-23 14:18     ` Philippe Mathieu-Daudé
2017-07-24 10:06       ` Stefan Hajnoczi
2017-07-24 21:50     ` [Qemu-devel] [Qemu-block] " John Snow
2017-07-22  9:03 ` Manos Pitsidianakis
2017-07-24  9:11 ` [Qemu-devel] " Kevin Wolf
2017-07-25 15:22   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-24 10:20 ` [Qemu-devel] " Peter Maydell
2017-07-25 15:20   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-25 15:34     ` Peter Maydell
2017-07-26 11:33       ` Stefan Hajnoczi
2017-07-26 11:50         ` Peter Maydell
2017-07-24 14:28 ` [Qemu-devel] " Eric Blake
2017-07-24 14:33   ` Kevin Wolf
2017-07-24 14:34   ` Peter Maydell
2017-07-24 14:41     ` Eric Blake
2017-07-26 18:42 ` [Qemu-devel] [Qemu-block] " Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb720b66-8b5f-bd84-2cb6-aa7d7d14b2db@redhat.com \
    --to=eblake@redhat.com \
    --cc=chugh.ishani@research.iiit.ac.in \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.