From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AE7DC35FFF for ; Fri, 21 Mar 2025 09:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iWnR5bCtS2OFl6qMZ2T0dze3z5cvO0emTkA11CaAm0I=; b=HdPzKJPHE+rxcqill9xi5xBx1/ t4zGTOICuuoAIsI1hJufNv85vMzHgsHnScSyotv7N90t1yRr1Ms0FcUXAuGaE/OKn+D438mTU3T0W 9x2HqK3+a6pWTe73t6i0Lp/bjeGqibNx3JFsl2ri7SGoebiSOHJXUP5vxoy0s1Tg0AgdPz2RRFOkX x00I1X25+m9R+i8bCPBqHOpUyyOizyo1EIUCwUQf/mCND4yLj8reWFKentmfwfgRk/f5sBXBTRrfh dGyIBnMBRs9AdtBV//ibBd2EBFA+8n4kveKWmlkMGMVjaJaDWM4DceiulL57B+IWPv7N/rQURrhuJ 0gPppjNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvYZH-0000000EM04-0zUi; Fri, 21 Mar 2025 09:21:31 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvYXZ-0000000ELoY-3u4W for linux-arm-kernel@lists.infradead.org; Fri, 21 Mar 2025 09:19:48 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso7970015e9.3 for ; Fri, 21 Mar 2025 02:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1742548784; x=1743153584; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iWnR5bCtS2OFl6qMZ2T0dze3z5cvO0emTkA11CaAm0I=; b=tmcLyIn85/VkIeIhfpvZoRL2Q7lo7l3+HHwBEcDmh8EPYvbnvfo7G3/Ssp56vBXmwE NHnXtgBdUy+yt5aOMgrr4F99I29wnp7mVL5CXCOGd0URXW/FCzSzmeDiZATqcao2CDHG ys9VGogMx/QyOiVKDn/XADzkl4kjicrH8Q221OYigIe7mvLqdUicMrzSmq1qKr7R3Xaz JwpulB8UY251jkXo90dCXnwnIzH9cdfhJJ0Ww3v/kQpOpagRx+pKXXBMxe3muK3UAC3d TLDtCc8AsSC947ItEXMc+H7PQ3HXvbha3siJNdx2slWzg2WFewnEguEdRVPSsuSlWT4K QUBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742548784; x=1743153584; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iWnR5bCtS2OFl6qMZ2T0dze3z5cvO0emTkA11CaAm0I=; b=N7YTQn5otubvLImjbjAQ7E/BFTf+JurErQARNXknYrcEAeGNvneZEXPxFWG+Zz2w36 LDR9+CcW6bSJ2TkHnPmtp9FoGIHWeJ7S3r05vqj69uahQbngRFPRmK9ssA5W7UpQLjss v8JwpuPBh3Z1DDnooYLxuQEhVyYF5kXQR5L/zWlrZQbhrUAm71ay5J17RIvrCjdHa1xH l4VtRrH3u8aC7hqBkK7JnetXMmYwDD4HxdLztXaZLN9RwQ9goLxwt+RExcwc8WFmNXMB EhuyzjLgZy2qWKl+V+Vc8VXeaiBrJzoLFSynMLIj1d4w3O5ICn+yiQKOZyXWGKOQShFX 9YVg== X-Gm-Message-State: AOJu0YzVjUL0t4tNvfEVz98sUMp2wZ/9ZQnI4cAekvGsMGUSiYJJkgQn Ap9tph+vAoKr5T/G2+D+pM8YSWH8dHpGARQEZF6ah+nbfeiOcMnpopp7eDd6twQ= X-Gm-Gg: ASbGncvv1EACW1OpWXcb99cFoS6VxxYgAIdcXevqJDa+vKALT9feBhD43eFZH78ogHj 75ITSkzeCAhhBPWm4kgnHact8gh11jrzf4OIO3dxOBO8Gl48QkNyFI2bGQKJq7TdC7Qv8JYb0wG JFC7QklTHfRaUviQlFNtZWj8N+XtmDzOwiecaYKcVQlxU2E1Gk9ySiGpcfCzFLx027RNy1AdJW/ QVmuOyns/B1qwp2AdiDgPR+R+8GDR1ZPb5fZRL0uCEl/7UpSOXRXCnC03rWuCwQvD53q52cg0m6 BudTv/bl7hn6bqyKzdjSa3azwMpxDTOXhb9NepqdIi7RuchxM0W6V0xk2GyfC68QIpyWANw2y1d pt2VTuyGObLtKnqKN X-Google-Smtp-Source: AGHT+IGb4qaiD8zveCmbngoPFmfN9WpLcjDxkx7ItZuEiKJ1uCoRacXpzZp0WPeOAWRPRphRbr45pg== X-Received: by 2002:a05:600c:1e18:b0:43c:eea9:f45d with SMTP id 5b1f17b1804b1-43d509f64b8mr23766545e9.18.1742548783913; Fri, 21 Mar 2025 02:19:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:5ee:79d0:2756:9ecd:3e82:43c7? ([2a01:e0a:5ee:79d0:2756:9ecd:3e82:43c7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fceae03sm21916245e9.8.2025.03.21.02.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 02:19:43 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2025 10:19:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/3] drm/panel: startek-kd070fhfid015: add another init step To: AngeloGioacchino Del Regno , Catalin Marinas , Will Deacon , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org References: <20231023-display-support-v8-0-c2dd7b0fb2bd@baylibre.com> <20231023-display-support-v8-2-c2dd7b0fb2bd@baylibre.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250321_021946_206174_CE9C5B56 X-CRM114-Status: GOOD ( 28.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, Thanks for the fast feedback :) On 20/03/2025 13:37, AngeloGioacchino Del Regno wrote: > Il 20/03/25 09:48, Alexandre Mergnat ha scritto: >> Currently, the panel set power, set gpio and enable the display link >> in stk_panel_prepare, pointed by drm_panel_funcs.prepare, called by >> panel_bridge_atomic_pre_enable, pointed by >> drm_bridge_funcs.atomic_pre_enable. According to the drm_bridge.h, >> atomic_pre_enable must not enable the display link >> >> Since the DSI driver is properly inited by the DRM, the panel try to >> communicate with the panel before DSI is powered on. >> > > The panel driver shall still be able to send commands in the .prepare() callback > and if this is not happening anymore... well, there's a problem! Sorry I don't think so, according to that def: /** * @pre_enable: * * This callback should enable the bridge. It is called right before * the preceding element in the display pipe is enabled. If the * preceding element is a bridge this means it's called before that * bridge's @pre_enable function. If the preceding element is a * &drm_encoder it's called right before the encoder's * &drm_encoder_helper_funcs.enable, &drm_encoder_helper_funcs.commit or * &drm_encoder_helper_funcs.dpms hook. * * The display pipe (i.e. clocks and timing signals) feeding this bridge * will not yet be running when this callback is called. The bridge must * not enable the display link feeding the next bridge in the chain (if * there is one) when this callback is called. * * The @pre_enable callback is optional. * * NOTE: * * This is deprecated, do not use! * New drivers shall use &drm_bridge_funcs.atomic_pre_enable. */ void (*pre_enable)(struct drm_bridge *bridge); /** * @enable: * * This callback should enable the bridge. It is called right after * the preceding element in the display pipe is enabled. If the * preceding element is a bridge this means it's called after that * bridge's @enable function. If the preceding element is a * &drm_encoder it's called right after the encoder's * &drm_encoder_helper_funcs.enable, &drm_encoder_helper_funcs.commit or * &drm_encoder_helper_funcs.dpms hook. * * The bridge can assume that the display pipe (i.e. clocks and timing * signals) feeding it is running when this callback is called. This * callback must enable the display link feeding the next bridge in the * chain if there is one. * * The @enable callback is optional. * * NOTE: * * This is deprecated, do not use! * New drivers shall use &drm_bridge_funcs.atomic_enable. */ void (*enable)(struct drm_bridge *bridge); => "The bridge must not enable the display link feeding the next bridge in the => chain (if there is one) when this callback is called." Additionally, you ask for something impossible because here is the init order fixed by the framework: [ 10.753139] panel_bridge_atomic_pre_enable [ 10.963505] mtk_dsi_bridge_atomic_pre_enable [ 10.963518] mtk_dsi_bridge_atomic_enable [ 10.963527] panel_bridge_atomic_enable [ 10.963532] drm_panel_enable If panel want to use the DSI link in panel_bridge_atomic_pre_enable, nothing will happen and you will get a timeout. So, IMHO, this patch make sense. > >> To solve that, use stk_panel_enable to enable the display link because >> it's called after the mtk_dsi_bridge_atomic_pre_enable which is power >> on the DSI. >> >> Signed-off-by: Alexandre Mergnat >> --- >>   .../gpu/drm/panel/panel-startek-kd070fhfid015.c    | 25 +++++++++++++--------- >>   1 file changed, 15 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c >> b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c >> index c0c95355b7435..bc3c4038bf4f5 100644 >> --- a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c >> +++ b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c >> @@ -135,19 +135,9 @@ static int stk_panel_prepare(struct drm_panel *panel) >>       gpiod_set_value(stk->enable_gpio, 1); >>       mdelay(20); >>       gpiod_set_value(stk->reset_gpio, 1); >> -    mdelay(10); >> -    ret = stk_panel_init(stk); >> -    if (ret < 0) >> -        goto poweroff; > > Also, you're moving both init and set_display_on to the enable callback... > this is suboptimal. > > You should do the DrIC setup in .prepare() (can include SLEEP OUT), and then you > should have a .enable() callback that calls DISP ON, a .disable() callback that > calls DISP OFF, and .unprepare() that turns everything off. This is not what I understand from the pre_enable's definition above, and also the function call order by the framework. :) > > Cheers, > Angelo > >> - >> -    ret = stk_panel_on(stk); >> -    if (ret < 0) >> -        goto poweroff; >>       return 0; >> -poweroff: >> -    regulator_disable(stk->supplies[POWER].consumer); >>   iovccoff: >>       regulator_disable(stk->supplies[IOVCC].consumer); >>       gpiod_set_value(stk->reset_gpio, 0); >> @@ -156,6 +146,20 @@ static int stk_panel_prepare(struct drm_panel *panel) >>       return ret; >>   } >> +static int stk_panel_enable(struct drm_panel *panel) >> +{ >> +    struct stk_panel *stk = to_stk_panel(panel); >> +    int ret; >> + >> +    ret = stk_panel_init(stk); >> +    if (ret < 0) >> +        return ret; >> + >> +    ret = stk_panel_on(stk); >> + >> +    return ret; >> +} >> + >>   static const struct drm_display_mode default_mode = { >>           .clock = 163204, >>           .hdisplay = 1200, >> @@ -239,6 +243,7 @@ drm_panel_create_dsi_backlight(struct mipi_dsi_device *dsi) >>   } >>   static const struct drm_panel_funcs stk_panel_funcs = { >> +    .enable = stk_panel_enable, >>       .unprepare = stk_panel_unprepare, >>       .prepare = stk_panel_prepare, >>       .get_modes = stk_panel_get_modes, >> > > > -- Regards, Alexandre