From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jammy Huang Date: Mon, 25 Oct 2021 18:06:57 +0800 Subject: [PATCH v2] media: aspeed: add debugfs In-Reply-To: References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Dear Greg, Yes, you are right. I will update accordingly. On 2021/10/25 ?? 03:59, Greg KH wrote: > On Wed, Sep 29, 2021 at 05:00:25PM +0800, Jammy Huang wrote: >> To show video real-time information as below: >> >> Caputre: >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 >> >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); > This check will never happen, why are you making it? > > There's no need to care if debugfs works or not, just create the file > and move on. This function should not return anything. > >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); > As proof of this, you don't care if this doesn't work, you just print > out a message that was already printed out :( > > thanks, > > greg k-h -- -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2CCC433FE for ; Mon, 25 Oct 2021 10:08:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 267F660240 for ; Mon, 25 Oct 2021 10:08:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 267F660240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hd9cy4hRcz2yfr for ; Mon, 25 Oct 2021 21:08:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jammy_huang@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hd9cR1cRtz2xCx; Mon, 25 Oct 2021 21:07:33 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9idqG002949; Mon, 25 Oct 2021 17:44:39 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:06:57 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:06:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Greg KH References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9idqG002949 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , "linux-aspeed@lists.ozlabs.org" , "andrew@aj.id.au" , "openbmc@lists.ozlabs.org" , "eajames@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Greg, Yes, you are right. I will update accordingly. On 2021/10/25 下午 03:59, Greg KH wrote: > On Wed, Sep 29, 2021 at 05:00:25PM +0800, Jammy Huang wrote: >> To show video real-time information as below: >> >> Caputre: >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 >> >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); > This check will never happen, why are you making it? > > There's no need to care if debugfs works or not, just create the file > and move on. This function should not return anything. > >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); > As proof of this, you don't care if this doesn't work, you just print > out a message that was already printed out :( > > thanks, > > greg k-h -- -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434BEC433FE for ; Mon, 25 Oct 2021 10:09:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13A1C61029 for ; Mon, 25 Oct 2021 10:09:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 13A1C61029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rTjeHbGRPVoonE/CiGTM0j2k6BHWlElOfVMGVQq2FAg=; b=t+gfIADd54ElO4 MuJxnT0lulKykW/fwGWSpah1hPEq1fVsXQDsyqderKZYqx/QYvP5gDGWu6tXFudgFTmm45aV4Y+7E DGqucWQWjfn7Vz8oZltuoSY2nXaVBe/TQsrh9sxIIc96u0blQLY27a68sAFr/eX5Wo5V67S1Ui7sT waHky5igDkw8Y8d5zJHFzyxr9NqdhGVqWa5n9eGbU9wYcHivkCq7d+I17YCriVEAH/4YIcsKQARUk O2xwhNNJ1TeEbbsVhoewPCVij4+AeWCUUbWfZ9KN30zZrcroua9EDzeXGQX2y3PY9s2hoEbxiBqLC tzuo87RBsSC2WjJqFEnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewt6-00G3EB-1s; Mon, 25 Oct 2021 10:07:28 +0000 Received: from twspam01.aspeedtech.com ([211.20.114.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewt1-00G3DF-7D for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 10:07:25 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9idqG002949; Mon, 25 Oct 2021 17:44:39 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:06:57 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:06:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Greg KH CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9idqG002949 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_030723_552954_0163FBB6 X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RGVhciBHcmVnLAoKWWVzLCB5b3UgYXJlIHJpZ2h0LiBJIHdpbGwgdXBkYXRlIGFjY29yZGluZ2x5 LgoKCk9uIDIwMjEvMTAvMjUg5LiL5Y2IIDAzOjU5LCBHcmVnIEtIIHdyb3RlOgo+IE9uIFdlZCwg U2VwIDI5LCAyMDIxIGF0IDA1OjAwOjI1UE0gKzA4MDAsIEphbW15IEh1YW5nIHdyb3RlOgo+PiBU byBzaG93IHZpZGVvIHJlYWwtdGltZSBpbmZvcm1hdGlvbiBhcyBiZWxvdzoKPj4KPj4gQ2FwdXRy ZToKPj4gICAgU2lnbmFsICAgICAgICAgICAgICA6IFVubG9jawo+PiAgICBXaWR0aCAgICAgICAg ICAgICAgIDogMTkyMAo+PiAgICBIZWlnaHQgICAgICAgICAgICAgIDogMTA4MAo+PiAgICBGUkMg ICAgICAgICAgICAgICAgIDogMzAKPj4KPj4gUGVyZm9ybWFuY2U6Cj4+ICAgIEZyYW1lIyAgICAg ICAgICAgICAgOiAwCj4+ICAgIEZyYW1lIER1cmF0aW9uICAgICAgOgo+PiAgICAgIE5vdyAgICAg ICAgICAgICAgIDogMAo+PiAgICAgIE1pbiAgICAgICAgICAgICAgIDogMAo+PiAgICAgIE1heCAg ICAgICAgICAgICAgIDogMAo+PiAgICBGUFMobXMpICAgICAgICAgICAgIDogMAo+Pgo+PiBDaGFu Z2UtSWQ6IEk0ODM3NDBjNGRmNmRiMDdhOTI2MWMxODQ0MDQ3MmEwMzU2NTEyYmI3Cj4+IFNpZ25l ZC1vZmYtYnk6IEphbW15IEh1YW5nIDxqYW1teV9odWFuZ0Bhc3BlZWR0ZWNoLmNvbT4KPj4gLS0t Cj4+ICAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9hc3BlZWQtdmlkZW8uYyB8IDEwMSArKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMDEgaW5zZXJ0aW9ucygr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9hc3BlZWQtdmlkZW8u YyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXNwZWVkLXZpZGVvLmMKPj4gaW5kZXggOGIzOTM5 YjgwNTJkLi5jNWM0MTM4NDQ0NDEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vYXNwZWVkLXZpZGVvLmMKPj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9hc3BlZWQt dmlkZW8uYwo+PiBAQCAtMjEsNiArMjEsOCBAQAo+PiAgICNpbmNsdWRlIDxsaW51eC92aWRlb2Rl djIuaD4KPj4gICAjaW5jbHVkZSA8bGludXgvd2FpdC5oPgo+PiAgICNpbmNsdWRlIDxsaW51eC93 b3JrcXVldWUuaD4KPj4gKyNpbmNsdWRlIDxsaW51eC9kZWJ1Z2ZzLmg+Cj4+ICsjaW5jbHVkZSA8 bGludXgva3RpbWUuaD4KPj4gICAjaW5jbHVkZSA8bWVkaWEvdjRsMi1jdHJscy5oPgo+PiAgICNp bmNsdWRlIDxtZWRpYS92NGwyLWRldi5oPgo+PiAgICNpbmNsdWRlIDxtZWRpYS92NGwyLWRldmlj ZS5oPgo+PiBAQCAtMjAzLDYgKzIwNSwxNCBAQCBzdHJ1Y3QgYXNwZWVkX3ZpZGVvX2J1ZmZlciB7 Cj4+ICAgCXN0cnVjdCBsaXN0X2hlYWQgbGluazsKPj4gICB9Owo+PiAgIAo+PiArc3RydWN0IGFz cGVlZF92aWRlb19wZXJmIHsKPj4gKwlrdGltZV90IGxhc3Rfc2FtcGxlOwo+PiArCXUzMiB0b3Rh bHRpbWU7Cj4+ICsJdTMyIGR1cmF0aW9uOwo+PiArCXUzMiBkdXJhdGlvbl9taW47Cj4+ICsJdTMy IGR1cmF0aW9uX21heDsKPj4gK307Cj4+ICsKPj4gICAjZGVmaW5lIHRvX2FzcGVlZF92aWRlb19i dWZmZXIoeCkgXAo+PiAgIAljb250YWluZXJfb2YoKHgpLCBzdHJ1Y3QgYXNwZWVkX3ZpZGVvX2J1 ZmZlciwgdmIpCj4+ICAgCj4+IEBAIC0yNDEsNiArMjUxLDggQEAgc3RydWN0IGFzcGVlZF92aWRl byB7Cj4+ICAgCXVuc2lnbmVkIGludCBmcmFtZV9sZWZ0Owo+PiAgIAl1bnNpZ25lZCBpbnQgZnJh bWVfcmlnaHQ7Cj4+ICAgCXVuc2lnbmVkIGludCBmcmFtZV90b3A7Cj4+ICsKPj4gKwlzdHJ1Y3Qg YXNwZWVkX3ZpZGVvX3BlcmYgcGVyZjsKPj4gICB9Owo+PiAgIAo+PiAgICNkZWZpbmUgdG9fYXNw ZWVkX3ZpZGVvKHgpIGNvbnRhaW5lcl9vZigoeCksIHN0cnVjdCBhc3BlZWRfdmlkZW8sIHY0bDJf ZGV2KQo+PiBAQCAtNDQ0LDYgKzQ1NiwxNiBAQCBzdGF0aWMgdm9pZCBhc3BlZWRfdmlkZW9fd3Jp dGUoc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8sIHUzMiByZWcsIHUzMiB2YWwpCj4+ICAgCQly ZWFkbCh2aWRlby0+YmFzZSArIHJlZykpOwo+PiAgIH0KPj4gICAKPj4gK3N0YXRpYyB2b2lkIHVw ZGF0ZV9wZXJmKHN0cnVjdCBhc3BlZWRfdmlkZW9fcGVyZiAqcCkKPj4gK3sKPj4gKwlwLT5kdXJh dGlvbiA9Cj4+ICsJCWt0aW1lX3RvX21zKGt0aW1lX3N1YihrdGltZV9nZXQoKSwgIHAtPmxhc3Rf c2FtcGxlKSk7Cj4+ICsJcC0+dG90YWx0aW1lICs9IHAtPmR1cmF0aW9uOwo+PiArCj4+ICsJcC0+ ZHVyYXRpb25fbWF4ID0gbWF4KHAtPmR1cmF0aW9uLCBwLT5kdXJhdGlvbl9tYXgpOwo+PiArCXAt PmR1cmF0aW9uX21pbiA9IG1pbihwLT5kdXJhdGlvbiwgcC0+ZHVyYXRpb25fbWluKTsKPj4gK30K Pj4gKwo+PiAgIHN0YXRpYyBpbnQgYXNwZWVkX3ZpZGVvX3N0YXJ0X2ZyYW1lKHN0cnVjdCBhc3Bl ZWRfdmlkZW8gKnZpZGVvKQo+PiAgIHsKPj4gICAJZG1hX2FkZHJfdCBhZGRyOwo+PiBAQCAtNDgy LDYgKzUwNCw4IEBAIHN0YXRpYyBpbnQgYXNwZWVkX3ZpZGVvX3N0YXJ0X2ZyYW1lKHN0cnVjdCBh c3BlZWRfdmlkZW8gKnZpZGVvKQo+PiAgIAlhc3BlZWRfdmlkZW9fdXBkYXRlKHZpZGVvLCBWRV9J TlRFUlJVUFRfQ1RSTCwgMCwKPj4gICAJCQkgICAgVkVfSU5URVJSVVBUX0NPTVBfQ09NUExFVEUp Owo+PiAgIAo+PiArCXZpZGVvLT5wZXJmLmxhc3Rfc2FtcGxlID0ga3RpbWVfZ2V0KCk7Cj4+ICsK Pj4gICAJYXNwZWVkX3ZpZGVvX3VwZGF0ZSh2aWRlbywgVkVfU0VRX0NUUkwsIDAsCj4+ICAgCQkJ ICAgIFZFX1NFUV9DVFJMX1RSSUdfQ0FQVFVSRSB8IFZFX1NFUV9DVFJMX1RSSUdfQ09NUCk7Cj4+ ICAgCj4+IEBAIC02MDAsNiArNjI0LDggQEAgc3RhdGljIGlycXJldHVybl90IGFzcGVlZF92aWRl b19pcnEoaW50IGlycSwgdm9pZCAqYXJnKQo+PiAgIAkJdTMyIGZyYW1lX3NpemUgPSBhc3BlZWRf dmlkZW9fcmVhZCh2aWRlbywKPj4gICAJCQkJCQkgICBWRV9KUEVHX0NPTVBfU0laRV9SRUFEX0JB Q0spOwo+PiAgIAo+PiArCQl1cGRhdGVfcGVyZigmdmlkZW8tPnBlcmYpOwo+PiArCj4+ICAgCQlz cGluX2xvY2soJnZpZGVvLT5sb2NrKTsKPj4gICAJCWNsZWFyX2JpdChWSURFT19GUkFNRV9JTlBS RywgJnZpZGVvLT5mbGFncyk7Cj4+ICAgCQlidWYgPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwo JnZpZGVvLT5idWZmZXJzLAo+PiBAQCAtNzYwLDYgKzc4Niw3IEBAIHN0YXRpYyB2b2lkIGFzcGVl ZF92aWRlb19nZXRfcmVzb2x1dGlvbihzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbykKPj4gICAJ ZGV0LT53aWR0aCA9IE1JTl9XSURUSDsKPj4gICAJZGV0LT5oZWlnaHQgPSBNSU5fSEVJR0hUOwo+ PiAgIAl2aWRlby0+djRsMl9pbnB1dF9zdGF0dXMgPSBWNEwyX0lOX1NUX05PX1NJR05BTDsKPj4g KwltZW1zZXQoJnZpZGVvLT5wZXJmLCAwLCBzaXplb2YodmlkZW8tPnBlcmYpKTsKPj4gICAKPj4g ICAJZG8gewo+PiAgIAkJaWYgKHRyaWVzKSB7Cj4+IEBAIC0xNDUwLDYgKzE0NzcsOCBAQCBzdGF0 aWMgaW50IGFzcGVlZF92aWRlb19zdGFydF9zdHJlYW1pbmcoc3RydWN0IHZiMl9xdWV1ZSAqcSwK Pj4gICAJc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8gPSB2YjJfZ2V0X2Rydl9wcml2KHEpOwo+ PiAgIAo+PiAgIAl2aWRlby0+c2VxdWVuY2UgPSAwOwo+PiArCXZpZGVvLT5wZXJmLmR1cmF0aW9u X21heCA9IDA7Cj4+ICsJdmlkZW8tPnBlcmYuZHVyYXRpb25fbWluID0gMHhmZmZmZmZmZjsKPj4g ICAKPj4gICAJcmMgPSBhc3BlZWRfdmlkZW9fc3RhcnRfZnJhbWUodmlkZW8pOwo+PiAgIAlpZiAo cmMpIHsKPj4gQEAgLTE1MTcsNiArMTU0Niw3MiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHZiMl9v cHMgYXNwZWVkX3ZpZGVvX3ZiMl9vcHMgPSB7Cj4+ICAgCS5idWZfcXVldWUgPSAgYXNwZWVkX3Zp ZGVvX2J1Zl9xdWV1ZSwKPj4gICB9Owo+PiAgIAo+PiArI2lmZGVmIENPTkZJR19ERUJVR19GUwo+ PiArc3RhdGljIGludCBhc3BlZWRfdmlkZW9fZGVidWdmc19zaG93KHN0cnVjdCBzZXFfZmlsZSAq cywgdm9pZCAqZGF0YSkKPj4gK3sKPj4gKwlzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2ID0gcy0+cHJp dmF0ZTsKPj4gKwo+PiArCXNlcV9wdXRzKHMsICJcbiIpOwo+PiArCj4+ICsJc2VxX3ByaW50Zihz LCAiICAlLTIwczpcdCVzXG4iLCAiU2lnbmFsIiwKPj4gKwkJICAgdi0+djRsMl9pbnB1dF9zdGF0 dXMgPyAiVW5sb2NrIiA6ICJMb2NrIik7Cj4+ICsJc2VxX3ByaW50ZihzLCAiICAlLTIwczpcdCVk XG4iLCAiV2lkdGgiLCB2LT5waXhfZm10LndpZHRoKTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICUt MjBzOlx0JWRcbiIsICJIZWlnaHQiLCB2LT5waXhfZm10LmhlaWdodCk7Cj4+ICsJc2VxX3ByaW50 ZihzLCAiICAlLTIwczpcdCVkXG4iLCAiRlJDIiwgdi0+ZnJhbWVfcmF0ZSk7Cj4+ICsKPj4gKwlz ZXFfcHV0cyhzLCAiXG4iKTsKPj4gKwo+PiArCXNlcV9wdXRzKHMsICJQZXJmb3JtYW5jZTpcbiIp Owo+PiArCXNlcV9wcmludGYocywgIiAgJS0yMHM6XHQlZFxuIiwgIkZyYW1lIyIsIHYtPnNlcXVl bmNlKTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICUtMjBzOlxuIiwgIkZyYW1lIER1cmF0aW9uIik7 Cj4+ICsJc2VxX3ByaW50ZihzLCAiICAgICUtMThzOlx0JWRcbiIsICJOb3ciLCB2LT5wZXJmLmR1 cmF0aW9uKTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICAgJS0xOHM6XHQlZFxuIiwgIk1pbiIsIHYt PnBlcmYuZHVyYXRpb25fbWluKTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICAgJS0xOHM6XHQlZFxu IiwgIk1heCIsIHYtPnBlcmYuZHVyYXRpb25fbWF4KTsKPj4gKwlzZXFfcHJpbnRmKHMsICIgICUt MjBzOlx0JWRcbiIsICJGUFMobXMpIiwgMTAwMC8odi0+cGVyZi50b3RhbHRpbWUvdi0+c2VxdWVu Y2UpKTsKPj4gKwo+PiArCj4+ICsJcmV0dXJuIDA7Cj4+ICt9Cj4+ICsKPj4gK2ludCBhc3BlZWRf dmlkZW9fcHJvY19vcGVuKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWxlICpmaWxlKQo+ PiArewo+PiArCXJldHVybiBzaW5nbGVfb3BlbihmaWxlLCBhc3BlZWRfdmlkZW9fZGVidWdmc19z aG93LCBpbm9kZS0+aV9wcml2YXRlKTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHN0cnVjdCBmaWxl X29wZXJhdGlvbnMgYXNwZWVkX3ZpZGVvX2RlYnVnZnNfb3BzID0gewo+PiArCS5vd25lciAgID0g VEhJU19NT0RVTEUsCj4+ICsJLm9wZW4gICAgPSBhc3BlZWRfdmlkZW9fcHJvY19vcGVuLAo+PiAr CS5yZWFkICAgID0gc2VxX3JlYWQsCj4+ICsJLmxsc2VlayAgPSBzZXFfbHNlZWssCj4+ICsJLnJl bGVhc2UgPSBzaW5nbGVfcmVsZWFzZSwKPj4gK307Cj4+ICsKPj4gK3N0YXRpYyBzdHJ1Y3QgZGVu dHJ5ICpkZWJ1Z2ZzX2VudHJ5Owo+PiArCj4+ICtzdGF0aWMgdm9pZCBhc3BlZWRfdmlkZW9fZGVi dWdmc19yZW1vdmUoc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8pCj4+ICt7Cj4+ICsJZGVidWdm c19yZW1vdmVfcmVjdXJzaXZlKGRlYnVnZnNfZW50cnkpOwo+PiArCWRlYnVnZnNfZW50cnkgPSBO VUxMOwo+PiArfQo+PiArCj4+ICtzdGF0aWMgaW50IGFzcGVlZF92aWRlb19kZWJ1Z2ZzX2NyZWF0 ZShzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbykKPj4gK3sKPj4gKwlkZWJ1Z2ZzX2VudHJ5ID0g ZGVidWdmc19jcmVhdGVfZmlsZShERVZJQ0VfTkFNRSwgMDQ0NCwgTlVMTCwKPj4gKwkJCQkJCSAg IHZpZGVvLAo+PiArCQkJCQkJICAgJmFzcGVlZF92aWRlb19kZWJ1Z2ZzX29wcyk7Cj4+ICsJaWYg KCFkZWJ1Z2ZzX2VudHJ5KQo+PiArCQlhc3BlZWRfdmlkZW9fZGVidWdmc19yZW1vdmUodmlkZW8p Owo+IFRoaXMgY2hlY2sgd2lsbCBuZXZlciBoYXBwZW4sIHdoeSBhcmUgeW91IG1ha2luZyBpdD8K Pgo+IFRoZXJlJ3Mgbm8gbmVlZCB0byBjYXJlIGlmIGRlYnVnZnMgd29ya3Mgb3Igbm90LCBqdXN0 IGNyZWF0ZSB0aGUgZmlsZQo+IGFuZCBtb3ZlIG9uLiAgVGhpcyBmdW5jdGlvbiBzaG91bGQgbm90 IHJldHVybiBhbnl0aGluZy4KPgo+PiArCj4+ICsJcmV0dXJuIGRlYnVnZnNfZW50cnkgPT0gTlVM TCA/IC1FSU8gOiAwOwo+PiArfQo+PiArI2Vsc2UKPj4gK3N0YXRpYyB2b2lkIGFzcGVlZF92aWRl b19kZWJ1Z2ZzX3JlbW92ZShzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbykgeyB9Cj4+ICtzdGF0 aWMgaW50IGFzcGVlZF92aWRlb19kZWJ1Z2ZzX2NyZWF0ZShzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2 aWRlbykKPj4gK3sKPj4gKwlyZXR1cm4gMDsKPj4gK30KPj4gKyNlbmRpZiAvKiBDT05GSUdfREVC VUdfRlMgKi8KPj4gKwo+PiAgIHN0YXRpYyBpbnQgYXNwZWVkX3ZpZGVvX3NldHVwX3ZpZGVvKHN0 cnVjdCBhc3BlZWRfdmlkZW8gKnZpZGVvKQo+PiAgIHsKPj4gICAJY29uc3QgdTY0IG1hc2sgPSB+ KEJJVChWNEwyX0pQRUdfQ0hST01BX1NVQlNBTVBMSU5HXzQ0NCkgfAo+PiBAQCAtMTcwOCw2ICsx ODAzLDEwIEBAIHN0YXRpYyBpbnQgYXNwZWVkX3ZpZGVvX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpCj4+ICAgCQlyZXR1cm4gcmM7Cj4+ICAgCX0KPj4gICAKPj4gKwlyYyA9IGFz cGVlZF92aWRlb19kZWJ1Z2ZzX2NyZWF0ZSh2aWRlbyk7Cj4+ICsJaWYgKHJjKQo+PiArCQlkZXZf ZXJyKHZpZGVvLT5kZXYsICJkZWJ1Z2ZzIGNyZWF0ZSBmYWlsZWRcbiIpOwo+IEFzIHByb29mIG9m IHRoaXMsIHlvdSBkb24ndCBjYXJlIGlmIHRoaXMgZG9lc24ndCB3b3JrLCB5b3UganVzdCBwcmlu dAo+IG91dCBhIG1lc3NhZ2UgdGhhdCB3YXMgYWxyZWFkeSBwcmludGVkIG91dCA6KAo+Cj4gdGhh bmtzLAo+Cj4gZ3JlZyBrLWgKCi0tIAotLQpCZXN0IFJlZ2FyZHMKSmFtbXkKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2A2C433EF for ; Mon, 25 Oct 2021 10:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7437D60FDC for ; Mon, 25 Oct 2021 10:07:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbhJYKJ7 (ORCPT ); Mon, 25 Oct 2021 06:09:59 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:34353 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbhJYKJ6 (ORCPT ); Mon, 25 Oct 2021 06:09:58 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 19P9idqG002949; Mon, 25 Oct 2021 17:44:39 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Oct 2021 18:06:57 +0800 Message-ID: Date: Mon, 25 Oct 2021 18:06:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] media: aspeed: add debugfs Content-Language: en-US To: Greg KH CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW References: <20210929090024.8499-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 19P9idqG002949 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dear Greg, Yes, you are right. I will update accordingly. On 2021/10/25 下午 03:59, Greg KH wrote: > On Wed, Sep 29, 2021 at 05:00:25PM +0800, Jammy Huang wrote: >> To show video real-time information as below: >> >> Caputre: >> Signal : Unlock >> Width : 1920 >> Height : 1080 >> FRC : 30 >> >> Performance: >> Frame# : 0 >> Frame Duration : >> Now : 0 >> Min : 0 >> Max : 0 >> FPS(ms) : 0 >> >> Change-Id: I483740c4df6db07a9261c18440472a0356512bb7 >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed-video.c | 101 ++++++++++++++++++++++++++ >> 1 file changed, 101 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 8b3939b8052d..c5c413844441 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -21,6 +21,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -203,6 +205,14 @@ struct aspeed_video_buffer { >> struct list_head link; >> }; >> >> +struct aspeed_video_perf { >> + ktime_t last_sample; >> + u32 totaltime; >> + u32 duration; >> + u32 duration_min; >> + u32 duration_max; >> +}; >> + >> #define to_aspeed_video_buffer(x) \ >> container_of((x), struct aspeed_video_buffer, vb) >> >> @@ -241,6 +251,8 @@ struct aspeed_video { >> unsigned int frame_left; >> unsigned int frame_right; >> unsigned int frame_top; >> + >> + struct aspeed_video_perf perf; >> }; >> >> #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) >> @@ -444,6 +456,16 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> readl(video->base + reg)); >> } >> >> +static void update_perf(struct aspeed_video_perf *p) >> +{ >> + p->duration = >> + ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> + p->totaltime += p->duration; >> + >> + p->duration_max = max(p->duration, p->duration_max); >> + p->duration_min = min(p->duration, p->duration_min); >> +} >> + >> static int aspeed_video_start_frame(struct aspeed_video *video) >> { >> dma_addr_t addr; >> @@ -482,6 +504,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) >> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >> VE_INTERRUPT_COMP_COMPLETE); >> >> + video->perf.last_sample = ktime_get(); >> + >> aspeed_video_update(video, VE_SEQ_CTRL, 0, >> VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); >> >> @@ -600,6 +624,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> u32 frame_size = aspeed_video_read(video, >> VE_JPEG_COMP_SIZE_READ_BACK); >> >> + update_perf(&video->perf); >> + >> spin_lock(&video->lock); >> clear_bit(VIDEO_FRAME_INPRG, &video->flags); >> buf = list_first_entry_or_null(&video->buffers, >> @@ -760,6 +786,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >> det->width = MIN_WIDTH; >> det->height = MIN_HEIGHT; >> video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; >> + memset(&video->perf, 0, sizeof(video->perf)); >> >> do { >> if (tries) { >> @@ -1450,6 +1477,8 @@ static int aspeed_video_start_streaming(struct vb2_queue *q, >> struct aspeed_video *video = vb2_get_drv_priv(q); >> >> video->sequence = 0; >> + video->perf.duration_max = 0; >> + video->perf.duration_min = 0xffffffff; >> >> rc = aspeed_video_start_frame(video); >> if (rc) { >> @@ -1517,6 +1546,72 @@ static const struct vb2_ops aspeed_video_vb2_ops = { >> .buf_queue = aspeed_video_buf_queue, >> }; >> >> +#ifdef CONFIG_DEBUG_FS >> +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) >> +{ >> + struct aspeed_video *v = s->private; >> + >> + seq_puts(s, "\n"); >> + >> + seq_printf(s, " %-20s:\t%s\n", "Signal", >> + v->v4l2_input_status ? "Unlock" : "Lock"); >> + seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); >> + seq_printf(s, " %-20s:\t%d\n", "Height", v->pix_fmt.height); >> + seq_printf(s, " %-20s:\t%d\n", "FRC", v->frame_rate); >> + >> + seq_puts(s, "\n"); >> + >> + seq_puts(s, "Performance:\n"); >> + seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); >> + seq_printf(s, " %-20s:\n", "Frame Duration"); >> + seq_printf(s, " %-18s:\t%d\n", "Now", v->perf.duration); >> + seq_printf(s, " %-18s:\t%d\n", "Min", v->perf.duration_min); >> + seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); >> + seq_printf(s, " %-20s:\t%d\n", "FPS(ms)", 1000/(v->perf.totaltime/v->sequence)); >> + >> + >> + return 0; >> +} >> + >> +int aspeed_video_proc_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, aspeed_video_debugfs_show, inode->i_private); >> +} >> + >> +static struct file_operations aspeed_video_debugfs_ops = { >> + .owner = THIS_MODULE, >> + .open = aspeed_video_proc_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> + .release = single_release, >> +}; >> + >> +static struct dentry *debugfs_entry; >> + >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) >> +{ >> + debugfs_remove_recursive(debugfs_entry); >> + debugfs_entry = NULL; >> +} >> + >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, >> + video, >> + &aspeed_video_debugfs_ops); >> + if (!debugfs_entry) >> + aspeed_video_debugfs_remove(video); > This check will never happen, why are you making it? > > There's no need to care if debugfs works or not, just create the file > and move on. This function should not return anything. > >> + >> + return debugfs_entry == NULL ? -EIO : 0; >> +} >> +#else >> +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } >> +static int aspeed_video_debugfs_create(struct aspeed_video *video) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_DEBUG_FS */ >> + >> static int aspeed_video_setup_video(struct aspeed_video *video) >> { >> const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | >> @@ -1708,6 +1803,10 @@ static int aspeed_video_probe(struct platform_device *pdev) >> return rc; >> } >> >> + rc = aspeed_video_debugfs_create(video); >> + if (rc) >> + dev_err(video->dev, "debugfs create failed\n"); > As proof of this, you don't care if this doesn't work, you just print > out a message that was already printed out :( > > thanks, > > greg k-h -- -- Best Regards Jammy