From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971DAC4338F for ; Fri, 6 Aug 2021 07:34:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC3160F02 for ; Fri, 6 Aug 2021 07:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBC3160F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBuNW-0001Ar-1R for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 03:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBuMv-0000RO-LM for qemu-devel@nongnu.org; Fri, 06 Aug 2021 03:34:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBuMu-00014c-9L for qemu-devel@nongnu.org; Fri, 06 Aug 2021 03:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628235251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N607d6Qj+agwebLIz5XbRtbDh7bYY8ilkd0dt28DGcU=; b=efq3tXCksiPwAfGb3lKaL8KCo60ra56Duq3p0HKRcZPgJPIclKPXeOJGJyB15PSDdQxrU0 eVtBgHX71fKaGSJl8N76NAHPn5iS0uSiFilEK8rkGXRMrPRs/NgOKYNbSL7NDj8QAdW+qG 178ii0OwJ5nxGeMzd55Ks/qaMKEwmYE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-40fkUO0oPwKVMWBFK8i6Iw-1; Fri, 06 Aug 2021 03:34:10 -0400 X-MC-Unique: 40fkUO0oPwKVMWBFK8i6Iw-1 Received: by mail-wm1-f71.google.com with SMTP id d72-20020a1c1d4b0000b029025164ff3ebfso3565366wmd.7 for ; Fri, 06 Aug 2021 00:34:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=N607d6Qj+agwebLIz5XbRtbDh7bYY8ilkd0dt28DGcU=; b=l7f0Ehq/4cjFEc8lnk7S8ARWFodB79r01MzKRkdVWEGUTZfA/Lfi9qdiOkeDzKDpv3 OrxBOWRqk56f6P7OK50rwBNomXf14n4j4n3HJOM+i0twJerVWDRgEDBXp8ZhJwQiWOkj HToGzBypURmxbv0v3Zuroa4/O2/LVSV5oqH9XEZD/ddZ5QwN1cmO24oDKEQ4/8gYTd7r UQKbck6g/tMdRXCwzDHvilGatufJ2Ggw66JSgaduhTD6IBqmfF1lusBYgRJjURb56bHE 8Dl9xKnJPKXEGD2JtdYr8sWAa+6dxaG9Yw/dk2zlMkRWh/7u8TmqywgvWuuCrCNuAPPC 7VoQ== X-Gm-Message-State: AOAM533GSIu9tWcI88b11KWU2nhw+Pa65hirJpjTBuq1o/qMjtS4c2OG QXnvd92hcfmZsJmRvo+ZO7cYJ/BFILhC00GrGlUPt+cfMY+7c7CL96roV1qa8/BWvjVHibNSA3H cBSjjkD7Z+fXfLq4= X-Received: by 2002:a5d:5987:: with SMTP id n7mr9431030wri.260.1628235249503; Fri, 06 Aug 2021 00:34:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd4ELalBbJhyHAkijULtMMYnRLQ6J7Tke9yt5D7ZZBRG/dpmdopJs5LL+lT4JRqF3cB8WIsA== X-Received: by 2002:a5d:5987:: with SMTP id n7mr9431005wri.260.1628235249377; Fri, 06 Aug 2021 00:34:09 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6104.dip0.t-ipconnect.de. [91.12.97.4]) by smtp.gmail.com with ESMTPSA id r2sm8306926wrx.27.2021.08.06.00.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Aug 2021 00:34:08 -0700 (PDT) Subject: Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce() To: Thomas Huth , qemu-devel@nongnu.org References: <20210805152804.100333-1-david@redhat.com> <20210805152804.100333-6-david@redhat.com> <3a4db6af-3f9a-634a-6ff3-2e6cc875b886@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 6 Aug 2021 09:34:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3a4db6af-3f9a-634a-6ff3-2e6cc875b886@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.132, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason J . Herne" , Janosch Frank , Cornelia Huck , Richard Henderson , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Claudio Imbrenda Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06.08.21 09:30, Thomas Huth wrote: > Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") > > Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At least in the kernel people will really complain if you do that (because it might result in backports of patches that are absolutely not worth backporting and makes actual bugfixes harder to track). But maybe QEMUs policy is different, so I can add it. -- Thanks, David / dhildenb