From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [RFC PATCH 14/20] intel_iommu: add FOR_EACH_ASSIGN_DEVICE macro Date: Fri, 28 Apr 2017 15:33:28 +0800 Message-ID: References: <1493201210-14357-1-git-send-email-yi.l.liu@linux.intel.com> <1493201210-14357-15-git-send-email-yi.l.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1493201210-14357-15-git-send-email-yi.l.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Liu, Yi L" , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, peterx-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gMjAxN+W5tDA05pyIMjbml6UgMTg6MDYsIExpdSwgWWkgTCB3cm90ZToKPiBBZGQgRk9SX0VB Q0hfQVNTSUdOX0RFVklDRS4gSXQgd291bGQgYmUgdXNlZCB0byBsb29wIGFsbCBhc3NpZ25lZAo+ IGRldmljZXMgd2hlbiBwcm9jZXNzaW5nIGd1ZXN0IHBhc2lkIHRhYmxlIGxpbmtpbmcgYW5kIGlv bW11IGNhY2hlCj4gaW52YWxpZGF0ZSBwcm9wYWdhdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBM aXUsIFlpIEwgPHlpLmwubGl1QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgaHcvaTM4Ni9pbnRl bF9pb21tdS5jICAgICAgICAgIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK PiAgaHcvaTM4Ni9pbnRlbF9pb21tdV9pbnRlcm5hbC5oIHwgMTEgKysrKysrKysrKysKPiAgMiBm aWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2h3L2kzODYv aW50ZWxfaW9tbXUuYyBiL2h3L2kzODYvaW50ZWxfaW9tbXUuYwo+IGluZGV4IDBjNDEyZDIuLmYy OTE5OTUgMTAwNjQ0Cj4gLS0tIGEvaHcvaTM4Ni9pbnRlbF9pb21tdS5jCj4gKysrIGIvaHcvaTM4 Ni9pbnRlbF9pb21tdS5jCj4gQEAgLTU1LDYgKzU1LDM4IEBAIHN0YXRpYyBpbnQgdnRkX2RiZ2Zs YWdzID0gVlREX0RCR0JJVChHRU5FUkFMKSB8IFZURF9EQkdCSVQoQ1NSKTsKPiAgI2RlZmluZSBW VERfRFBSSU5URih3aGF0LCBmbXQsIC4uLikgZG8ge30gd2hpbGUgKDApCj4gICNlbmRpZgo+ICAK PiArI2RlZmluZSBGT1JfRUFDSF9BU1NJR05fREVWSUNFKF9fbm90aWZ5X2luZm9fdHlwZSwgXAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19vcGFxdWVfdHlwZSwgXAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgX19ob29rX2luZm8sIFwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF9faG9va19mbikgXAo+ICtkbyB7IFwKPiArICAgIEludGVsSU9N TVVOb3RpZmllck5vZGUgKm5vZGU7IFwKPiArICAgIFZURE5vdGlmaWVySXRlcmF0b3IgaXRlcmF0 b3I7IFwKPiArICAgIGludCByZXQgPSAwOyBcCj4gKyAgICBfX25vdGlmeV9pbmZvX3R5cGUgKm5v dGlmeV9pbmZvOyBcCj4gKyAgICBfX29wYXF1ZV90eXBlICpvcGFxOyBcCj4gKyAgICBpbnQgYXJn c3o7IFwKPiArICAgIGFyZ3N6ID0gc2l6ZW9mKCpub3RpZnlfaW5mbykgKyBzaXplb2YoKm9wYXEp OyBcCj4gKyAgICBub3RpZnlfaW5mbyA9IGdfbWFsbG9jMChhcmdzeik7IFwKPiArICAgIFFMSVNU X0ZPUkVBQ0gobm9kZSwgJihzLT5ub3RpZmllcnNfbGlzdCksIG5leHQpIHsgXAo+ICsgICAgICAg IFZUREFkZHJlc3NTcGFjZSAqdnRkX2FzID0gbm9kZS0+dnRkX2FzOyBcCj4gKyAgICAgICAgVlRE Q29udGV4dEVudHJ5IGNlWzJdOyBcCj4gKyAgICAgICAgaXRlcmF0b3IuYnVzID0gcGNpX2J1c19u dW0odnRkX2FzLT5idXMpOyBcCj4gKyAgICAgICAgcmV0ID0gdnRkX2Rldl90b19jb250ZXh0X2Vu dHJ5KHMsIGl0ZXJhdG9yLmJ1cywgXAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dnRkX2FzLT5kZXZmbiwgJmNlWzBdKTsgXAo+ICsgICAgICAgIGlmIChyZXQgIT0gMCkgeyBcCj4g KyAgICAgICAgICAgIGNvbnRpbnVlOyBcCj4gKyAgICAgICAgfSBcCj4gKyAgICAgICAgaXRlcmF0 b3Iuc2lkID0gdnRkX21ha2Vfc291cmNlX2lkKGl0ZXJhdG9yLmJ1cywgdnRkX2FzLT5kZXZmbik7 IFwKPiArICAgICAgICBpdGVyYXRvci5kaWQgPSAgVlREX0NPTlRFWFRfRU5UUllfRElEKGNlWzBd LmhpKTsgXAo+ICsgICAgICAgIGl0ZXJhdG9yLmhvc3Rfc2lkID0gbm9kZS0+aG9zdF9zaWQ7IFwK PiArICAgICAgICBpdGVyYXRvci52dGRfYXMgPSB2dGRfYXM7IFwKPiArICAgICAgICBpdGVyYXRv ci5jZSA9ICZjZVswXTsgXAo+ICsgICAgICAgIF9faG9va19mbigmaXRlcmF0b3IsIF9faG9va19p bmZvLCBub3RpZnlfaW5mbyk7IFwKPiArICAgIH0gXAo+ICsgICAgZ19mcmVlKG5vdGlmeV9pbmZv KTsgXAo+ICt9IHdoaWxlICgwKQo+ICsKPiAgc3RhdGljIHZvaWQgdnRkX2RlZmluZV9xdWFkKElu dGVsSU9NTVVTdGF0ZSAqcywgaHdhZGRyIGFkZHIsIHVpbnQ2NF90IHZhbCwKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IHdtYXNrLCB1aW50NjRfdCB3MWNtYXNrKQo+ICB7 Cj4gZGlmZiAtLWdpdCBhL2h3L2kzODYvaW50ZWxfaW9tbXVfaW50ZXJuYWwuaCBiL2h3L2kzODYv aW50ZWxfaW9tbXVfaW50ZXJuYWwuaAo+IGluZGV4IGYyYTdkMTIuLjUxNzgzOTggMTAwNjQ0Cj4g LS0tIGEvaHcvaTM4Ni9pbnRlbF9pb21tdV9pbnRlcm5hbC5oCj4gKysrIGIvaHcvaTM4Ni9pbnRl bF9pb21tdV9pbnRlcm5hbC5oCj4gQEAgLTQzOSw2ICs0MzksMTcgQEAgdHlwZWRlZiBzdHJ1Y3Qg VlREUm9vdEVudHJ5IFZURFJvb3RFbnRyeTsKPiAgI2RlZmluZSBWVERfRVhUX0NPTlRFWFRfVFRf Tk9fREVWX0lPVExCICAgKDRVTEwgPDwgMikKPiAgI2RlZmluZSBWVERfRVhUX0NPTlRFWFRfVFRf REVWX0lPVExCICAgICAgKDVVTEwgPDwgMikKPiAgCj4gK3N0cnVjdCBWVEROb3RpZmllckl0ZXJh dG9yIHsKPiArICAgIFZUREFkZHJlc3NTcGFjZSAqdnRkX2FzOwo+ICsgICAgVlREQ29udGV4dEVu dHJ5ICpjZTsKPiArICAgIHVpbnQxNl90IGhvc3Rfc2lkOwo+ICsgICAgdWludDE2X3Qgc2lkOwo+ ICsgICAgdWludDE2X3QgZGlkOwo+ICsgICAgdWludDhfdCAgYnVzOwoKVGhlICJidXMiIHNlZW1z IHRvIGJlIHJlZHVuZGFudC4KSXQgaXMgYWxyZWFkeSBjb250YWluZWQgaW4gdGhlICJzaWQiLCBy aWdodD8KCj4gK307Cj4gKwo+ICt0eXBlZGVmIHN0cnVjdCBWVEROb3RpZmllckl0ZXJhdG9yIFZU RE5vdGlmaWVySXRlcmF0b3I7Cj4gKwo+ICAvKiBQYWdpbmcgU3RydWN0dXJlIGNvbW1vbiAqLwo+ ICAjZGVmaW5lIFZURF9TTF9QVF9QQUdFX1NJWkVfTUFTSyAgICAoMVVMTCA8PCA3KQo+ICAvKiBC aXRzIHRvIGRlY2lkZSB0aGUgb2Zmc2V0IGZvciBlYWNoIGxldmVsICovCj4gCgoKLS0gCkJlc3Qg cmVnYXJkcwpUaWFueXUgTGFuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9u Lm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9p b21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d40Xi-0004Gp-Km for qemu-devel@nongnu.org; Fri, 28 Apr 2017 03:42:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d40Xf-0001Ss-GN for qemu-devel@nongnu.org; Fri, 28 Apr 2017 03:42:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:58808) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d40Xf-0001SZ-5w for qemu-devel@nongnu.org; Fri, 28 Apr 2017 03:42:15 -0400 References: <1493201210-14357-1-git-send-email-yi.l.liu@linux.intel.com> <1493201210-14357-15-git-send-email-yi.l.liu@linux.intel.com> From: Lan Tianyu Message-ID: Date: Fri, 28 Apr 2017 15:33:28 +0800 MIME-Version: 1.0 In-Reply-To: <1493201210-14357-15-git-send-email-yi.l.liu@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 14/20] intel_iommu: add FOR_EACH_ASSIGN_DEVICE macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Yi L" , qemu-devel@nongnu.org, alex.williamson@redhat.com, peterx@redhat.com Cc: kvm@vger.kernel.org, jasowang@redhat.com, iommu@lists.linux-foundation.org, kevin.tian@intel.com, ashok.raj@intel.com, jacob.jun.pan@intel.com, yi.l.liu@intel.com, jean-philippe.brucker@arm.com On 2017年04月26日 18:06, Liu, Yi L wrote: > Add FOR_EACH_ASSIGN_DEVICE. It would be used to loop all assigned > devices when processing guest pasid table linking and iommu cache > invalidate propagation. > > Signed-off-by: Liu, Yi L > --- > hw/i386/intel_iommu.c | 32 ++++++++++++++++++++++++++++++++ > hw/i386/intel_iommu_internal.h | 11 +++++++++++ > 2 files changed, 43 insertions(+) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 0c412d2..f291995 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -55,6 +55,38 @@ static int vtd_dbgflags = VTD_DBGBIT(GENERAL) | VTD_DBGBIT(CSR); > #define VTD_DPRINTF(what, fmt, ...) do {} while (0) > #endif > > +#define FOR_EACH_ASSIGN_DEVICE(__notify_info_type, \ > + __opaque_type, \ > + __hook_info, \ > + __hook_fn) \ > +do { \ > + IntelIOMMUNotifierNode *node; \ > + VTDNotifierIterator iterator; \ > + int ret = 0; \ > + __notify_info_type *notify_info; \ > + __opaque_type *opaq; \ > + int argsz; \ > + argsz = sizeof(*notify_info) + sizeof(*opaq); \ > + notify_info = g_malloc0(argsz); \ > + QLIST_FOREACH(node, &(s->notifiers_list), next) { \ > + VTDAddressSpace *vtd_as = node->vtd_as; \ > + VTDContextEntry ce[2]; \ > + iterator.bus = pci_bus_num(vtd_as->bus); \ > + ret = vtd_dev_to_context_entry(s, iterator.bus, \ > + vtd_as->devfn, &ce[0]); \ > + if (ret != 0) { \ > + continue; \ > + } \ > + iterator.sid = vtd_make_source_id(iterator.bus, vtd_as->devfn); \ > + iterator.did = VTD_CONTEXT_ENTRY_DID(ce[0].hi); \ > + iterator.host_sid = node->host_sid; \ > + iterator.vtd_as = vtd_as; \ > + iterator.ce = &ce[0]; \ > + __hook_fn(&iterator, __hook_info, notify_info); \ > + } \ > + g_free(notify_info); \ > +} while (0) > + > static void vtd_define_quad(IntelIOMMUState *s, hwaddr addr, uint64_t val, > uint64_t wmask, uint64_t w1cmask) > { > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h > index f2a7d12..5178398 100644 > --- a/hw/i386/intel_iommu_internal.h > +++ b/hw/i386/intel_iommu_internal.h > @@ -439,6 +439,17 @@ typedef struct VTDRootEntry VTDRootEntry; > #define VTD_EXT_CONTEXT_TT_NO_DEV_IOTLB (4ULL << 2) > #define VTD_EXT_CONTEXT_TT_DEV_IOTLB (5ULL << 2) > > +struct VTDNotifierIterator { > + VTDAddressSpace *vtd_as; > + VTDContextEntry *ce; > + uint16_t host_sid; > + uint16_t sid; > + uint16_t did; > + uint8_t bus; The "bus" seems to be redundant. It is already contained in the "sid", right? > +}; > + > +typedef struct VTDNotifierIterator VTDNotifierIterator; > + > /* Paging Structure common */ > #define VTD_SL_PT_PAGE_SIZE_MASK (1ULL << 7) > /* Bits to decide the offset for each level */ > -- Best regards Tianyu Lan