Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

[Nick Vinson <nvinson234@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1612 bytes --]

On 03/22/2018 06:56 AM, Daniel Kiper wrote:
> On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote:
>> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new
>> partuuid target.  Update grub.texi documenation.
>>
>> Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
>> ---
>>  docs/grub.texi          |  9 +++++++++
>>  util/grub-mkconfig.in   |  3 +++
>>  util/grub.d/10_linux.in | 12 +++++++++---
>>  3 files changed, 21 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/grub.texi b/docs/grub.texi
>> index 65b4bbeda..b6a44eb6b 100644
>> --- a/docs/grub.texi
>> +++ b/docs/grub.texi
>> @@ -1424,6 +1424,15 @@ the Linux kernel, using a @samp{root=UUID=...} kernel parameter.  This is
>>  usually more reliable, but in some cases it may not be appropriate.  To
>>  disable the use of UUIDs, set this option to @samp{true}.
>>
>> +@item GRUB_ENABLE_LINUX_PARTUUID
>> +Setting this option to @samp{true} changes the behavior of
>> +@command{grub-mkconfig} so that it identifies the device containing the root
>> +filesystem by the partition UUID via the @samp{root=PARTUUID=...} kernel
>> +parameter.  This is desirable for Linux systems where identifying the root
>> +filesystem by its filesystem UUID or device name is imappropriate.  However,
> 
> s/imappropriate/inappropriate/

fixed

> 
>> +this option is only supported in Linux kernel versions least 2.6.37 (3.10 for
> 
> s/least/at least/?

I think s/least// would sound better than s/least/at least/.  Thoughts?

Thanks,
Nicholas Vinson

> 
> Otherwise LGTM.
> 
> Daniel
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]