All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aswath Govindraju <a-govindraju@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Sekhar Nori <nsekhar@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Pratyush Yadav <p.yadav@ti.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Vadym Kochan <vadym.kochan@plvision.eu>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation: devicetree: Add new compatible string for eeprom microchip 93LC46B
Date: Tue, 5 Jan 2021 12:23:37 +0530	[thread overview]
Message-ID: <fbcc277c-c8aa-1252-4e9f-ba8a4f5fd00a@ti.com> (raw)
In-Reply-To: <20201231191732.GA2198038@robh.at.kernel.org>

Hi Rob,

On 01/01/21 12:47 am, Rob Herring wrote:
> On Fri, Dec 18, 2020 at 07:38:10PM +0530, Aswath Govindraju wrote:
>> Add a new compatible string for eeprom microchip 93LC46B in eeprom-93xx46
>> dt-binding file as it belongs to the 93xx46 family of devices.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
>> index a8ebb4621f79..9f272361f117 100644
>> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
>> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
>> @@ -4,6 +4,7 @@ Required properties:
>>  - compatible : shall be one of:
>>      "atmel,at93c46d"
>>      "eeprom-93xx46"
>> +    "microchip,93LC46B"
> 
> Generally, we use lowercase and that's the existing pattern here.

ohh ok. I was trying to match the compatible string exactly with the the
device name. I will make this change in the respin.

Thanks,
Aswath

> 
>>  - data-size : number of data bits per word (either 8 or 16)
>>  
>>  Optional properties:
>> -- 
>> 2.17.1
>>


  reply	other threads:[~2021-01-05  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 14:08 [PATCH 0/2] eeprom: eeprom_93xx46: Add support for microchip 93LC46B eeprom Aswath Govindraju
2020-12-18 14:08 ` [PATCH 1/2] Documentation: devicetree: Add new compatible string for eeprom microchip 93LC46B Aswath Govindraju
2020-12-31 19:17   ` Rob Herring
2021-01-05  6:53     ` Aswath Govindraju [this message]
2020-12-18 14:08 ` [PATCH 2/2] misc: eeprom_93xx46: Add quirk to support Microchip 93LC46B eeprom Aswath Govindraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbcc277c-c8aa-1252-4e9f-ba8a4f5fd00a@ti.com \
    --to=a-govindraju@ti.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=p.yadav@ti.com \
    --cc=robh@kernel.org \
    --cc=vadym.kochan@plvision.eu \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.