From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B5D0C4345F for ; Tue, 23 Apr 2024 06:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X6NgwORzVZ3on/AoYY6xN8wcPe/bjOfwkkzi93gAIUY=; b=ATXtG1ZOrO1jFX c/rWzdL6rvBZWzTRjp5I8MuQKRJhcyXSNPVW6csK9wDnXRqN/BbWN1LON30Qs5noMcc8E7KUIaho7 mYd6LEkG+c86VdqnkT4+ILGjvqRAZZu6FSwRP1iCZfBkefFJ73WM5OuEAxUOvZONAbWbJS+QuSy/a TxKv4FS/jBJkOQjCEx2R+6Y4IZDIkfL6yex3/rwJEZYiQeN44UfAengNAfS8/E0MLhAhCxKih5/IT HPxU9FisB2g8evgILY1og/l2rlb+B5m5yUuDjHILm4bktA/ovrXrHBsUdr1jysRxYTPklT81TlkEp L9S0Ik2Xt/e/hhnoUBOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz9NS-0000000G6Dy-2uWe; Tue, 23 Apr 2024 06:11:39 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz9NP-0000000G6DV-0Vh5 for linux-riscv@lists.infradead.org; Tue, 23 Apr 2024 06:11:37 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0398040003; Tue, 23 Apr 2024 06:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713852691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=emJM6JECa8OhqTBhCwE/o7mPRrnseSWT8F4796SNfSo=; b=iGvnYS9mH/mNc/kmCknZxVTnmloR18k9z0DPL8exdP8dQHbFcbnLPPd7SO92i9nzwJF7fV e3+9O8qpfpMLpeH7KUpcT+PLXw1Z9+K+M5Z8p/tFiPi406YfxBKTlAj8V3cjwhAZX/fu8T x5XnOy9qcqZJITmZty25Mkggh3IWfqSWwyj0K34V6dqftxq+YpGdkUTUhoP51FLNST82cV 47kThbG+YS2Jr0HhluoyZYQov8N+PJ3g+WxAkjakwgC2TXKt3qwrG0WOk88hWfENB8rQ0g LwNUnED1+tvTj4/EaoxD2xM0HkLNlBihmWOP9xHl0CpKJMFWW7Vozx1jaR4QIw== Message-ID: Date: Tue, 23 Apr 2024 08:11:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: michael.opdenacker@bootlin.com, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] riscv: dts: sophgo: add initial Milk-V Duo S board support To: Inochi Amaoto , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20240417065311.3881023-1-michael.opdenacker@bootlin.com> <20240417065311.3881023-3-michael.opdenacker@bootlin.com> Content-Language: en-US From: Michael Opdenacker Organization: Bootlin In-Reply-To: X-GND-Sasl: michael.opdenacker@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_231135_564892_9BCB8CA2 X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgSW5vY2hpLAoKVGhhbmtzIGZvciB0aGUgYWR2aWNlLgoKT24gNC8yMS8yNCBhdCAwODozMCwg SW5vY2hpIEFtYW90byB3cm90ZToKPiBPbiBTdW4sIEFwciAyMSwgMjAyNCBhdCAwNzo1NzowMUFN IEdNVCwgTWljaGFlbCBPcGRlbmFja2VyIHdyb3RlOgo+ICsrKyBiL2FyY2gvcmlzY3YvYm9vdC9k dHMvc29waGdvL3NnMjAwMC1taWxrdi1kdW9zLmR0cwo+IEBAIC0wLDAgKzEsMzQgQEAKPiArLy8g U1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wIE9SIE1JVCkKPiArLyoKPiArICogQ29w eXJpZ2h0IChDKSAyMDI0IE1pY2hhZWwgT3BkZW5hY2tlciA8bWljaGFlbC5vcGRlbmFja2VyQGJv b3RsaW4uY29tPgo+ICsgKi8KPiArCj4gKy9kdHMtdjEvOwo+ICsKPiArI2luY2x1ZGUgImN2MTgx MmguZHRzaSIKPiArCj4gKy8gewo+ICsJbW9kZWwgPSAiTWlsay1WIER1byBTIjsKPiArCWNvbXBh dGlibGUgPSAibWlsa3YsZHVvcyIsICJzb3BoZ28sY3YxODEyaCI7Cj4gKwo+ICsJYWxpYXNlcyB7 Cj4gKwkJc2VyaWFsMCA9ICZ1YXJ0MDsKPiArCX07Cj4gKwo+ICsJY2hvc2VuIHsKPiArCQlzdGRv dXQtcGF0aCA9ICJzZXJpYWwwOjExNTIwMG44IjsKPiArCX07Cj4gKwo+ICsJbWVtb3J5QDgwMDAw MDAwIHsKPiArCQlkZXZpY2VfdHlwZSA9ICJtZW1vcnkiOwo+ICsJCXJlZyA9IDwweDgwMDAwMDAw IDB4MjAwMDAwMDA+Owo+ICsJfTsKPj4+IEFkZCBhIGNwdSBzcGVjaWZpYyBmaWxlLCBhbmQgbW92 ZSB0aGlzIHRvIGl0Lgo+PiBOb3cgdGhhdCBJJ20gaW5jbHVkaW5nICJjdjE4MTJoLmR0c2kiLCB3 aGljaCBoYXMgdGhlIHNhbWUgc3RydWN0dXJlLCBhbGwgSQo+PiBuZWVkIGlzIHRvIGNoYW5nZSB0 aGUgcmVnIHNldHRpbmcgdG8gaGF2ZSA1MTIgTUIgb2YgUkFNIGluc3RlYWQgb2YgMjU2TUIsCj4+ IHJpZ2h0PyBTZWUgdGhlIFY2IEknbSBzZW5kaW5nIHNvb24uCj4+Cj4gTm8sIER1byBTIGRvZXMg bm90IHVzZSBjdjE4MTJoLCBpbiBhbnkgbWVhbnMuIEkganVzdCB0b2xkIHlvdSB0byB1c2UKPiBj djE4MTJoIGZvciBsb2NhbCB0ZXN0LiBJZiB5b3Ugd2FudCB0byB1cHN0cmVhbSBEdW8gUywgeW91 IG11c3QgYWRkCj4gdGhlIHJpZ2h0IGNwdSBjb21wYXRpYmxlcyBhbmQgbmVjZXNzYXJ5IG5vZGVz LiBUaGVzZSB0d28gYXJlIGRpZmZlcmVudAo+IHRoaW5ncy4KClNvLCBkbyB5b3UgbWVhbiBJIHNo b3VsZCBjcmVhdGUgYSBuZXcgInNvcGhnbyxzZzIwMDAiIGNvbXBhdGlibGUsIAp0b2dldGhlciB3 aXRowqAgYSBuZXcgInNnMjAwMC5kdHNpIiAob3IgInNnMjAweC5kdHNpIj8pIGZpbGU/IENvdWxk IHRoaXMgCmZpbGUgaW5jbHVkZSAiY3YxOHh4LmR0c2kiPwoKQnkgdGhlIHdheSwgd2hlcmUncyB0 aGUgYmVzdCBzb3VyY2Ugb2YgaW5mb3JtYXRpb24gYWJvdXQgdGhlIFNvcGhnbyAKc2cyMDAwIGFu ZCBzZzIwMDIgcHJvY2Vzc29ycz8gRXZlbiB0aGUgU29waGdvIHdlYnNpdGUgZG9lc24ndCBzZWVt IHRvIApoYXZlIHRoZW0gOi0vIC4gSXQganVzdCBtZW50aW9ucyB0aGUgQ1YxOHh4IG9uZXMuCgpU aGFua3MgYWdhaW4KQ2hlZXJzCk1pY2hhZWwuCgotLSAKTWljaGFlbCBPcGRlbmFja2VyLCBCb290 bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGlu LmNvbQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF7E63C8; Tue, 23 Apr 2024 06:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713852696; cv=none; b=Zd0OQYsKxDb2F6SRXHb2IXwi9edVH4agyIkw+Y7jz+BmMXRDfO8AA9xAYugV+5B6P7En2ISv+5vo8tYzKANroMVct5Hq7winlEKr8Lap+vXZYV4uogJz7K92K3Yi9o0g90VGKCn8DmvnYxQ73kPObFdKAUYHQBD9fOrZu11X4hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713852696; c=relaxed/simple; bh=w31PcluYey0MaZLOk51qwGylQZCnQvX5ImKoMCDqQt8=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=dKYstuh/5b1Mzf/zJhgELJrwdHPTbtG0pBEqBWMK0jTKJa/iACJ6/fsUgrimumDRyAWhPa+llkZf6egWfhGtNBn7Z+MGlUfS6B5AexxAQ/UXaJCrBQSBlkwOmhu7bRQuQdp9f5ZNESgzsv9a5pIfwzIpSpwxMcEucF7IwdSRolY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=iGvnYS9m; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="iGvnYS9m" Received: by mail.gandi.net (Postfix) with ESMTPSA id 0398040003; Tue, 23 Apr 2024 06:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713852691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=emJM6JECa8OhqTBhCwE/o7mPRrnseSWT8F4796SNfSo=; b=iGvnYS9mH/mNc/kmCknZxVTnmloR18k9z0DPL8exdP8dQHbFcbnLPPd7SO92i9nzwJF7fV e3+9O8qpfpMLpeH7KUpcT+PLXw1Z9+K+M5Z8p/tFiPi406YfxBKTlAj8V3cjwhAZX/fu8T x5XnOy9qcqZJITmZty25Mkggh3IWfqSWwyj0K34V6dqftxq+YpGdkUTUhoP51FLNST82cV 47kThbG+YS2Jr0HhluoyZYQov8N+PJ3g+WxAkjakwgC2TXKt3qwrG0WOk88hWfENB8rQ0g LwNUnED1+tvTj4/EaoxD2xM0HkLNlBihmWOP9xHl0CpKJMFWW7Vozx1jaR4QIw== Message-ID: Date: Tue, 23 Apr 2024 08:11:29 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: michael.opdenacker@bootlin.com, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] riscv: dts: sophgo: add initial Milk-V Duo S board support To: Inochi Amaoto , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20240417065311.3881023-1-michael.opdenacker@bootlin.com> <20240417065311.3881023-3-michael.opdenacker@bootlin.com> Content-Language: en-US From: Michael Opdenacker Organization: Bootlin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: michael.opdenacker@bootlin.com Hi Inochi, Thanks for the advice. On 4/21/24 at 08:30, Inochi Amaoto wrote: > On Sun, Apr 21, 2024 at 07:57:01AM GMT, Michael Opdenacker wrote: > +++ b/arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2024 Michael Opdenacker > + */ > + > +/dts-v1/; > + > +#include "cv1812h.dtsi" > + > +/ { > + model = "Milk-V Duo S"; > + compatible = "milkv,duos", "sophgo,cv1812h"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x20000000>; > + }; >>> Add a cpu specific file, and move this to it. >> Now that I'm including "cv1812h.dtsi", which has the same structure, all I >> need is to change the reg setting to have 512 MB of RAM instead of 256MB, >> right? See the V6 I'm sending soon. >> > No, Duo S does not use cv1812h, in any means. I just told you to use > cv1812h for local test. If you want to upstream Duo S, you must add > the right cpu compatibles and necessary nodes. These two are different > things. So, do you mean I should create a new "sophgo,sg2000" compatible, together with  a new "sg2000.dtsi" (or "sg200x.dtsi"?) file? Could this file include "cv18xx.dtsi"? By the way, where's the best source of information about the Sophgo sg2000 and sg2002 processors? Even the Sophgo website doesn't seem to have them :-/ . It just mentions the CV18xx ones. Thanks again Cheers Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com