Re: [Intel-gfx] [PATCH] drm/i915/fdinfo: Don't show engine classes not present

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 16/06/2022 15:19, Umesh Nerlige Ramappa wrote:
> On Thu, Jun 16, 2022 at 03:00:56PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Stop displaying engine classes with no engines - it is not a huge problem
>> if they are shown, since the values will correctly be all zeroes, but it
>> does count as misleading.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via 
>> fdinfo")
>> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_drm_client.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drm_client.c 
>> b/drivers/gpu/drm/i915/i915_drm_client.c
>> index 18d38cb59923..b09d1d386574 100644
>> --- a/drivers/gpu/drm/i915/i915_drm_client.c
>> +++ b/drivers/gpu/drm/i915/i915_drm_client.c
>> @@ -116,8 +116,9 @@ show_client_class(struct seq_file *m,
>>         total += busy_add(ctx, class);
>>     rcu_read_unlock();
>>
>> -    seq_printf(m, "drm-engine-%s:\t%llu ns\n",
>> -           uabi_class_names[class], total);
>> +    if (capacity)
>> +        seq_printf(m, "drm-engine-%s:\t%llu ns\n",
>> +               uabi_class_names[class], total);
> 
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks, pushed!

Regards,

Tvrtko