From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CF0C61CE4 for ; Sun, 20 Jan 2019 08:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D462084C for ; Sun, 20 Jan 2019 08:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hc7Trr7P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730215AbfATIep (ORCPT ); Sun, 20 Jan 2019 03:34:45 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56274 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727294AbfATIep (ORCPT ); Sun, 20 Jan 2019 03:34:45 -0500 Received: by mail-wm1-f68.google.com with SMTP id y139so8024865wmc.5 for ; Sun, 20 Jan 2019 00:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jyWueqk5nsUksQKkc3ncR0S8mRLOSfQUxPf0n3qe0AU=; b=hc7Trr7PIycvLP4HRl/OMW7ACRFH0wsO1uypci9IhpDpykwwmLJ+qwEE05yHZpM5vS qu+fAO+KW2M2MX1IOec/uRIcZI1izrsFr0m0IyPFdF2smPqe6tFO/Bv7RhsXpXDCs3aa JbP3Tgo1rslzZ1stHwD4P7GnIGSoBt7Sj79CTiPGonbzg7vlSPdduMWIh3g4lmg/D/gt 9+IdK0JaAois72wthVyBdGIQH+5K6g8nPhIWKJSzUuYHmGS1yygTDsRh3o1Qdu0xQaWG LXm7fAP6EMUlaV/JY15daKh4jGBBTwWESvIREXmXfXvKUoYRfCN8+MWPp/I98fNjk7id NaEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jyWueqk5nsUksQKkc3ncR0S8mRLOSfQUxPf0n3qe0AU=; b=CLUwF+2rsVYIEU915BaAeS456I6jrlvk2UD/PNvvzIsCsf6EK62/I8aM4tExaGX4SN /B9aW/7PpKO9hOLMrmDsh+epkgfH0xWd1/iwWXgrl0w/xsiCOEh/C2PvMv6+KlezPPuo VM0szg6wMYtE4w8ozK08/Z3CQ7LiDo1XNj8JEMZgJIgFvn+4Os2Eop2Uw/dNr5Ajh3gL m6sYJNOHyzMegDSvYTQmn2QXefua0XdVe8xemQFMkx/RsPb454ruPUmCsiF8AB8mXr2M gpGhe6jxa30j9FVIX99Z6G6mAUIHOn1vzhE4blRwLu7H3+GEuRNoDXDqTrO+GWwswpAa XeIg== X-Gm-Message-State: AJcUukdIe4CVw4q/eiwfR7PeFJxpP9TEAA5SpsOcCgxMKf5RfKHXaTdV DLFzUU6/somA1hdAiz99higNJWQ1 X-Google-Smtp-Source: ALg8bN5sGertU/oIY7a/GyDJdYYTe3LmNnNUBYJcg8CL3b9TFaiH/8gTIT0wRUaLiNdtmDQ/m4nr1w== X-Received: by 2002:a1c:1f83:: with SMTP id f125mr20274801wmf.56.1547973283337; Sun, 20 Jan 2019 00:34:43 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:f1bd:c97d:6fa2:e035? (p200300EA8BF1E200F1BDC97D6FA2E035.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:f1bd:c97d:6fa2:e035]) by smtp.googlemail.com with ESMTPSA id 133sm52617910wme.9.2019.01.20.00.34.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jan 2019 00:34:42 -0800 (PST) Subject: Re: [PATCH net-next 4/4] net: phy: change phy_start_interrupts to phy_request_interrupt To: Florian Fainelli , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: <2d4ceacd-3b1d-84d5-02ab-32e508badc6a@gmail.com> <90f63d2a-e357-c1cb-0b11-09f57b44e0fb@gmail.com> <6147E439-53D4-4F0C-98D7-77B69E49C3D7@gmail.com> From: Heiner Kallweit Message-ID: Date: Sun, 20 Jan 2019 09:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <6147E439-53D4-4F0C-98D7-77B69E49C3D7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 20.01.2019 00:43, Florian Fainelli wrote: > > > On January 19, 2019 3:30:05 AM PST, Heiner Kallweit wrote: >> Now that we enable the interrupts in phy_start() we don't have to do it >> before. Therefore remove enabling interrupts from >> phy_start_interrupts() >> and rename this function to reflect the changed functionality. >> >> Signed-off-by: Heiner Kallweit >> --- > >> + * phy_request_interrupt - request interrupt for a PHY device >> * @phydev: target phy_device struct >> * >> * Description: Request the interrupt for the given PHY. >> * If this fails, then we set irq to PHY_POLL. >> - * Otherwise, we enable the interrupts in the PHY. >> * This should only be called with a valid IRQ number. >> - * Returns 0 on success or < 0 on error. >> */ >> -int phy_start_interrupts(struct phy_device *phydev) >> +void phy_request_interrupt(struct phy_device *phydev) >> { >> if (request_threaded_irq(phydev->irq, NULL, phy_interrupt, >> IRQF_ONESHOT | IRQF_SHARED, >> phydev_name(phydev), phydev) < 0) { >> phydev_warn(phydev, "Can't get IRQ %d\n", phydev->irq); >> phydev->irq = PHY_POLL; >> - return 0; >> } > > We should propagate the return code here and/or indicate we are falling back to polling since may not be desired. An use case that should be considered is probe deferral for instance. > I kept the current behavior to basically ignore the error and just warn and fall back to polling. Seems that phylib has behaved this way forever. If we come to the conclusion that changing this behavior makes sense, shouldn't we do it separately? Also we may break systems relying on the fallback to polling. But something we can easily agree on is to extend the warning to state that we fall back to polling.