From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B8A4C4167B for ; Fri, 30 Dec 2022 13:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:Cc:To:Subject: Message-ID:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K07iTwiqU9Ero03CiptI0RZoOjebmkasXhmeafKoiUs=; b=3sTFZ6vbDuKPdq l9yVfrecwHltdH/+RyS59lGtszUdZ+GmyMOiO9QOPvOU9Nosy5tE6Pk/pKdC24MJleoNWrn577V9c aOtdH22pkqPAchCVoue6YHgeUg6O8ecSwRQKJfoJPfLXvJ8HsuuCKHMN0kbBaUWQDr7GoL2+Shciu VioS/jDa+k4+588LSuXy/lN7nYCWooXnrdDRdINAOcY9FSvMbgzc4QVXgDOFVHRpD4s9xrK8n3vJn n2I+oMEmpy6FX3etaayVrIYA2ac8h62v2tFAG3nnRJsGbeTO6eloBt20PUXsAGN5dNgqJm/rVtLbd CFLUBfjCvKEIApk+P7Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBFZo-009aon-44; Fri, 30 Dec 2022 13:37:36 +0000 Received: from out2.migadu.com ([188.165.223.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBBVD-007dUR-9v for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 09:16:37 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1672391787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0YVvYHzhfhVLC1h+Hk5/AdGM7+lfwHu5eJUyiyijxE=; b=fXxK0Zq/6DQtLZRcmVE5W9LLUbEXWe8PezyuDVSm/8JdKiAEyRTU03Kf9iliXuOLvfnWyf 6Vvb0K0EeDyAJxvpVM7rb4Vh8mCLK+LqvLeprkxclueO/0kQZUz0QSu1jL+OKxK2GuCGU1 3bHSlqdpY5/+Tl3nq3FwR3eaK7+r9Mo= Date: Fri, 30 Dec 2022 09:16:26 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: Subject: Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare() To: rmk+kernel@armlinux.org.uk, keescook@chromium.org, gregkh@linuxfoundation.org, Jason@zx2c4.com, djwong@kernel.org, ebiederm@xmission.com, thunder.leizhen@huawei.com, ardb@kernel.org, wangkefeng.wang@huawei.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20221201031306.2782204-1-yajun.deng@linux.dev> References: <20221201031306.2782204-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_011636_551596_73D53CBA X-CRM114-Status: UNSURE ( 4.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org December 1, 2022 11:13 AM, "Yajun Deng" wrote: > arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is > just a wrapper for local_fiq_enable(). > > The local_fiq_enable() was already called before cpu_startup_entry(). > > So remove redundant arch_cpu_idle_prepare(). > > Signed-off-by: Yajun Deng > --- > arch/arm/kernel/process.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > index f811733a8fc5..e3f490ab95f4 100644 > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -81,11 +81,6 @@ void arch_cpu_idle(void) > raw_local_irq_enable(); > } > > -void arch_cpu_idle_prepare(void) > -{ > - local_fiq_enable(); > -} > - > void arch_cpu_idle_enter(void) > { > ledtrig_cpu(CPU_LED_IDLE_START); > -- > 2.25.1 Ping. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601E0C4167B for ; Fri, 30 Dec 2022 09:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234614AbiL3JQf (ORCPT ); Fri, 30 Dec 2022 04:16:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbiL3JQa (ORCPT ); Fri, 30 Dec 2022 04:16:30 -0500 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BC07DF4F for ; Fri, 30 Dec 2022 01:16:29 -0800 (PST) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1672391787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0YVvYHzhfhVLC1h+Hk5/AdGM7+lfwHu5eJUyiyijxE=; b=fXxK0Zq/6DQtLZRcmVE5W9LLUbEXWe8PezyuDVSm/8JdKiAEyRTU03Kf9iliXuOLvfnWyf 6Vvb0K0EeDyAJxvpVM7rb4Vh8mCLK+LqvLeprkxclueO/0kQZUz0QSu1jL+OKxK2GuCGU1 3bHSlqdpY5/+Tl3nq3FwR3eaK7+r9Mo= Date: Fri, 30 Dec 2022 09:16:26 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: Subject: Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare() To: rmk+kernel@armlinux.org.uk, keescook@chromium.org, gregkh@linuxfoundation.org, Jason@zx2c4.com, djwong@kernel.org, ebiederm@xmission.com, thunder.leizhen@huawei.com, ardb@kernel.org, wangkefeng.wang@huawei.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20221201031306.2782204-1-yajun.deng@linux.dev> References: <20221201031306.2782204-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org December 1, 2022 11:13 AM, "Yajun Deng" wrote:=0A= =0A> arch_cpu_idle_prepare() was only called by cpu_startup_entry() and i= t is=0A> just a wrapper for local_fiq_enable().=0A> =0A> The local_fiq_en= able() was already called before cpu_startup_entry().=0A> =0A> So remove = redundant arch_cpu_idle_prepare().=0A> =0A> Signed-off-by: Yajun Deng =0A> ---=0A> arch/arm/kernel/process.c | 5 -----=0A> 1= file changed, 5 deletions(-)=0A> =0A> diff --git a/arch/arm/kernel/proce= ss.c b/arch/arm/kernel/process.c=0A> index f811733a8fc5..e3f490ab95f4 100= 644=0A> --- a/arch/arm/kernel/process.c=0A> +++ b/arch/arm/kernel/process= .c=0A> @@ -81,11 +81,6 @@ void arch_cpu_idle(void)=0A> raw_local_irq_enab= le();=0A> }=0A> =0A> -void arch_cpu_idle_prepare(void)=0A> -{=0A> - local= _fiq_enable();=0A> -}=0A> -=0A> void arch_cpu_idle_enter(void)=0A> {=0A> = ledtrig_cpu(CPU_LED_IDLE_START);=0A> -- =0A> 2.25.1=0A=0APing.