From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: Klaus Jensen <its@irrelevant.dk>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Keith Busch <kbusch@kernel.org>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Jesper Devantier <foss@defmacro.it>
Subject: Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency
Date: Tue, 11 Aug 2026 10:31:10 +0200 [thread overview]
Message-ID: <fc24bc74-445a-4021-8559-aa1783b2379d@oss.qualcomm.com> (raw)
In-Reply-To: <anq_imtEJZ3XssyQ@AALNPWKJENSEN.aal.scsc.local>
On 11/8/26 08:22, Klaus Jensen wrote:
> On Aug 10 17:48, Stefan Hajnoczi wrote:
>> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
>> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
>> without SPDM_SOCKET.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> hw/nvme/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
>> index cfa2ab0f9d5..cfeeed64cd7 100644
>> --- a/hw/nvme/Kconfig
>> +++ b/hw/nvme/Kconfig
>> @@ -2,3 +2,4 @@ config NVME_PCI
>> bool
>> default y if PCI_DEVICES || PCIE_DEVICES
>> depends on PCI
>> + select SPDM_SOCKET
>> --
>> 2.55.0
>>
>>
>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
>
> Stefan, Philippe,
>
> Do you want to grab this through trivial fixes tree or should I send a
> pull?
Sure, queued via hw-misc, thanks!
prev parent reply other threads:[~2026-08-11 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 21:48 [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency Stefan Hajnoczi
2026-08-10 21:54 ` Philippe Mathieu-Daudé
2026-08-11 6:22 ` Klaus Jensen
2026-08-11 8:31 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc24bc74-445a-4021-8559-aa1783b2379d@oss.qualcomm.com \
--to=philmd@oss.qualcomm.com \
--cc=foss@defmacro.it \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.